Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1582855 > unrolled thread
| Started by | Bernd Faust <berndfaust@gmail.com> |
|---|---|
| First post | 2017-02-16 19:50 +0100 |
| Last post | 2017-02-28 22:20 +0100 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller Bernd Faust <berndfaust@gmail.com> - 2017-02-16 19:50 +0100
Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller "Neftin, Sasha" <sasha.neftin@intel.com> - 2017-02-19 14:00 +0100
Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller "Neftin, Sasha" <sasha.neftin@intel.com> - 2017-02-26 10:20 +0100
Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller "Neftin, Sasha" <sasha.neftin@intel.com> - 2017-02-27 09:30 +0100
Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller "Neftin, Sasha" <sasha.neftin@intel.com> - 2017-02-27 09:50 +0100
RE: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller "Keller, Jacob E" <jacob.e.keller@intel.com> - 2017-02-28 22:20 +0100
| From | Bernd Faust <berndfaust@gmail.com> |
|---|---|
| Date | 2017-02-16 19:50 +0100 |
| Subject | [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller |
| Message-ID | <tbzhU-1Tc-15@gated-at.bofh.it> |
After an upgrade to Linux kernel v4.x the hardware timestamps of the
82579 Gigabit Ethernet Controller are different than expected.
The values that are being read are almost four times as big as before
the kernel upgrade.
The difference is that after the upgrade the driver sets the clock
frequency to 25MHz, where before the upgrade it was set to 96MHz. Intel
confirmed that the correct frequency for this network adapter is 96MHz.
Signed-off-by: Bernd Faust <berndfaust@gmail.com>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index 7017281..8b7113d 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -3511,6 +3511,12 @@ s32 e1000e_get_base_timinca(struct e1000_adapter *adapter, u32 *timinca)
switch (hw->mac.type) {
case e1000_pch2lan:
+ /* Stable 96MHz frequency */
+ incperiod = INCPERIOD_96MHz;
+ incvalue = INCVALUE_96MHz;
+ shift = INCVALUE_SHIFT_96MHz;
+ adapter->cc.shift = shift + INCPERIOD_SHIFT_96MHz;
+ break;
case e1000_pch_lpt:
if (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) {
/* Stable 96MHz frequency */
--
2.7.4
[toc] | [next] | [standalone]
| From | "Neftin, Sasha" <sasha.neftin@intel.com> |
|---|---|
| Date | 2017-02-19 14:00 +0100 |
| Subject | Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller |
| Message-ID | <tczfQ-7u2-1@gated-at.bofh.it> |
| In reply to | #1582855 |
On 2/16/2017 20:42, Bernd Faust wrote:
> After an upgrade to Linux kernel v4.x the hardware timestamps of the
> 82579 Gigabit Ethernet Controller are different than expected.
> The values that are being read are almost four times as big as before
> the kernel upgrade.
>
> The difference is that after the upgrade the driver sets the clock
> frequency to 25MHz, where before the upgrade it was set to 96MHz. Intel
> confirmed that the correct frequency for this network adapter is 96MHz.
>
> Signed-off-by: Bernd Faust <berndfaust@gmail.com>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index 7017281..8b7113d 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -3511,6 +3511,12 @@ s32 e1000e_get_base_timinca(struct e1000_adapter *adapter, u32 *timinca)
>
> switch (hw->mac.type) {
> case e1000_pch2lan:
> + /* Stable 96MHz frequency */
> + incperiod = INCPERIOD_96MHz;
> + incvalue = INCVALUE_96MHz;
> + shift = INCVALUE_SHIFT_96MHz;
> + adapter->cc.shift = shift + INCPERIOD_SHIFT_96MHz;
> + break;
> case e1000_pch_lpt:
> if (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) {
> /* Stable 96MHz frequency */
> --
> 2.7.4
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@lists.osuosl.org
> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Hello,
e1000_pch2lan mac type corresponds to 82579LM and 82579V network
adapters. System clock frequency indication (SYSCFI) for these devices
supports both 25MHz and 96MHz frequency. By default TSYNCRXCTL.SYSCFI is
set to 1 and that means 96MHz frequency is picked.
It is better to keep the current implementation as it covers all options.
Thanks,
Sasha
[toc] | [prev] | [next] | [standalone]
| From | "Neftin, Sasha" <sasha.neftin@intel.com> |
|---|---|
| Date | 2017-02-26 10:20 +0100 |
| Subject | Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller |
| Message-ID | <tf39L-4GN-3@gated-at.bofh.it> |
| In reply to | #1584127 |
On 2/19/2017 14:55, Neftin, Sasha wrote:
> On 2/16/2017 20:42, Bernd Faust wrote:
>> After an upgrade to Linux kernel v4.x the hardware timestamps of the
>> 82579 Gigabit Ethernet Controller are different than expected.
>> The values that are being read are almost four times as big as before
>> the kernel upgrade.
>>
>> The difference is that after the upgrade the driver sets the clock
>> frequency to 25MHz, where before the upgrade it was set to 96MHz. Intel
>> confirmed that the correct frequency for this network adapter is 96MHz.
>>
>> Signed-off-by: Bernd Faust <berndfaust@gmail.com>
>> ---
>> drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
>> b/drivers/net/ethernet/intel/e1000e/netdev.c
>> index 7017281..8b7113d 100644
>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>> @@ -3511,6 +3511,12 @@ s32 e1000e_get_base_timinca(struct
>> e1000_adapter *adapter, u32 *timinca)
>>
>> switch (hw->mac.type) {
>> case e1000_pch2lan:
>> + /* Stable 96MHz frequency */
>> + incperiod = INCPERIOD_96MHz;
>> + incvalue = INCVALUE_96MHz;
>> + shift = INCVALUE_SHIFT_96MHz;
>> + adapter->cc.shift = shift + INCPERIOD_SHIFT_96MHz;
>> + break;
>> case e1000_pch_lpt:
>> if (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) {
>> /* Stable 96MHz frequency */
>> --
>> 2.7.4
>> _______________________________________________
>> Intel-wired-lan mailing list
>> Intel-wired-lan@lists.osuosl.org
>> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>
> Hello,
>
> e1000_pch2lan mac type corresponds to 82579LM and 82579V network
> adapters. System clock frequency indication (SYSCFI) for these devices
> supports both 25MHz and 96MHz frequency. By default TSYNCRXCTL.SYSCFI
> is set to 1 and that means 96MHz frequency is picked.
>
> It is better to keep the current implementation as it covers all options.
>
> Thanks,
>
> Sasha
>
Hello,
During last couple of weeks I saw few complaints from community on same
timing problem with 82579. I will double check clock definition with HW
architecture.
Sasha
[toc] | [prev] | [next] | [standalone]
| From | "Neftin, Sasha" <sasha.neftin@intel.com> |
|---|---|
| Date | 2017-02-27 09:30 +0100 |
| Subject | Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller |
| Message-ID | <tfoQW-2Vd-5@gated-at.bofh.it> |
| In reply to | #1588306 |
On 2/26/2017 11:08, Neftin, Sasha wrote:
> On 2/19/2017 14:55, Neftin, Sasha wrote:
>> On 2/16/2017 20:42, Bernd Faust wrote:
>>> After an upgrade to Linux kernel v4.x the hardware timestamps of the
>>> 82579 Gigabit Ethernet Controller are different than expected.
>>> The values that are being read are almost four times as big as before
>>> the kernel upgrade.
>>>
>>> The difference is that after the upgrade the driver sets the clock
>>> frequency to 25MHz, where before the upgrade it was set to 96MHz. Intel
>>> confirmed that the correct frequency for this network adapter is 96MHz.
>>>
>>> Signed-off-by: Bernd Faust <berndfaust@gmail.com>
>>> ---
>>> drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
>>> b/drivers/net/ethernet/intel/e1000e/netdev.c
>>> index 7017281..8b7113d 100644
>>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>>> @@ -3511,6 +3511,12 @@ s32 e1000e_get_base_timinca(struct
>>> e1000_adapter *adapter, u32 *timinca)
>>>
>>> switch (hw->mac.type) {
>>> case e1000_pch2lan:
>>> + /* Stable 96MHz frequency */
>>> + incperiod = INCPERIOD_96MHz;
>>> + incvalue = INCVALUE_96MHz;
>>> + shift = INCVALUE_SHIFT_96MHz;
>>> + adapter->cc.shift = shift + INCPERIOD_SHIFT_96MHz;
>>> + break;
>>> case e1000_pch_lpt:
>>> if (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) {
>>> /* Stable 96MHz frequency */
>>> --
>>> 2.7.4
>>> _______________________________________________
>>> Intel-wired-lan mailing list
>>> Intel-wired-lan@lists.osuosl.org
>>> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>>
>> Hello,
>>
>> e1000_pch2lan mac type corresponds to 82579LM and 82579V network
>> adapters. System clock frequency indication (SYSCFI) for these
>> devices supports both 25MHz and 96MHz frequency. By default
>> TSYNCRXCTL.SYSCFI is set to 1 and that means 96MHz frequency is picked.
>>
>> It is better to keep the current implementation as it covers all
>> options.
>>
>> Thanks,
>>
>> Sasha
>>
> Hello,
>
> During last couple of weeks I saw few complaints from community on
> same timing problem with 82579. I will double check clock definition
> with HW architecture.
>
> Sasha
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@lists.osuosl.org
> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
I've double checked - 82579 support 96MHz frequency only. So, let's
accept this suggestion to upstream.
Ack.
[toc] | [prev] | [next] | [standalone]
| From | "Neftin, Sasha" <sasha.neftin@intel.com> |
|---|---|
| Date | 2017-02-27 09:50 +0100 |
| Subject | Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller |
| Message-ID | <tfpah-33r-7@gated-at.bofh.it> |
| In reply to | #1588306 |
On 2/26/2017 11:08, Neftin, Sasha wrote:
> On 2/19/2017 14:55, Neftin, Sasha wrote:
>> On 2/16/2017 20:42, Bernd Faust wrote:
>>> After an upgrade to Linux kernel v4.x the hardware timestamps of the
>>> 82579 Gigabit Ethernet Controller are different than expected.
>>> The values that are being read are almost four times as big as before
>>> the kernel upgrade.
>>>
>>> The difference is that after the upgrade the driver sets the clock
>>> frequency to 25MHz, where before the upgrade it was set to 96MHz. Intel
>>> confirmed that the correct frequency for this network adapter is 96MHz.
>>>
>>> Signed-off-by: Bernd Faust <berndfaust@gmail.com>
>>> ---
>>> drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
>>> b/drivers/net/ethernet/intel/e1000e/netdev.c
>>> index 7017281..8b7113d 100644
>>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
>>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
>>> @@ -3511,6 +3511,12 @@ s32 e1000e_get_base_timinca(struct
>>> e1000_adapter *adapter, u32 *timinca)
>>>
>>> switch (hw->mac.type) {
>>> case e1000_pch2lan:
>>> + /* Stable 96MHz frequency */
>>> + incperiod = INCPERIOD_96MHz;
>>> + incvalue = INCVALUE_96MHz;
>>> + shift = INCVALUE_SHIFT_96MHz;
>>> + adapter->cc.shift = shift + INCPERIOD_SHIFT_96MHz;
>>> + break;
>>> case e1000_pch_lpt:
>>> if (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) {
>>> /* Stable 96MHz frequency */
>>> --
>>> 2.7.4
>>> _______________________________________________
>>> Intel-wired-lan mailing list
>>> Intel-wired-lan@lists.osuosl.org
>>> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>>
>> Hello,
>>
>> e1000_pch2lan mac type corresponds to 82579LM and 82579V network
>> adapters. System clock frequency indication (SYSCFI) for these
>> devices supports both 25MHz and 96MHz frequency. By default
>> TSYNCRXCTL.SYSCFI is set to 1 and that means 96MHz frequency is picked.
>>
>> It is better to keep the current implementation as it covers all
>> options.
>>
>> Thanks,
>>
>> Sasha
>>
> Hello,
>
> During last couple of weeks I saw few complaints from community on
> same timing problem with 82579. I will double check clock definition
> with HW architecture.
>
> Sasha
>
I've double checked - 82579 support 96MHz frequency only. So, let's
accept this suggestion to upstream.
Ack.
[toc] | [prev] | [next] | [standalone]
| From | "Keller, Jacob E" <jacob.e.keller@intel.com> |
|---|---|
| Date | 2017-02-28 22:20 +0100 |
| Subject | RE: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller |
| Message-ID | <tfXlE-1rB-23@gated-at.bofh.it> |
| In reply to | #1588549 |
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
> Behalf Of Neftin, Sasha
> Sent: Monday, February 27, 2017 12:40 AM
> To: Bernd Faust <berndfaust@gmail.com>; Kirsher, Jeffrey T
> <jeffrey.t.kirsher@intel.com>; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit
> Ethernet controller
>
> On 2/26/2017 11:08, Neftin, Sasha wrote:
> > On 2/19/2017 14:55, Neftin, Sasha wrote:
> >> On 2/16/2017 20:42, Bernd Faust wrote:
> >>> After an upgrade to Linux kernel v4.x the hardware timestamps of the
> >>> 82579 Gigabit Ethernet Controller are different than expected.
> >>> The values that are being read are almost four times as big as before
> >>> the kernel upgrade.
> >>>
> >>> The difference is that after the upgrade the driver sets the clock
> >>> frequency to 25MHz, where before the upgrade it was set to 96MHz. Intel
> >>> confirmed that the correct frequency for this network adapter is 96MHz.
> >>>
> >>> Signed-off-by: Bernd Faust <berndfaust@gmail.com>
> >>> ---
> >>> drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
> >>> 1 file changed, 6 insertions(+)
> >>>
> >>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
> >>> b/drivers/net/ethernet/intel/e1000e/netdev.c
> >>> index 7017281..8b7113d 100644
> >>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> >>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> >>> @@ -3511,6 +3511,12 @@ s32 e1000e_get_base_timinca(struct
> >>> e1000_adapter *adapter, u32 *timinca)
> >>>
> >>> switch (hw->mac.type) {
> >>> case e1000_pch2lan:
> >>> + /* Stable 96MHz frequency */
> >>> + incperiod = INCPERIOD_96MHz;
> >>> + incvalue = INCVALUE_96MHz;
> >>> + shift = INCVALUE_SHIFT_96MHz;
> >>> + adapter->cc.shift = shift + INCPERIOD_SHIFT_96MHz;
> >>> + break;
> >>> case e1000_pch_lpt:
> >>> if (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) {
> >>> /* Stable 96MHz frequency */
> >>> --
> >>> 2.7.4
> >>> _______________________________________________
> >>> Intel-wired-lan mailing list
> >>> Intel-wired-lan@lists.osuosl.org
> >>> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
> >>
> >> Hello,
> >>
> >> e1000_pch2lan mac type corresponds to 82579LM and 82579V network
> >> adapters. System clock frequency indication (SYSCFI) for these
> >> devices supports both 25MHz and 96MHz frequency. By default
> >> TSYNCRXCTL.SYSCFI is set to 1 and that means 96MHz frequency is picked.
> >>
> >> It is better to keep the current implementation as it covers all
> >> options.
> >>
> >> Thanks,
> >>
> >> Sasha
> >>
> > Hello,
> >
> > During last couple of weeks I saw few complaints from community on
> > same timing problem with 82579. I will double check clock definition
> > with HW architecture.
> >
> > Sasha
> >
> I've double checked - 82579 support 96MHz frequency only. So, let's
> accept this suggestion to upstream.
>
> Ack.
>
This resolves also a complaint from someone on the LinuxPTP development mailing list.
ACK.
Thanks,
Jake
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web