Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1588295 > unrolled thread
| Started by | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| First post | 2017-02-26 09:00 +0100 |
| Last post | 2017-02-26 09:00 +0100 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi <cpsethi369@gmail.com> - 2017-02-26 09:00 +0100
[PATCH v4 4/6] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi <cpsethi369@gmail.com> - 2017-02-26 09:00 +0100
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-26 09:00 +0100 |
| Subject | [PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters |
| Message-ID | <tf1hD-3ql-3@gated-at.bofh.it> |
This patch fixes warning of line over 80 characters, as issued by checkpatch.pl Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog drivers/staging/ks7010/ks_wlan.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 9ab80e1..668202d 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -18,10 +18,10 @@ #include <linux/kernel.h> #include <linux/module.h> -#include <linux/spinlock.h> /* spinlock_t */ -#include <linux/sched.h> /* wait_queue_head_t */ -#include <linux/types.h> /* pid_t */ -#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ +#include <linux/spinlock.h> /* spinlock_t */ +#include <linux/sched.h> /* wait_queue_head_t */ +#include <linux/types.h> /* pid_t */ +#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ #include <linux/etherdevice.h> #include <linux/wireless.h> #include <linux/atomic.h> /* struct atomic_t */ @@ -36,7 +36,8 @@ #ifdef KS_WLAN_DEBUG #define DPRINTK(n, fmt, args...) \ - if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) + if (KS_WLAN_DEBUG > (n)) \ + printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) #else #define DPRINTK(n, fmt, args...) #endif -- 2.7.4
[toc] | [next] | [standalone]
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-26 09:00 +0100 |
| Subject | [PATCH v4 4/6] staging: ks7010: fix coding style issue of using pr_notice instead of printk |
| Message-ID | <tf1Um-3Gs-7@gated-at.bofh.it> |
| In reply to | #1588295 |
This patch fixes coding style issue of using pr_notice instead of printk,
warning as issued by checkpatch.pl
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
- updated subject to include driver name
drivers/staging/ks7010/ks_wlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 94b648b..78beca7 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -38,7 +38,7 @@
#define DPRINTK(n, fmt, args...) \
do { \
if (KS_WLAN_DEBUG > (n)) \
- printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+ pr_notice("%s: "fmt, __FUNCTION__, ## args); \
} while (0)
#else
#define DPRINTK(n, fmt, args...)
--
2.7.4
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web