Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1588011 > unrolled thread
| Started by | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| First post | 2017-02-25 01:00 +0100 |
| Last post | 2017-02-25 07:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v2] staging: xgifb: correct the multiple line dereference Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-25 01:00 +0100
Re: [PATCH v2] staging: xgifb: correct the multiple line dereference Joe Perches <joe@perches.com> - 2017-02-25 04:10 +0100
Re: [Outreachy kernel] [PATCH v2] staging: xgifb: correct the multiple line dereference Julia Lawall <julia.lawall@lip6.fr> - 2017-02-25 07:40 +0100
| From | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| Date | 2017-02-25 01:00 +0100 |
| Subject | [PATCH v2] staging: xgifb: correct the multiple line dereference |
| Message-ID | <texWi-7Hd-5@gated-at.bofh.it> |
Error was reported by checkpatch.pl as
WARNING: Avoid multiple line dereference...
And If there is boolean operator then it is fixed by Splitting line at
boolean operator.This is a coding style error.
The changes are made such that the other errors does not generate
beacause of this change like line exceeding 80 characters length.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
- changes done such that no other errors can generate.
---
drivers/staging/xgifb/XGI_main_26.c | 21 +++++++++------------
drivers/staging/xgifb/vb_setmode.c | 14 +++++++-------
2 files changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index 6930f7eb741b..651987398d42 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -878,30 +878,27 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
}
if ((filter >= 0) && (filter <= 7)) {
+ const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
+
pr_debug("FilterTable[%d]-%d: %*ph\n",
filter_tb, filter,
- 4, XGI_TV_filter[filter_tb].
- filter[filter]);
+ 4, f);
xgifb_reg_set(
XGIPART2,
0x35,
- (XGI_TV_filter[filter_tb].
- filter[filter][0]));
- xgifb_reg_set(
+ (f[0]));
+ xgifb_reg_set(
XGIPART2,
0x36,
- (XGI_TV_filter[filter_tb].
- filter[filter][1]));
- xgifb_reg_set(
+ (f[1]));
+ xgifb_reg_set(
XGIPART2,
0x37,
- (XGI_TV_filter[filter_tb].
- filter[filter][2]));
+ (f[2]));
xgifb_reg_set(
XGIPART2,
0x38,
- (XGI_TV_filter[filter_tb].
- filter[filter][3]));
+ (f[3]));
}
}
}
diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
index 7c7c8c8f1df3..1220d0cea87d 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drivers/staging/xgifb/vb_setmode.c
@@ -221,8 +221,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
tempbx; (*i)--) {
- infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
- Ext_InfoFlag;
+ infoflag =
+ XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
if (infoflag & tempax)
return 1;
@@ -231,8 +231,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
}
for ((*i) = 0;; (*i)++) {
- infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
- Ext_InfoFlag;
+ infoflag =
+ XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
!= tempbx) {
return 0;
@@ -5092,8 +5092,8 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
i = 0;
do {
- if (XGI330_RefIndex[RefreshRateTableIndex + i].
- ModeID != ModeNo)
+ if (XGI330_RefIndex[RefreshRateTableIndex + i].ModeID
+ != ModeNo)
break;
temp = XGI330_RefIndex[RefreshRateTableIndex + i].Ext_InfoFlag;
temp &= ModeTypeMask;
@@ -5484,7 +5484,7 @@ unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
return 0;
pVBInfo->ModeType = XGI330_EModeIDTable[ModeIdIndex].
- Ext_ModeFlag & ModeTypeMask;
+ Ext_ModeFlag & ModeTypeMask;
pVBInfo->SetFlag = 0;
pVBInfo->VBInfo = DisableCRT2Display;
--
2.11.0
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-25 04:10 +0100 |
| Message-ID | <teAU9-1sH-3@gated-at.bofh.it> |
| In reply to | #1588011 |
On Sat, 2017-02-25 at 05:11 +0530, Arushi Singhal wrote:
> Error was reported by checkpatch.pl as
> WARNING: Avoid multiple line dereference...
> And If there is boolean operator then it is fixed by Splitting line at
> boolean operator.This is a coding style error.
> The changes are made such that the other errors does not generate
> beacause of this change like line exceeding 80 characters length.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> changes in v2
> - changes done such that no other errors can generate.
> ---
> drivers/staging/xgifb/XGI_main_26.c | 21 +++++++++------------
> drivers/staging/xgifb/vb_setmode.c | 14 +++++++-------
> 2 files changed, 16 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 6930f7eb741b..651987398d42 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -878,30 +878,27 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
> }
>
> if ((filter >= 0) && (filter <= 7)) {
> + const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
> +
> pr_debug("FilterTable[%d]-%d: %*ph\n",
> filter_tb, filter,
> - 4, XGI_TV_filter[filter_tb].
> - filter[filter]);
> + 4, f);
Do please rewrap these appropriately. i.e.:
pr_debug(""FilterTable[%d]-%d: %*ph\n",
filter_tb, filter, 4, f);
> xgifb_reg_set(
> XGIPART2,
> 0x35,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][0]));
> - xgifb_reg_set(
> + (f[0]));
and:
xgifb_reg_set(XGIPART2, 0x35, f[0]);
> + xgifb_reg_set(
> XGIPART2,
> 0x36,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][1]));
> - xgifb_reg_set(
> + (f[1]));
xgifb_reg_set(XGIPART2, 0x36, f[1]);
etc...
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-02-25 07:40 +0100 |
| Subject | Re: [Outreachy kernel] [PATCH v2] staging: xgifb: correct the multiple line dereference |
| Message-ID | <teEbn-3P4-3@gated-at.bofh.it> |
| In reply to | #1588011 |
On Sat, 25 Feb 2017, Arushi Singhal wrote:
> Error was reported by checkpatch.pl as
> WARNING: Avoid multiple line dereference...
> And If there is boolean operator then it is fixed by Splitting line at
> boolean operator.This is a coding style error.
There is strange spacing and capitalization in the above two lines. Only
the first word in a sentence should be capitalized. There should be at
least one space after a period.
> The changes are made such that the other errors does not generate
> beacause of this change like line exceeding 80 characters length.
This doesn't say anything about what you did.
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> changes in v2
> - changes done such that no other errors can generate.
> ---
You don't need --- here. Only the one just below the Signed off by.
julia
> drivers/staging/xgifb/XGI_main_26.c | 21 +++++++++------------
> drivers/staging/xgifb/vb_setmode.c | 14 +++++++-------
> 2 files changed, 16 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
> index 6930f7eb741b..651987398d42 100644
> --- a/drivers/staging/xgifb/XGI_main_26.c
> +++ b/drivers/staging/xgifb/XGI_main_26.c
> @@ -878,30 +878,27 @@ static void XGIfb_post_setmode(struct xgifb_video_info *xgifb_info)
> }
>
> if ((filter >= 0) && (filter <= 7)) {
> + const u8 *f = XGI_TV_filter[filter_tb].filter[filter];
> +
> pr_debug("FilterTable[%d]-%d: %*ph\n",
> filter_tb, filter,
> - 4, XGI_TV_filter[filter_tb].
> - filter[filter]);
> + 4, f);
> xgifb_reg_set(
> XGIPART2,
> 0x35,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][0]));
> - xgifb_reg_set(
> + (f[0]));
> + xgifb_reg_set(
> XGIPART2,
> 0x36,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][1]));
> - xgifb_reg_set(
> + (f[1]));
> + xgifb_reg_set(
> XGIPART2,
> 0x37,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][2]));
> + (f[2]));
> xgifb_reg_set(
> XGIPART2,
> 0x38,
> - (XGI_TV_filter[filter_tb].
> - filter[filter][3]));
> + (f[3]));
> }
> }
> }
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 7c7c8c8f1df3..1220d0cea87d 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -221,8 +221,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
>
> for (; XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID ==
> tempbx; (*i)--) {
> - infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
> - Ext_InfoFlag;
> + infoflag =
> + XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
> if (infoflag & tempax)
> return 1;
>
> @@ -231,8 +231,8 @@ static unsigned char XGI_AjustCRT2Rate(unsigned short ModeIdIndex,
> }
>
> for ((*i) = 0;; (*i)++) {
> - infoflag = XGI330_RefIndex[RefreshRateTableIndex + (*i)].
> - Ext_InfoFlag;
> + infoflag =
> + XGI330_RefIndex[RefreshRateTableIndex + (*i)].Ext_InfoFlag;
> if (XGI330_RefIndex[RefreshRateTableIndex + (*i)].ModeID
> != tempbx) {
> return 0;
> @@ -5092,8 +5092,8 @@ unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
>
> i = 0;
> do {
> - if (XGI330_RefIndex[RefreshRateTableIndex + i].
> - ModeID != ModeNo)
> + if (XGI330_RefIndex[RefreshRateTableIndex + i].ModeID
> + != ModeNo)
> break;
> temp = XGI330_RefIndex[RefreshRateTableIndex + i].Ext_InfoFlag;
> temp &= ModeTypeMask;
> @@ -5484,7 +5484,7 @@ unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
> return 0;
>
> pVBInfo->ModeType = XGI330_EModeIDTable[ModeIdIndex].
> - Ext_ModeFlag & ModeTypeMask;
> + Ext_ModeFlag & ModeTypeMask;
>
> pVBInfo->SetFlag = 0;
> pVBInfo->VBInfo = DisableCRT2Display;
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170224234130.GA608%40arushi-HP-Pavilion-Notebook.
> For more options, visit https://groups.google.com/d/optout.
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web