Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1587953 > unrolled thread
| Started by | Shaohua Li <shli@fb.com> |
|---|---|
| First post | 2017-02-24 22:40 +0100 |
| Last post | 2017-02-28 06:10 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH V5 5/6] mm: enable MADV_FREE for swapless system Shaohua Li <shli@fb.com> - 2017-02-24 22:40 +0100
Re: [PATCH V5 5/6] mm: enable MADV_FREE for swapless system Michal Hocko <mhocko@kernel.org> - 2017-02-27 16:30 +0100
Re: [PATCH V5 5/6] mm: enable MADV_FREE for swapless system "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2017-02-28 04:30 +0100
Re: [PATCH V5 5/6] mm: enable MADV_FREE for swapless system Minchan Kim <minchan@kernel.org> - 2017-02-28 06:10 +0100
| From | Shaohua Li <shli@fb.com> |
|---|---|
| Date | 2017-02-24 22:40 +0100 |
| Subject | [PATCH V5 5/6] mm: enable MADV_FREE for swapless system |
| Message-ID | <tevKO-693-23@gated-at.bofh.it> |
Now MADV_FREE pages can be easily reclaimed even for swapless system. We can safely enable MADV_FREE for all systems. Cc: Michal Hocko <mhocko@suse.com> Cc: Minchan Kim <minchan@kernel.org> Cc: Hugh Dickins <hughd@google.com> Cc: Rik van Riel <riel@redhat.com> Cc: Mel Gorman <mgorman@techsingularity.net> Cc: Andrew Morton <akpm@linux-foundation.org> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Signed-off-by: Shaohua Li <shli@fb.com> --- mm/madvise.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 225af7d..5ab4b7b 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -612,13 +612,7 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev, case MADV_WILLNEED: return madvise_willneed(vma, prev, start, end); case MADV_FREE: - /* - * XXX: In this implementation, MADV_FREE works like - * MADV_DONTNEED on swapless system or full swap. - */ - if (get_nr_swap_pages() > 0) - return madvise_free(vma, prev, start, end); - /* passthrough */ + return madvise_free(vma, prev, start, end); case MADV_DONTNEED: return madvise_dontneed(vma, prev, start, end); default: -- 2.9.3
[toc] | [next] | [standalone]
| From | Michal Hocko <mhocko@kernel.org> |
|---|---|
| Date | 2017-02-27 16:30 +0100 |
| Message-ID | <tfvpo-7rK-17@gated-at.bofh.it> |
| In reply to | #1587953 |
On Fri 24-02-17 13:31:48, Shaohua Li wrote: > Now MADV_FREE pages can be easily reclaimed even for swapless system. We > can safely enable MADV_FREE for all systems. > > Cc: Michal Hocko <mhocko@suse.com> > Cc: Minchan Kim <minchan@kernel.org> > Cc: Hugh Dickins <hughd@google.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Andrew Morton <akpm@linux-foundation.org> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Signed-off-by: Shaohua Li <shli@fb.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > mm/madvise.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 225af7d..5ab4b7b 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -612,13 +612,7 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev, > case MADV_WILLNEED: > return madvise_willneed(vma, prev, start, end); > case MADV_FREE: > - /* > - * XXX: In this implementation, MADV_FREE works like > - * MADV_DONTNEED on swapless system or full swap. > - */ > - if (get_nr_swap_pages() > 0) > - return madvise_free(vma, prev, start, end); > - /* passthrough */ > + return madvise_free(vma, prev, start, end); > case MADV_DONTNEED: > return madvise_dontneed(vma, prev, start, end); > default: > -- > 2.9.3 > -- Michal Hocko SUSE Labs
[toc] | [prev] | [next] | [standalone]
| From | "Hillf Danton" <hillf.zj@alibaba-inc.com> |
|---|---|
| Date | 2017-02-28 04:30 +0100 |
| Message-ID | <tfGEa-6YX-15@gated-at.bofh.it> |
| In reply to | #1587953 |
On February 25, 2017 5:32 AM Shaohua Li wrote: > > Now MADV_FREE pages can be easily reclaimed even for swapless system. We > can safely enable MADV_FREE for all systems. > > Cc: Michal Hocko <mhocko@suse.com> > Cc: Minchan Kim <minchan@kernel.org> > Cc: Hugh Dickins <hughd@google.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Andrew Morton <akpm@linux-foundation.org> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Signed-off-by: Shaohua Li <shli@fb.com> > --- Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
[toc] | [prev] | [next] | [standalone]
| From | Minchan Kim <minchan@kernel.org> |
|---|---|
| Date | 2017-02-28 06:10 +0100 |
| Message-ID | <tfIcV-89F-1@gated-at.bofh.it> |
| In reply to | #1587953 |
On Fri, Feb 24, 2017 at 01:31:48PM -0800, Shaohua Li wrote: > Now MADV_FREE pages can be easily reclaimed even for swapless system. We > can safely enable MADV_FREE for all systems. > > Cc: Michal Hocko <mhocko@suse.com> > Cc: Minchan Kim <minchan@kernel.org> > Cc: Hugh Dickins <hughd@google.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Andrew Morton <akpm@linux-foundation.org> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Signed-off-by: Shaohua Li <shli@fb.com> Acked-by: Minchan Kim <minchan@kernel.org>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web