Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1587855 > unrolled thread

[PATCH -next] input/touchscreen: add header file to fix ad7879.c build errors

Back to article view | Back to linux.kernel

Contents

  [PATCH -next] input/touchscreen: add header file to fix ad7879.c  build errors Randy Dunlap <rdunlap@infradead.org> - 2017-02-24 19:40 +0100
    Re: [PATCH -next] input/touchscreen: add header file to fix ad7879.c  build errors Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-25 20:00 +0100

#1587855 — [PATCH -next] input/touchscreen: add header file to fix ad7879.c build errors

From: Randy Dunlap <rdunlap@infradead.org>

Add header file to fix these build errors:

../drivers/input/touchscreen/ad7879.c: In function 'ad7879_parse_dt':
../drivers/input/touchscreen/ad7879.c:505:2: error: implicit declaration of function 'device_property_read_u32' [-Werror=implicit-function-declaration]
  err = device_property_read_u32(dev, "adi,resistance-plate-x", &tmp);
  ^
../drivers/input/touchscreen/ad7879.c:512:2: error: implicit declaration of function 'device_property_read_u8' [-Werror=implicit-function-declaration]
  device_property_read_u8(dev, "adi,first-conversion-delay",
  ^
../drivers/input/touchscreen/ad7879.c:521:2: error: implicit declaration of function 'device_property_read_bool' [-Werror=implicit-function-declaration]
  ts->swap_xy = device_property_read_bool(dev, "touchscreen-swapped-x-y");
  ^

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc:	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:	linux-input@vger.kernel.org
Cc:	Michael Hennerich <michael.hennerich@analog.com>
---
 drivers/input/touchscreen/ad7879.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20170224.orig/drivers/input/touchscreen/ad7879.c
+++ linux-next-20170224/drivers/input/touchscreen/ad7879.c
@@ -26,6 +26,7 @@
 #include <linux/input.h>
 #include <linux/interrupt.h>
 #include <linux/irq.h>
+#include <linux/property.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
 #include <linux/gpio.h>

[toc] | [next] | [standalone]

#1588196

On Fri, Feb 24, 2017 at 10:30:22AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Add header file to fix these build errors:
> 
> ../drivers/input/touchscreen/ad7879.c: In function 'ad7879_parse_dt':
> ../drivers/input/touchscreen/ad7879.c:505:2: error: implicit declaration of function 'device_property_read_u32' [-Werror=implicit-function-declaration]
>   err = device_property_read_u32(dev, "adi,resistance-plate-x", &tmp);
>   ^
> ../drivers/input/touchscreen/ad7879.c:512:2: error: implicit declaration of function 'device_property_read_u8' [-Werror=implicit-function-declaration]
>   device_property_read_u8(dev, "adi,first-conversion-delay",
>   ^
> ../drivers/input/touchscreen/ad7879.c:521:2: error: implicit declaration of function 'device_property_read_bool' [-Werror=implicit-function-declaration]
>   ts->swap_xy = device_property_read_bool(dev, "touchscreen-swapped-x-y");
>   ^
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied, thank you.

> Cc:	Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc:	linux-input@vger.kernel.org
> Cc:	Michael Hennerich <michael.hennerich@analog.com>
> ---
>  drivers/input/touchscreen/ad7879.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20170224.orig/drivers/input/touchscreen/ad7879.c
> +++ linux-next-20170224/drivers/input/touchscreen/ad7879.c
> @@ -26,6 +26,7 @@
>  #include <linux/input.h>
>  #include <linux/interrupt.h>
>  #include <linux/irq.h>
> +#include <linux/property.h>
>  #include <linux/regmap.h>
>  #include <linux/slab.h>
>  #include <linux/gpio.h>

-- 
Dmitry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web