Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584781 > unrolled thread

[PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses simran singhal <singhalsimran0@gmail.com> - 2017-02-20 18:20 +0100
    Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 18:20 +0100
      Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses SIMRAN SINGHAL <singhalsimran0@gmail.com> - 2017-02-24 23:50 +0100
        Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary  parentheses Joe Perches <joe@perches.com> - 2017-02-25 04:00 +0100
        Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses Greg KH <gregkh@linuxfoundation.org> - 2017-02-25 09:00 +0100

#1584781 — [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses

Extra parentheses were causing checkpatch issues
and were removed.

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 
 v2:
   -Removed parentheses around argument of cast
   -Removed cast
 
 drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index cded0f4..0a9234e 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -297,7 +297,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,
 		u8	EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33};
 
 		memcpy(posHTCap, EWC11NHTCap, sizeof(EWC11NHTCap));
-		pCapELE = (struct ht_capab_ele *)&(posHTCap[4]);
+		pCapELE = (struct ht_capab_ele *)&posHTCap[4];
 		*len = 30 + 2;
 	} else {
 		pCapELE = (struct ht_capab_ele *)posHTCap;
@@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
 	pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
 	pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
 
-	memset((void *)(&(pHTInfo->SelfHTCap)), 0,
+	memset(&pHTInfo->SelfHTCap, 0,
 		sizeof(pHTInfo->SelfHTCap));
-	memset((void *)(&(pHTInfo->SelfHTInfo)), 0,
+	memset(&pHTInfo->SelfHTInfo, 0,
 		sizeof(pHTInfo->SelfHTInfo));
-	memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0,
+	memset(&pHTInfo->PeerHTCapBuf, 0,
 		sizeof(pHTInfo->PeerHTCapBuf));
-	memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0,
+	memset(&pHTInfo->PeerHTInfoBuf, 0,
 		sizeof(pHTInfo->PeerHTInfoBuf));
 
 	pHTInfo->bSwBwInProgress = false;
@@ -685,7 +685,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
 	pHTInfo->IOTRaFunc = 0;
 
 	{
-		u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0]);
+		u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0];
 
 		RegHTSuppRateSets[0] = 0xFF;
 		RegHTSuppRateSets[1] = 0xFF;
-- 
2.7.4

[toc] | [next] | [standalone]

#1587817

On Mon, Feb 20, 2017 at 10:41:47PM +0530, simran singhal wrote:
> Extra parentheses were causing checkpatch issues
> and were removed.
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  
>  v2:
>    -Removed parentheses around argument of cast
>    -Removed cast

I can't keep track of random patches in the middle of a series that is
updated.

Please fix up and resend the whole series, as a series, that are linked
together in an email client, not as independent emails (i.e. use
git-send-email properly).

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1587990

On Fri, Feb 24, 2017 at 10:47 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Feb 20, 2017 at 10:41:47PM +0530, simran singhal wrote:
>> Extra parentheses were causing checkpatch issues
>> and were removed.
>>
>> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
>> ---
>>
>>  v2:
>>    -Removed parentheses around argument of cast
>>    -Removed cast
>
> I can't keep track of random patches in the middle of a series that is
> updated.
>
> Please fix up and resend the whole series, as a series, that are linked
> together in an email client, not as independent emails (i.e. use
> git-send-email properly).

 I am using mutt for sending patches. In mutt I have to send each patch
 of a particular patch series one by one. So, they come as independent
 emails.

 And, they all get mix because of the reason, if I started sending new patch
 series and at the same time sending new versions of patches of previous
 patch series, so because of which their order changes.

 So, please suggest me some better way, considering I am using mutt.

 Thanks,
 Simran SInghal

>
> thanks,
>
> greg k-h

[toc] | [prev] | [next] | [standalone]

#1588044 — Re: [PATCH v2 6/6] staging: rtl8192e: Removed unnecessary parentheses

On Sat, 2017-02-25 at 04:18 +0530, SIMRAN SINGHAL wrote:
> On Fri, Feb 24, 2017 at 10:47 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Feb 20, 2017 at 10:41:47PM +0530, simran singhal wrote:
> > > Extra parentheses were causing checkpatch issues
> > > and were removed.
> > > 
> > > Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> > > ---
> > > 
> > >  v2:
> > >    -Removed parentheses around argument of cast
> > >    -Removed cast
> > 
> > I can't keep track of random patches in the middle of a series that is
> > updated.
> > 
> > Please fix up and resend the whole series, as a series, that are linked
> > together in an email client, not as independent emails (i.e. use
> > git-send-email properly).
> 
>  I am using mutt for sending patches. In mutt I have to send each patch
>  of a particular patch series one by one. So, they come as independent
>  emails.
> 
>  And, they all get mix because of the reason, if I started sending new patch
>  series and at the same time sending new versions of patches of previous
>  patch series, so because of which their order changes.
> 
>  So, please suggest me some better way, considering I am using mutt.

git send-email

[toc] | [prev] | [next] | [standalone]

#1588084

On Sat, Feb 25, 2017 at 04:18:27AM +0530, SIMRAN SINGHAL wrote:
> On Fri, Feb 24, 2017 at 10:47 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Mon, Feb 20, 2017 at 10:41:47PM +0530, simran singhal wrote:
> >> Extra parentheses were causing checkpatch issues
> >> and were removed.
> >>
> >> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> >> ---
> >>
> >>  v2:
> >>    -Removed parentheses around argument of cast
> >>    -Removed cast
> >
> > I can't keep track of random patches in the middle of a series that is
> > updated.
> >
> > Please fix up and resend the whole series, as a series, that are linked
> > together in an email client, not as independent emails (i.e. use
> > git-send-email properly).
> 
>  I am using mutt for sending patches. In mutt I have to send each patch
>  of a particular patch series one by one. So, they come as independent
>  emails.
> 
>  And, they all get mix because of the reason, if I started sending new patch
>  series and at the same time sending new versions of patches of previous
>  patch series, so because of which their order changes.

Please do not do that.  Would you like to receive patches out of order,
not threaded, and all mixed up in the middle of hundreds of other
patches?  How would you be able to figure it out?  Please consider that
someone has to read what you send out :)

>  So, please suggest me some better way, considering I am using mutt.

You can use mutt for that, but you need to know what you are doing and
how to thread emails with it.  It's not simple, so please just use git
send-email for now until you learn mutt better.

good luck!

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web