Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1582860 > unrolled thread

[PATCH] staging: fsl-mc: fix coding style warning

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: fsl-mc: fix coding style warning Lucian Zala <zala.lucian@gmail.com> - 2017-02-16 19:50 +0100
    Re: [PATCH] staging: fsl-mc: fix coding style warning Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 17:40 +0100
      Re: [PATCH] staging: fsl-mc: fix coding style warning Lucian Zala <zala.lucian@gmail.com> - 2017-02-24 19:30 +0100
        Re: [PATCH] staging: fsl-mc: fix coding style warning Greg KH <gregkh@linuxfoundation.org> - 2017-02-25 09:00 +0100

#1582860 — [PATCH] staging: fsl-mc: fix coding style warning

Fix for "WARNING: Avoid multiple line dereference - prefer
'mc_msi_domain->host_data'" found by checkpatch.pl in
bus/irq-gic-v3-its-fsl-mc-msi.c.

Signed-off-by: Lucian Zala <zala.lucian@gmail.com>
---
 drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
index 87e4471..49127ac 100644
--- a/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
+++ b/drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c
@@ -95,8 +95,8 @@ int __init its_fsl_mc_msi_init(void)
 			continue;
 		}
 
-		WARN_ON(mc_msi_domain->
-				host_data != &its_fsl_mc_msi_domain_info);
+		WARN_ON(mc_msi_domain->host_data !=
+			&its_fsl_mc_msi_domain_info);
 
 		pr_info("fsl-mc MSI: %s domain created\n", np->full_name);
 	}
-- 
2.7.4

[toc] | [next] | [standalone]

#1587777

On Thu, Feb 16, 2017 at 08:42:47PM +0200, Lucian Zala wrote:
> Fix for "WARNING: Avoid multiple line dereference - prefer
> 'mc_msi_domain->host_data'" found by checkpatch.pl in
> bus/irq-gic-v3-its-fsl-mc-msi.c.
> 
> Signed-off-by: Lucian Zala <zala.lucian@gmail.com>
> ---
>  drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This patch does not apply to my tree at all, sorry :(

greg k-h

[toc] | [prev] | [next] | [standalone]

#1587852

Hi Greg,

I am a little bit confused regarding your reply, it seems
that the patch applied afterall, or?

http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/fsl-mc?h=staging-testing&id=3bee20fffff39e4df8d65e8d34ab9b3ab92e5acc

Have I messed something in it?

BR,
Lucian
On Fri, Feb 24, 2017 at 05:33:55PM +0100, Greg KH wrote:
> On Thu, Feb 16, 2017 at 08:42:47PM +0200, Lucian Zala wrote:
> > Fix for "WARNING: Avoid multiple line dereference - prefer
> > 'mc_msi_domain->host_data'" found by checkpatch.pl in
> > bus/irq-gic-v3-its-fsl-mc-msi.c.
> > 
> > Signed-off-by: Lucian Zala <zala.lucian@gmail.com>
> > ---
> >  drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> This patch does not apply to my tree at all, sorry :(
> 
> greg k-h

[toc] | [prev] | [next] | [standalone]

#1588083

On Fri, Feb 24, 2017 at 08:24:42PM +0200, Lucian Zala wrote:
> Hi Greg,
> 
> I am a little bit confused regarding your reply, it seems
> that the patch applied afterall, or?
> 
> http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/drivers/staging/fsl-mc?h=staging-testing&id=3bee20fffff39e4df8d65e8d34ab9b3ab92e5acc
> 
> Have I messed something in it?

No, my mistake, I must have already applied it, sorry, dealing with
hundreds of patches causes confusion at times :)

sorry for the noise,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web