Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1587492 > unrolled thread

Re: [PATCH v4 1/3] mmc: dt-bindings: update Mediatek MMC bindings

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v4 1/3] mmc: dt-bindings: update Mediatek MMC bindings Yong Mao <yong.mao@mediatek.com> - 2017-02-24 11:10 +0100
    Re: [PATCH v4 1/3] mmc: dt-bindings: update Mediatek MMC bindings Rob Herring <robh@kernel.org> - 2017-02-24 23:50 +0100

#1587492 — Re: [PATCH v4 1/3] mmc: dt-bindings: update Mediatek MMC bindings

Dear Rob,

Could you please help to make comments for this patch?
Thanks.

On Tue, 2017-01-24 at 09:02 +0100, Ulf Hansson wrote:
> +Rob, devicetree
> 
> On 21 January 2017 at 09:55, Yong Mao <yong.mao@mediatek.com> wrote:
> > From: yong mao <yong.mao@mediatek.com>
> >
> > Add description for mediatek,hs200-cmd-int-delay
> > Add description for mediatek,hs400-cmd-int-delay
> > Add description for mediatek,hs400-cmd-resp-sel-rising
> >
> > Signed-off-by: Yong Mao <yong.mao@mediatek.com>
> 
> You need an ack from a DT maintainer for this. I have added Rob and
> the devicetree list on cc.
> 
> Kind regards
> Uffe
> 
> > ---
> >  Documentation/devicetree/bindings/mmc/mtk-sd.txt |   12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> > index 0120c7f..4182ea3 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> > @@ -21,6 +21,15 @@ Optional properties:
> >  - assigned-clocks: PLL of the source clock
> >  - assigned-clock-parents: parent of source clock, used for HS400 mode to get 400Mhz source clock
> >  - hs400-ds-delay: HS400 DS delay setting
> > +- mediatek,hs200-cmd-int-delay: HS200 command internal delay setting.
> > +                               This field has total 32 stages.
> > +                               The value is an integer from 0 to 31.
> > +- mediatek,hs400-cmd-int-delay: HS400 command internal delay setting
> > +                               This field has total 32 stages.
> > +                               The value is an integer from 0 to 31.
> > +- mediatek,hs400-cmd-resp-sel-rising:  HS400 command response sample selection
> > +                                      If present,HS400 command responses are sampled on rising edges.
> > +                                      If not present,HS400 command responses are sampled on falling edges.
> >
> >  Examples:
> >  mmc0: mmc@11230000 {
> > @@ -38,4 +47,7 @@ mmc0: mmc@11230000 {
> >         assigned-clocks = <&topckgen CLK_TOP_MSDC50_0_SEL>;
> >         assigned-clock-parents = <&topckgen CLK_TOP_MSDCPLL_D2>;
> >         hs400-ds-delay = <0x14015>;
> > +       mediatek,hs200-cmd-int-delay = <26>;
> > +       mediatek,hs400-cmd-int-delay = <14>;
> > +       mediatek,hs400-cmd-resp-sel-rising;
> >  };
> > --
> > 1.7.9.5
> >

[toc] | [next] | [standalone]

#1587991

On Fri, Feb 24, 2017 at 3:59 AM, Yong Mao <yong.mao@mediatek.com> wrote:
> Dear Rob,
>
> Could you please help to make comments for this patch?
> Thanks.

I already did comment. It's still wrong as Ulf commented. So fix and
send a new version. It has to go to the DT list if you want to be in
my queue.

Rob

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web