Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586465 > unrolled thread

Re: [GIT PULL] scheduler changes for v4.11

Started byLinus Torvalds <torvalds@linux-foundation.org>
First post2017-02-22 21:50 +0100
Last post2017-02-24 09:00 +0100
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [GIT PULL] scheduler changes for v4.11 Linus Torvalds <torvalds@linux-foundation.org> - 2017-02-22 21:50 +0100
    Re: [GIT PULL] scheduler changes for v4.11 Matt Fleming <matt@codeblueprint.co.uk> - 2017-02-22 22:00 +0100
      Re: [GIT PULL] scheduler changes for v4.11 Peter Zijlstra <peterz@infradead.org> - 2017-02-22 22:20 +0100
        Re: [GIT PULL] scheduler changes for v4.11 Ingo Molnar <mingo@kernel.org> - 2017-02-24 09:00 +0100

#1586465 — Re: [GIT PULL] scheduler changes for v4.11

FromLinus Torvalds <torvalds@linux-foundation.org>
Date2017-02-22 21:50 +0100
SubjectRe: [GIT PULL] scheduler changes for v4.11
Message-ID<tdM1l-7iJ-39@gated-at.bofh.it>
Hmm. The scheduler changes seem to show problems with suspend/resume.

I now get his when suspending:

  ...
  Disabling non-boot CPUs ...
  Cannot set affinity for irq 285
  smpboot: CPU 1 is now offline
  ------------[ cut here ]------------
   WARNING: CPU: 2 PID: 25 at kernel/sched/sched.h:812
update_load_avg+0x779/0xa70
  rq->clock_update_flags < RQCF_ACT_SKIP
  ...
  Call Trace:
    update_load_avg+0x779/0xa70
    set_next_entity+0xd9/0x220
    pick_next_task_fair+0x88/0x550
    sched_cpu_dying+0x1cf/0x2a0
    cpuhp_invoke_callback+0x80/0x3b0
    take_cpu_down+0x5e/0xa0
    multi_cpu_stop+0xb6/0xe0

the issue may have been going on for a while, but the new WARN_ON()
was added in this merge window.

(Not sure how consistent this warning is, it definitely doesn't happen
every time, I've only seen it once)

                  Linus

[toc] | [next] | [standalone]

#1586476

FromMatt Fleming <matt@codeblueprint.co.uk>
Date2017-02-22 22:00 +0100
Message-ID<tdMb0-7mE-27@gated-at.bofh.it>
In reply to#1586465
On Wed, 22 Feb, at 12:41:01PM, Linus Torvalds wrote:
> Hmm. The scheduler changes seem to show problems with suspend/resume.
> 
> I now get his when suspending:
> 
>   ...
>   Disabling non-boot CPUs ...
>   Cannot set affinity for irq 285
>   smpboot: CPU 1 is now offline
>   ------------[ cut here ]------------
>    WARNING: CPU: 2 PID: 25 at kernel/sched/sched.h:812
> update_load_avg+0x779/0xa70
>   rq->clock_update_flags < RQCF_ACT_SKIP
>   ...
>   Call Trace:
>     update_load_avg+0x779/0xa70
>     set_next_entity+0xd9/0x220
>     pick_next_task_fair+0x88/0x550
>     sched_cpu_dying+0x1cf/0x2a0
>     cpuhp_invoke_callback+0x80/0x3b0
>     take_cpu_down+0x5e/0xa0
>     multi_cpu_stop+0xb6/0xe0
> 
> the issue may have been going on for a while, but the new WARN_ON()
> was added in this merge window.
> 
> (Not sure how consistent this warning is, it definitely doesn't happen
> every time, I've only seen it once)

I think Peter has the fix for this somewhere, but it doesn't look like
it made it to tip/sched/core.

Peter, this is the original patch,

  https://lkml.kernel.org/r/20170202155506.GX6515@twins.programming.kicks-ass.net

[toc] | [prev] | [next] | [standalone]

#1586490

FromPeter Zijlstra <peterz@infradead.org>
Date2017-02-22 22:20 +0100
Message-ID<tdMum-7Lo-23@gated-at.bofh.it>
In reply to#1586476
On Wed, Feb 22, 2017 at 08:51:44PM +0000, Matt Fleming wrote:
> On Wed, 22 Feb, at 12:41:01PM, Linus Torvalds wrote:

> I think Peter has the fix for this somewhere, but it doesn't look like
> it made it to tip/sched/core.
> 
> Peter, this is the original patch,
> 
>   https://lkml.kernel.org/r/20170202155506.GX6515@twins.programming.kicks-ass.net

I have it, send it to Ingo the day he send out the pull requests.

[toc] | [prev] | [next] | [standalone]

#1587331

FromIngo Molnar <mingo@kernel.org>
Date2017-02-24 09:00 +0100
Message-ID<teiXf-5sB-3@gated-at.bofh.it>
In reply to#1586490
* Peter Zijlstra <peterz@infradead.org> wrote:

> On Wed, Feb 22, 2017 at 08:51:44PM +0000, Matt Fleming wrote:
> > On Wed, 22 Feb, at 12:41:01PM, Linus Torvalds wrote:
> 
> > I think Peter has the fix for this somewhere, but it doesn't look like
> > it made it to tip/sched/core.
> > 
> > Peter, this is the original patch,
> > 
> >   https://lkml.kernel.org/r/20170202155506.GX6515@twins.programming.kicks-ass.net
> 
> I have it, send it to Ingo the day he send out the pull requests.

Thanks - will send this to Linus ASAP!

Thanks,

	Ingo

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web