Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1587311 > unrolled thread

[PATCH 3/3] mwifiex: wake system up when receives a wake irq

Started byJeffy Chen <jeffy.chen@rock-chips.com>
First post2017-02-24 07:30 +0100
Last post2017-02-24 13:30 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 3/3] mwifiex: wake system up when receives a wake irq Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-02-24 07:30 +0100
    Re: [PATCH 3/3] mwifiex: wake system up when receives a wake irq Kalle Valo <kvalo@codeaurora.org> - 2017-02-24 12:10 +0100
      Re: [PATCH 3/3] mwifiex: wake system up when receives a wake irq jeffy <jeffy.chen@rock-chips.com> - 2017-02-24 13:30 +0100

#1587311 — [PATCH 3/3] mwifiex: wake system up when receives a wake irq

FromJeffy Chen <jeffy.chen@rock-chips.com>
Date2017-02-24 07:30 +0100
Subject[PATCH 3/3] mwifiex: wake system up when receives a wake irq
Message-ID<tehy9-4EO-1@gated-at.bofh.it>
Currrently we are disabling this wake irq after receiving it. If this
happens before we finish suspend and the pm event check is disabled,
the system will continue suspending, and this irq would not work again.

We may need to abort system suspend to avoid that.

Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

 drivers/net/wireless/marvell/mwifiex/main.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c
index 5ebca1d..30f4994 100644
--- a/drivers/net/wireless/marvell/mwifiex/main.c
+++ b/drivers/net/wireless/marvell/mwifiex/main.c
@@ -17,6 +17,8 @@
  * this warranty disclaimer.
  */
 
+#include <linux/suspend.h>
+
 #include "main.h"
 #include "wmm.h"
 #include "cfg80211.h"
@@ -1509,6 +1511,7 @@ static irqreturn_t mwifiex_irq_wakeup_handler(int irq, void *priv)
 
 	/* Notify PM core we are wakeup source */
 	pm_wakeup_event(adapter->dev, 0);
+	pm_system_wakeup();
 
 	return IRQ_HANDLED;
 }
-- 
2.1.4

[toc] | [next] | [standalone]


#1587521

FromKalle Valo <kvalo@codeaurora.org>
Date2017-02-24 12:10 +0100
Message-ID<telV8-7Hn-13@gated-at.bofh.it>
In reply to#1587311
Jeffy Chen <jeffy.chen@rock-chips.com> writes:

> Currrently we are disabling this wake irq after receiving it. If this
> happens before we finish suspend and the pm event check is disabled,
> the system will continue suspending, and this irq would not work again.
>
> We may need to abort system suspend to avoid that.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>

I only see patch 3 in patchwork. Where are patches 1 and 2?

-- 
Kalle Valo

[toc] | [prev] | [next] | [standalone]


#1587561

Fromjeffy <jeffy.chen@rock-chips.com>
Date2017-02-24 13:30 +0100
Message-ID<tenax-8vq-11@gated-at.bofh.it>
In reply to#1587521
Hi Kalle,

On 02/24/2017 07:01 PM, Kalle Valo wrote:
> Jeffy Chen <jeffy.chen@rock-chips.com> writes:
>
>> Currrently we are disabling this wake irq after receiving it. If this
>> happens before we finish suspend and the pm event check is disabled,
>> the system will continue suspending, and this irq would not work again.
>>
>> We may need to abort system suspend to avoid that.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> I only see patch 3 in patchwork. Where are patches 1 and 2?
>


the other two are much like this one, but for bluetooth :)

please check:

https://patchwork.kernel.org/patch/9589455 New          [1/3] btusb: 
wake system up when receives a wake irq
https://patchwork.kernel.org/patch/9589453 New          [2/3] btmrvl: 
wake system up when receives a wake irq
https://patchwork.kernel.org/patch/9589457 New          [3/3] mwifiex: 
wake system up when receives a wake irq



(sorry, this is a resent mail, because the last one was rejected due to 
wrong format)

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web