Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1587314 > unrolled thread

[PATCH] clk: zynqmp: fix itnull.cocci warnings

Started byJulia Lawall <julia.lawall@lip6.fr>
First post2017-02-24 07:50 +0100
Last post2017-02-24 07:50 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH] clk: zynqmp: fix itnull.cocci warnings Julia Lawall <julia.lawall@lip6.fr> - 2017-02-24 07:50 +0100

#1587314 — [PATCH] clk: zynqmp: fix itnull.cocci warnings

FromJulia Lawall <julia.lawall@lip6.fr>
Date2017-02-24 07:50 +0100
Subject[PATCH] clk: zynqmp: fix itnull.cocci warnings
Message-ID<tehRv-4Ld-1@gated-at.bofh.it>
Iterator variable bound on line 220 cannot be NULL

Generated by: scripts/coccinelle/iterators/itnull.cocci

CC: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

tree:   https://github.com/Xilinx/linux-xlnx master
head:   1741e191412444e3ab3308b407a9328186c248e4
commit: 75b49bd76a45208749235a7ba35dba96e3e706f0 [358/384] clk: zynqmp:
Add check for no of users for vpll

Actually, the patch needs to be extended to drop the braces as well.

 clk.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -218,8 +218,6 @@ static void clk_show_subtree(struct clk_
 		sibling++;

 	hlist_for_each_entry(child, &c->children, child_node) {
-		if (!child)
-			return;
 		clk_show_subtree(child, level + 1);
 	}
 }

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web