Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584658 > unrolled thread

[PATCH 0/2] Add support for cros-ec-extcon driver

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] Add support for cros-ec-extcon driver Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-02-20 16:20 +0100
    [PATCH 2/2] dt-bindings: extcon: Add support for cros-ec device Enric Balletbo i Serra <enric.balletbo@collabora.com> - 2017-02-20 16:20 +0100
      Re: [PATCH 2/2] dt-bindings: extcon: Add support for cros-ec device Chanwoo Choi <cw00.choi@samsung.com> - 2017-02-24 05:00 +0100
      Re: [PATCH 2/2] dt-bindings: extcon: Add support for cros-ec device Rob Herring <robh@kernel.org> - 2017-02-27 21:30 +0100

#1584658 — [PATCH 0/2] Add support for cros-ec-extcon driver

Dear all,

Now that the drm/rockchip cdn-dp driver is in linux-next and ready to land
it's time to review the extcon-cros-ec driver. The cdn-dp driver uses this
extcon driver to get cable status and the presence of display out.

This driver is based on the one available in chromeos-4.4 kernel but removing
all the USB switch role stuff, as this depends on other infrastructures like 
the dwc3 role switch and the Type-C connector.

Benson Leung (2):
  extcon: cros-ec: Add extcon-cros-ec driver to support display out.
  dt-bindings: extcon: Add support for cros-ec device

 .../devicetree/bindings/extcon/extcon-cros-ec.txt  |  24 ++
 drivers/extcon/Kconfig                             |   7 +
 drivers/extcon/Makefile                            |   1 +
 drivers/extcon/extcon-cros_ec.c                    | 480 +++++++++++++++++++++
 include/linux/mfd/cros_ec_commands.h               |  75 ++++
 5 files changed, 587 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt
 create mode 100644 drivers/extcon/extcon-cros_ec.c

-- 
2.9.3

[toc] | [next] | [standalone]

#1584661 — [PATCH 2/2] dt-bindings: extcon: Add support for cros-ec device

From: Benson Leung <bleung@chromium.org>

This patch add documentation for binding of USB Type C cable detection
mechanism is using EXTCON subsystem. The device can detect the presence
of display out but it may also detect other external accessories when
external accessories is attached or detached.

Signed-off-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
 .../devicetree/bindings/extcon/extcon-cros-ec.txt  | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt

diff --git a/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt
new file mode 100644
index 0000000..3576869
--- /dev/null
+++ b/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt
@@ -0,0 +1,24 @@
+ChromeOS EC Type-C Extcon device
+
+On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
+able to detect the state of external accessories such as display adapters
+or USB devices when said accessories are attached or detached.
+
+The node for this device must be under a cros-ec node like google,cros-ec-spi
+or google,cros-ec-i2c.
+
+Required properties:
+- compatible:		Should be "google,extcon-cros-ec".
+- google,usb-port-id:	Specifies the USB port ID to use.
+
+Example:
+	cros-ec@0 {
+		compatible = "google,cros-ec-i2c";
+
+		...
+
+		extcon {
+			compatible = "google,extcon-cros-ec";
+			google,usb-port-id = <0>;
+		};
+	}
-- 
2.9.3

[toc] | [prev] | [next] | [standalone]

#1587275 — Re: [PATCH 2/2] dt-bindings: extcon: Add support for cros-ec device

On 2017년 02월 21일 00:18, Enric Balletbo i Serra wrote:
> From: Benson Leung <bleung@chromium.org>
> 
> This patch add documentation for binding of USB Type C cable detection
> mechanism is using EXTCON subsystem. The device can detect the presence
> of display out but it may also detect other external accessories when
> external accessories is attached or detached.
> 
> Signed-off-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>  .../devicetree/bindings/extcon/extcon-cros-ec.txt  | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt
> 
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt
> new file mode 100644
> index 0000000..3576869
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt
> @@ -0,0 +1,24 @@
> +ChromeOS EC Type-C Extcon device
> +
> +On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
> +able to detect the state of external accessories such as display adapters
> +or USB devices when said accessories are attached or detached.
> +
> +The node for this device must be under a cros-ec node like google,cros-ec-spi
> +or google,cros-ec-i2c.
> +
> +Required properties:
> +- compatible:		Should be "google,extcon-cros-ec".
> +- google,usb-port-id:	Specifies the USB port ID to use.
> +
> +Example:
> +	cros-ec@0 {
> +		compatible = "google,cros-ec-i2c";
> +
> +		...
> +
> +		extcon {
> +			compatible = "google,extcon-cros-ec";
> +			google,usb-port-id = <0>;
> +		};
> +	}
> 

Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

[toc] | [prev] | [next] | [standalone]

#1588912 — Re: [PATCH 2/2] dt-bindings: extcon: Add support for cros-ec device

On Mon, Feb 20, 2017 at 04:18:54PM +0100, Enric Balletbo i Serra wrote:
> From: Benson Leung <bleung@chromium.org>
> 
> This patch add documentation for binding of USB Type C cable detection
> mechanism is using EXTCON subsystem. The device can detect the presence
> of display out but it may also detect other external accessories when
> external accessories is attached or detached.
> 
> Signed-off-by: Benson Leung <bleung@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>  .../devicetree/bindings/extcon/extcon-cros-ec.txt  | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt
> 
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt b/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt
> new file mode 100644
> index 0000000..3576869
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/extcon/extcon-cros-ec.txt
> @@ -0,0 +1,24 @@
> +ChromeOS EC Type-C Extcon device

Extcon is a Linux term. Devicetree describes the h/w.

> +
> +On ChromeOS systems with USB Type C ports, the ChromeOS Embedded Controller is
> +able to detect the state of external accessories such as display adapters
> +or USB devices when said accessories are attached or detached.
> +
> +The node for this device must be under a cros-ec node like google,cros-ec-spi
> +or google,cros-ec-i2c.
> +
> +Required properties:
> +- compatible:		Should be "google,extcon-cros-ec".

Perhaps something indicating this is USB Type C related.

> +- google,usb-port-id:	Specifies the USB port ID to use.

What are the choices here? Most likely this should be some phandle back 
to the USB controller or hub.

> +
> +Example:
> +	cros-ec@0 {
> +		compatible = "google,cros-ec-i2c";
> +
> +		...
> +
> +		extcon {
> +			compatible = "google,extcon-cros-ec";
> +			google,usb-port-id = <0>;
> +		};
> +	}
> -- 
> 2.9.3
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web