Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1586517 > unrolled thread

[PATCH] scsi/mac_scsi: Fix MAC_SCSI=m option when SCSI=m

Started byFinn Thain <fthain@telegraphics.com.au>
First post2017-02-22 23:10 +0100
Last post2017-02-24 00:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] scsi/mac_scsi: Fix MAC_SCSI=m option when SCSI=m Finn Thain <fthain@telegraphics.com.au> - 2017-02-22 23:10 +0100
    Re: [PATCH] scsi/mac_scsi: Fix MAC_SCSI=m option when SCSI=m "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-02-24 00:40 +0100

#1586517 — [PATCH] scsi/mac_scsi: Fix MAC_SCSI=m option when SCSI=m

FromFinn Thain <fthain@telegraphics.com.au>
Date2017-02-22 23:10 +0100
Subject[PATCH] scsi/mac_scsi: Fix MAC_SCSI=m option when SCSI=m
Message-ID<tdNgK-8oY-5@gated-at.bofh.it>
The mac_scsi driver still gets disabled when SCSI=m. This should have
been fixed back when I enabled the tristate but I didn't see the bug.

Fixes: 6e9ae6d560e1 ("[PATCH] mac_scsi: Add module option to Kconfig")
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
 drivers/scsi/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index a4f6b0d..f8b0ba0 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1477,7 +1477,7 @@ config ATARI_SCSI
 
 config MAC_SCSI
 	tristate "Macintosh NCR5380 SCSI"
-	depends on MAC && SCSI=y
+	depends on MAC && SCSI
 	select SCSI_SPI_ATTRS
 	help
 	  This is the NCR 5380 SCSI controller included on most of the 68030

[toc] | [next] | [standalone]


#1587184

From"Martin K. Petersen" <martin.petersen@oracle.com>
Date2017-02-24 00:40 +0100
Message-ID<teb9n-8k8-17@gated-at.bofh.it>
In reply to#1586517
>>>>> "Finn" == Finn Thain <fthain@telegraphics.com.au> writes:

Finn> The mac_scsi driver still gets disabled when SCSI=m. This should
Finn> have been fixed back when I enabled the tristate but I didn't see
Finn> the bug.

Applied to 4.11/scsi-fixes.

-- 
Martin K. Petersen	Oracle Linux Engineering

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web