Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1588277 > unrolled thread
| Started by | Man Choy <manchoyy@gmail.com> |
|---|---|
| First post | 2017-02-26 06:40 +0100 |
| Last post | 2017-02-28 02:10 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] speakup: synth: Fix checkpatch warning Man Choy <manchoyy@gmail.com> - 2017-02-26 06:40 +0100
Re: [PATCH] speakup: synth: Fix checkpatch warning Greg KH <gregkh@linuxfoundation.org> - 2017-02-27 15:50 +0100
Re: [PATCH] speakup: synth: Fix checkpatch warning Man Choy <manchoyy@gmail.com> - 2017-02-28 02:10 +0100
| From | Man Choy <manchoyy@gmail.com> |
|---|---|
| Date | 2017-02-26 06:40 +0100 |
| Subject | [PATCH] speakup: synth: Fix checkpatch warning |
| Message-ID | <teZIR-2eX-3@gated-at.bofh.it> |
Fix following checkpatch warning:
WARNING: line over 80 characters
+ &synth->attributes) < 0)
total: 0 errors, 1 warnings, 485 lines checked
Signed-off-by: Man Choy <manchoyy@gmail.com>
---
drivers/staging/speakup/synth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index a61c02b..d984312 100644
--- a/drivers/staging/speakup/synth.c
+++ b/drivers/staging/speakup/synth.c
@@ -406,8 +406,8 @@ static int do_synth_init(struct spk_synth *in_synth)
speakup_register_var(var);
if (!spk_quiet_boot)
synth_printf("%s found\n", synth->long_name);
- if (synth->attributes.name && sysfs_create_group(speakup_kobj,
- &synth->attributes) < 0)
+ if (synth->attributes.name &&
+ sysfs_create_group(speakup_kobj, &synth->attributes) < 0)
return -ENOMEM;
synth_flags = synth->flags;
wake_up_interruptible_all(&speakup_event);
--
2.7.4
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-27 15:50 +0100 |
| Message-ID | <tfuMG-6Wf-17@gated-at.bofh.it> |
| In reply to | #1588277 |
On Sun, Feb 26, 2017 at 01:22:18PM +0800, Man Choy wrote: > Fix following checkpatch warning: > > WARNING: line over 80 characters > + &synth->attributes) < 0) > > total: 0 errors, 1 warnings, 485 lines checked > Signed-off-by: Man Choy <manchoyy@gmail.com> > --- > drivers/staging/speakup/synth.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Someone else already did this before you did, sorry :( greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Man Choy <manchoyy@gmail.com> |
|---|---|
| Date | 2017-02-28 02:10 +0100 |
| Message-ID | <tfEsF-5rD-15@gated-at.bofh.it> |
| In reply to | #1588687 |
On Mon, Feb 27, 2017 at 10:42 PM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Sun, Feb 26, 2017 at 01:22:18PM +0800, Man Choy wrote: >> Fix following checkpatch warning: >> >> WARNING: line over 80 characters >> + &synth->attributes) < 0) >> >> total: 0 errors, 1 warnings, 485 lines checked >> Signed-off-by: Man Choy <manchoyy@gmail.com> >> --- >> drivers/staging/speakup/synth.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Someone else already did this before you did, sorry :( > > greg k-h No worries. Thanks Greg. Will look up other problem to solve.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web