Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588176 > unrolled thread

[PATCH 0/3] Allow setting dmi-product-name on the cmdline + dmi sdhci quirk

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] Allow setting dmi-product-name on the cmdline + dmi sdhci quirk Hans de Goede <hdegoede@redhat.com> - 2017-02-25 18:30 +0100
    [PATCH 3/3] mmc: sdhci-acpi: Add a quirk to not break wifi on GPD WIN I55 machines Hans de Goede <hdegoede@redhat.com> - 2017-02-25 18:30 +0100

#1588176 — [PATCH 0/3] Allow setting dmi-product-name on the cmdline + dmi sdhci quirk

Hi All,

So patch 1/3 and 2+3/3 are only somewhat related and they can be merged
independent of each other.

The catch is that the GPD win for which patch 3/3 adds a dmi based quirk
does not have any usable dmi strings. I've contacted the manufacturer
for a BIOS update (no clue how that will go) but even with the BIOS update
I believe patch 1/3 will be useful for similar cases and for people who
do not want to flash their BIOS.

So if Jean is happy with patch 1/3 then 2+3/3 can be merged independently.

Regards,

Hans

p.s.

Takashi this means that you can add a dmi based quirk for the headphone
detection too, my goal is to make everything just work on the GPD win
if the user supplies dmi_product_name=GPD-WINI55 on the kernel cmdline
(we will also need a udev hwdb entry to fix the accelerometer orientation).

[toc] | [next] | [standalone]

#1588178 — [PATCH 3/3] mmc: sdhci-acpi: Add a quirk to not break wifi on GPD WIN I55 machines

The GPD WIN (I55) has a bug in its ACPI tables where putting the unused
80860F14 UID 2 (SDIO) device in PS0 toggles a gpio disabling the pcie wifi
until the next reboot.

Add a quirk to skip probing of the unused SDIO controller, fixing this.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/mmc/host/sdhci-acpi.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c
index 873beae..957d0b8 100644
--- a/drivers/mmc/host/sdhci-acpi.c
+++ b/drivers/mmc/host/sdhci-acpi.c
@@ -36,6 +36,7 @@
 #include <linux/pm.h>
 #include <linux/pm_runtime.h>
 #include <linux/delay.h>
+#include <linux/dmi.h>
 
 #include <linux/mmc/host.h>
 #include <linux/mmc/pm.h>
@@ -397,6 +398,18 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
 	if (acpi_bus_get_status(device) || !device->status.present)
 		return -ENODEV;
 
+	hid = acpi_device_hid(device);
+	uid = device->pnp.unique_id;
+
+	/*
+	 * The GPD WIN (I55) has a bug in its ACPI tables where putting the
+	 * unused 80860F14 UID 2 (SDIO) device in PS0 toggles a gpio
+	 * disabling the pcie wifi.
+	 */
+	if (strcmp(hid, "80860F14") == 0 && strcmp(uid, "2") == 0 &&
+			dmi_match(DMI_PRODUCT_NAME, "GPD-WINI55"))
+		return -ENODEV;
+
 	/* Power on the SDHCI controller and its children */
 	acpi_device_fix_up_power(device);
 	list_for_each_entry(child, &device->children, node)
@@ -406,9 +419,6 @@ static int sdhci_acpi_probe(struct platform_device *pdev)
 	if (sdhci_acpi_byt_defer(dev))
 		return -EPROBE_DEFER;
 
-	hid = acpi_device_hid(device);
-	uid = device->pnp.unique_id;
-
 	iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	if (!iomem)
 		return -ENOMEM;
-- 
2.9.3

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web