Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588130 > unrolled thread

[PATCH] ASoC: kirkwood: Add a blank line after declarations

Back to article view | Back to linux.kernel

Contents

  [PATCH] ASoC: kirkwood: Add a blank line after declarations Anda-Alexandra Dorneanu <andadrn@gmail.com> - 2017-02-25 12:40 +0100
    Re: [PATCH] ASoC: kirkwood: Add a blank line after declarations Julia Lawall <julia.lawall@lip6.fr> - 2017-02-25 14:30 +0100

#1588130 — [PATCH] ASoC: kirkwood: Add a blank line after declarations

From: andadrn <andadrn@gmail.com>

This was reported by checkpatch.pl

Signed-off-by: Anda-Alexandra Dorneanu <andadrn@gmail.com>
---
 sound/soc/kirkwood/kirkwood-dma.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c
index dafd22e..0af5d46 100644
--- a/sound/soc/kirkwood/kirkwood-dma.c
+++ b/sound/soc/kirkwood/kirkwood-dma.c
@@ -24,6 +24,7 @@
 static struct kirkwood_dma_data *kirkwood_priv(struct snd_pcm_substream *subs)
 {
 	struct snd_soc_pcm_runtime *soc_runtime = subs->private_data;
+
 	return snd_soc_dai_get_drvdata(soc_runtime->cpu_dai);
 }
 
@@ -91,6 +92,7 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id)
 	/* try to find matching cs for current dma address */
 	for (i = 0; i < dram->num_cs; i++) {
 		const struct mbus_dram_window *cs = dram->cs + i;
+
 		if ((cs->base & 0xffff0000) < (dma & 0xffff0000)) {
 			writel(cs->base & 0xffff0000,
 				base + KIRKWOOD_AUDIO_WIN_BASE_REG(win));
-- 
1.9.1

[toc] | [next] | [standalone]

#1588137

On Sat, 25 Feb 2017, Anda-Alexandra Dorneanu wrote:

> From: andadrn <andadrn@gmail.com>

Drop the From line.  The From line needs to match up with your Signed off
by line.  But the one generated by your mailer already does that, while
the one you added does not.

julia

>
> This was reported by checkpatch.pl
>
> Signed-off-by: Anda-Alexandra Dorneanu <andadrn@gmail.com>
> ---
>  sound/soc/kirkwood/kirkwood-dma.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/kirkwood/kirkwood-dma.c b/sound/soc/kirkwood/kirkwood-dma.c
> index dafd22e..0af5d46 100644
> --- a/sound/soc/kirkwood/kirkwood-dma.c
> +++ b/sound/soc/kirkwood/kirkwood-dma.c
> @@ -24,6 +24,7 @@
>  static struct kirkwood_dma_data *kirkwood_priv(struct snd_pcm_substream *subs)
>  {
>  	struct snd_soc_pcm_runtime *soc_runtime = subs->private_data;
> +
>  	return snd_soc_dai_get_drvdata(soc_runtime->cpu_dai);
>  }
>
> @@ -91,6 +92,7 @@ static irqreturn_t kirkwood_dma_irq(int irq, void *dev_id)
>  	/* try to find matching cs for current dma address */
>  	for (i = 0; i < dram->num_cs; i++) {
>  		const struct mbus_dram_window *cs = dram->cs + i;
> +
>  		if ((cs->base & 0xffff0000) < (dma & 0xffff0000)) {
>  			writel(cs->base & 0xffff0000,
>  				base + KIRKWOOD_AUDIO_WIN_BASE_REG(win));
> --
> 1.9.1
>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web