Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1586709 > unrolled thread

[PATCH 01/11] drm/sun4i: Make sunxi_rgb2yuv_coef constant

Started byChen-Yu Tsai <wens@csie.org>
First post2017-02-23 09:20 +0100
Last post2017-02-23 19:20 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 01/11] drm/sun4i: Make sunxi_rgb2yuv_coef constant Chen-Yu Tsai <wens@csie.org> - 2017-02-23 09:20 +0100
    Re: [PATCH 01/11] drm/sun4i: Make sunxi_rgb2yuv_coef constant Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-23 19:20 +0100

#1586709 — [PATCH 01/11] drm/sun4i: Make sunxi_rgb2yuv_coef constant

FromChen-Yu Tsai <wens@csie.org>
Date2017-02-23 09:20 +0100
Subject[PATCH 01/11] drm/sun4i: Make sunxi_rgb2yuv_coef constant
Message-ID<tdWN3-731-9@gated-at.bofh.it>
sunxi_rgb2yuv_coef is a table of RGB-to-YUV conversion coefficients.
They are programmed into the hardware, and can be declared constant.

Reported-by: Priit Laes <plaes@plaes.org>
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/gpu/drm/sun4i/sun4i_backend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c
index 5bf1ea4d92fc..7a61bd330f04 100644
--- a/drivers/gpu/drm/sun4i/sun4i_backend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_backend.c
@@ -24,7 +24,7 @@
 #include "sun4i_backend.h"
 #include "sun4i_drv.h"
 
-static u32 sunxi_rgb2yuv_coef[12] = {
+static const u32 sunxi_rgb2yuv_coef[12] = {
 	0x00000107, 0x00000204, 0x00000064, 0x00000108,
 	0x00003f69, 0x00003ed6, 0x000001c1, 0x00000808,
 	0x000001c1, 0x00003e88, 0x00003fb8, 0x00000808
-- 
2.11.0

[toc] | [next] | [standalone]


#1587066

FromMaxime Ripard <maxime.ripard@free-electrons.com>
Date2017-02-23 19:20 +0100
Message-ID<te69I-4Vi-11@gated-at.bofh.it>
In reply to#1586709

[Multipart message — attachments visible in raw view] — view raw

On Thu, Feb 23, 2017 at 04:05:33PM +0800, Chen-Yu Tsai wrote:
> sunxi_rgb2yuv_coef is a table of RGB-to-YUV conversion coefficients.
> They are programmed into the hardware, and can be declared constant.
> 
> Reported-by: Priit Laes <plaes@plaes.org>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web