Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583158 > unrolled thread
| Started by | Joe Perches <joe@perches.com> |
|---|---|
| First post | 2017-02-17 08:30 +0100 |
| Last post | 2017-02-23 19:00 +0100 |
| Articles | 7 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches <joe@perches.com> - 2017-02-17 08:30 +0100
[PATCH 04/35] arch/blackfin: Convert remaining uses of pr_warning to pr_warn Joe Perches <joe@perches.com> - 2017-02-17 08:30 +0100
Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn "Rafael J. Wysocki" <rafael@kernel.org> - 2017-02-17 13:40 +0100
Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Rob Herring <robh@kernel.org> - 2017-02-23 16:30 +0100
Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches <joe@perches.com> - 2017-02-23 18:30 +0100
Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Emil Velikov <emil.l.velikov@gmail.com> - 2017-02-23 18:50 +0100
Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches <joe@perches.com> - 2017-02-23 19:00 +0100
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-17 08:30 +0100 |
| Subject | [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn |
| Message-ID | <tbKZH-176-3@gated-at.bofh.it> |
There are ~4300 uses of pr_warn and ~250 uses of the older pr_warning in the kernel source tree. Make the use of pr_warn consistent across all kernel files. This excludes all files in tools/ as there is a separate define pr_warning for that directory tree and pr_warn is not used in tools/. Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. Miscellanea: o Coalesce formats and realign arguments Some files not compiled - no cross-compilers Joe Perches (35): alpha: Convert remaining uses of pr_warning to pr_warn ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn arm64: Convert remaining uses of pr_warning to pr_warn arch/blackfin: Convert remaining uses of pr_warning to pr_warn ia64: Convert remaining use of pr_warning to pr_warn powerpc: Convert remaining uses of pr_warning to pr_warn sh: Convert remaining uses of pr_warning to pr_warn sparc: Convert remaining use of pr_warning to pr_warn x86: Convert remaining uses of pr_warning to pr_warn drivers/acpi: Convert remaining uses of pr_warning to pr_warn block/drbd: Convert remaining uses of pr_warning to pr_warn gdrom: Convert remaining uses of pr_warning to pr_warn drivers/char: Convert remaining use of pr_warning to pr_warn clocksource: Convert remaining use of pr_warning to pr_warn drivers/crypto: Convert remaining uses of pr_warning to pr_warn fmc: Convert remaining use of pr_warning to pr_warn drivers/gpu: Convert remaining uses of pr_warning to pr_warn drivers/ide: Convert remaining uses of pr_warning to pr_warn drivers/input: Convert remaining uses of pr_warning to pr_warn drivers/isdn: Convert remaining uses of pr_warning to pr_warn drivers/macintosh: Convert remaining uses of pr_warning to pr_warn drivers/media: Convert remaining use of pr_warning to pr_warn drivers/mfd: Convert remaining uses of pr_warning to pr_warn drivers/mtd: Convert remaining uses of pr_warning to pr_warn drivers/of: Convert remaining uses of pr_warning to pr_warn drivers/oprofile: Convert remaining uses of pr_warning to pr_warn drivers/platform: Convert remaining uses of pr_warning to pr_warn drivers/rapidio: Convert remaining use of pr_warning to pr_warn drivers/scsi: Convert remaining use of pr_warning to pr_warn drivers/sh: Convert remaining use of pr_warning to pr_warn drivers/tty: Convert remaining uses of pr_warning to pr_warn drivers/video: Convert remaining uses of pr_warning to pr_warn kernel/trace: Convert remaining uses of pr_warning to pr_warn lib: Convert remaining uses of pr_warning to pr_warn sound/soc: Convert remaining uses of pr_warning to pr_warn arch/alpha/kernel/perf_event.c | 4 +- arch/arm/mach-ep93xx/core.c | 4 +- arch/arm64/include/asm/syscall.h | 8 ++-- arch/arm64/kernel/hw_breakpoint.c | 8 ++-- arch/arm64/kernel/smp.c | 4 +- arch/blackfin/kernel/nmi.c | 2 +- arch/blackfin/kernel/ptrace.c | 2 +- arch/blackfin/mach-bf533/boards/stamp.c | 2 +- arch/blackfin/mach-bf537/boards/cm_bf537e.c | 2 +- arch/blackfin/mach-bf537/boards/cm_bf537u.c | 2 +- arch/blackfin/mach-bf537/boards/stamp.c | 2 +- arch/blackfin/mach-bf537/boards/tcm_bf537.c | 2 +- arch/blackfin/mach-bf561/boards/cm_bf561.c | 2 +- arch/blackfin/mach-bf561/boards/ezkit.c | 2 +- arch/blackfin/mm/isram-driver.c | 4 +- arch/ia64/kernel/setup.c | 6 +-- arch/powerpc/kernel/pci-common.c | 4 +- arch/powerpc/mm/init_64.c | 5 +-- arch/powerpc/mm/mem.c | 3 +- arch/powerpc/platforms/512x/mpc512x_shared.c | 4 +- arch/powerpc/platforms/85xx/socrates_fpga_pic.c | 7 ++-- arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +- arch/powerpc/platforms/pasemi/dma_lib.c | 4 +- arch/powerpc/platforms/powernv/opal.c | 8 ++-- arch/powerpc/platforms/powernv/pci-ioda.c | 10 ++--- arch/powerpc/platforms/ps3/device-init.c | 14 +++---- arch/powerpc/platforms/ps3/mm.c | 4 +- arch/powerpc/platforms/ps3/os-area.c | 2 +- arch/powerpc/platforms/pseries/iommu.c | 8 ++-- arch/powerpc/platforms/pseries/setup.c | 4 +- arch/powerpc/sysdev/fsl_pci.c | 9 ++--- arch/powerpc/sysdev/mpic.c | 10 ++--- arch/powerpc/sysdev/xics/icp-native.c | 10 ++--- arch/powerpc/sysdev/xics/ics-opal.c | 4 +- arch/powerpc/sysdev/xics/ics-rtas.c | 4 +- arch/powerpc/sysdev/xics/xics-common.c | 8 ++-- arch/sh/boards/mach-sdk7786/nmi.c | 2 +- arch/sh/drivers/pci/fixups-sdk7786.c | 2 +- arch/sh/kernel/io_trapped.c | 2 +- arch/sh/kernel/setup.c | 2 +- arch/sh/mm/consistent.c | 5 +-- arch/sparc/kernel/smp_64.c | 5 +-- arch/x86/kernel/amd_gart_64.c | 12 ++---- arch/x86/kernel/apic/apic.c | 46 ++++++++++------------ arch/x86/kernel/apic/apic_noop.c | 2 +- arch/x86/kernel/setup_percpu.c | 4 +- arch/x86/kernel/tboot.c | 15 ++++--- arch/x86/kernel/tsc_sync.c | 8 ++-- arch/x86/mm/kmmio.c | 8 ++-- arch/x86/mm/mmio-mod.c | 5 +-- arch/x86/mm/numa.c | 12 +++--- arch/x86/mm/numa_emulation.c | 6 +-- arch/x86/mm/testmmiotrace.c | 5 +-- arch/x86/oprofile/op_x86_model.h | 6 +-- arch/x86/platform/olpc/olpc-xo15-sci.c | 2 +- arch/x86/platform/sfi/sfi.c | 3 +- arch/x86/xen/debugfs.c | 2 +- arch/x86/xen/setup.c | 2 +- drivers/acpi/apei/apei-base.c | 32 +++++++-------- drivers/acpi/apei/einj.c | 4 +- drivers/acpi/apei/erst-dbg.c | 4 +- drivers/acpi/apei/ghes.c | 30 +++++++------- drivers/acpi/apei/hest.c | 10 ++--- drivers/acpi/resource.c | 4 +- drivers/block/drbd/drbd_nl.c | 13 +++--- drivers/cdrom/gdrom.c | 4 +- drivers/char/virtio_console.c | 2 +- drivers/clocksource/samsung_pwm_timer.c | 4 +- drivers/crypto/n2_core.c | 12 +++--- drivers/fmc/fmc-fakedev.c | 2 +- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 2 +- drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c | 4 +- drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 14 +++---- .../gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 +- drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 4 +- drivers/ide/tx4938ide.c | 2 +- drivers/ide/tx4939ide.c | 5 +-- drivers/input/gameport/gameport.c | 4 +- drivers/input/joystick/gamecon.c | 3 +- drivers/input/misc/apanel.c | 3 +- drivers/input/misc/xen-kbdfront.c | 8 ++-- drivers/input/serio/serio.c | 8 ++-- drivers/isdn/gigaset/interface.c | 2 +- drivers/isdn/hardware/mISDN/avmfritz.c | 17 ++++---- drivers/isdn/hardware/mISDN/hfcmulti.c | 8 ++-- drivers/isdn/hardware/mISDN/hfcpci.c | 4 +- drivers/isdn/hardware/mISDN/hfcsusb.c | 4 +- drivers/isdn/hardware/mISDN/mISDNipac.c | 4 +- drivers/isdn/hardware/mISDN/mISDNisar.c | 10 ++--- drivers/isdn/hardware/mISDN/netjet.c | 8 ++-- drivers/isdn/hardware/mISDN/w6692.c | 12 +++--- drivers/isdn/mISDN/hwchannel.c | 8 ++-- drivers/macintosh/windfarm_fcu_controls.c | 5 +-- drivers/macintosh/windfarm_lm87_sensor.c | 4 +- drivers/macintosh/windfarm_pm72.c | 22 +++++------ drivers/macintosh/windfarm_rm31.c | 6 +-- drivers/media/platform/sh_vou.c | 4 +- drivers/mfd/db8500-prcmu.c | 2 +- drivers/mfd/sta2x11-mfd.c | 4 +- drivers/mfd/twl4030-power.c | 7 +--- drivers/mtd/chips/cfi_cmdset_0002.c | 12 ++++-- drivers/mtd/nand/cmx270_nand.c | 4 +- drivers/mtd/ofpart.c | 4 +- drivers/of/fdt.c | 20 +++++----- drivers/oprofile/oprofile_perf.c | 8 ++-- drivers/platform/x86/asus-laptop.c | 2 +- drivers/platform/x86/eeepc-laptop.c | 2 +- drivers/platform/x86/intel_oaktrail.c | 10 ++--- drivers/rapidio/rio-sysfs.c | 4 +- drivers/scsi/a3000.c | 2 +- drivers/sh/intc/core.c | 4 +- drivers/tty/hvc/hvcs.c | 2 +- drivers/tty/tty_io.c | 4 +- drivers/video/fbdev/aty/radeon_base.c | 4 +- drivers/video/fbdev/core/fbmon.c | 4 +- drivers/video/fbdev/pxafb.c | 7 ++-- kernel/trace/trace_benchmark.c | 4 +- lib/cpu_rmap.c | 2 +- lib/dma-debug.c | 2 +- sound/soc/fsl/imx-audmux.c | 6 +-- sound/soc/samsung/s3c-i2s-v2.c | 6 +-- 122 files changed, 367 insertions(+), 397 deletions(-) -- 2.10.0.rc2.1.g053435c
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-17 08:30 +0100 |
| Subject | [PATCH 04/35] arch/blackfin: Convert remaining uses of pr_warning to pr_warn |
| Message-ID | <tbL9o-1am-9@gated-at.bofh.it> |
| In reply to | #1583158 |
To enable eventual removal of pr_warning
This makes pr_warn use consistent for arch/blackfin
Prior to this patch, there were 11 uses of pr_warning and
0 uses of pr_warn in arch/blackfin
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/blackfin/kernel/nmi.c | 2 +-
arch/blackfin/kernel/ptrace.c | 2 +-
arch/blackfin/mach-bf533/boards/stamp.c | 2 +-
arch/blackfin/mach-bf537/boards/cm_bf537e.c | 2 +-
arch/blackfin/mach-bf537/boards/cm_bf537u.c | 2 +-
arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
arch/blackfin/mach-bf537/boards/tcm_bf537.c | 2 +-
arch/blackfin/mach-bf561/boards/cm_bf561.c | 2 +-
arch/blackfin/mach-bf561/boards/ezkit.c | 2 +-
arch/blackfin/mm/isram-driver.c | 4 ++--
10 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/arch/blackfin/kernel/nmi.c b/arch/blackfin/kernel/nmi.c
index 9919d29287dc..bc837dc38998 100644
--- a/arch/blackfin/kernel/nmi.c
+++ b/arch/blackfin/kernel/nmi.c
@@ -126,7 +126,7 @@ static inline int nmi_wdt_set_timeout(unsigned long t)
max_t = -1 / sclk;
cnt = t * sclk;
if (t > max_t) {
- pr_warning("NMI: timeout value is too large\n");
+ pr_warn("NMI: timeout value is too large\n");
return -EINVAL;
}
diff --git a/arch/blackfin/kernel/ptrace.c b/arch/blackfin/kernel/ptrace.c
index 360d99645163..28dbbaf79896 100644
--- a/arch/blackfin/kernel/ptrace.c
+++ b/arch/blackfin/kernel/ptrace.c
@@ -98,7 +98,7 @@ put_reg(struct task_struct *task, unsigned long regno, unsigned long data)
break;
case PT_SYSCFG: /* don't let userspace screw with this */
if ((data & ~1) != 0x6)
- pr_warning("ptrace: ignore syscfg write of %#lx\n", data);
+ pr_warn("ptrace: ignore syscfg write of %#lx\n", data);
break; /* regs->syscfg = data; break; */
default:
if (regno < sizeof(*regs)) {
diff --git a/arch/blackfin/mach-bf533/boards/stamp.c b/arch/blackfin/mach-bf533/boards/stamp.c
index 23eada79439c..365fed0c7685 100644
--- a/arch/blackfin/mach-bf533/boards/stamp.c
+++ b/arch/blackfin/mach-bf533/boards/stamp.c
@@ -869,7 +869,7 @@ static int __init stamp_init(void)
#endif
if (net2272_init())
- pr_warning("unable to configure net2272; it probably won't work\n");
+ pr_warn("unable to configure net2272; it probably won't work\n");
spi_register_board_info(bfin_spi_board_info, ARRAY_SIZE(bfin_spi_board_info));
return 0;
diff --git a/arch/blackfin/mach-bf537/boards/cm_bf537e.c b/arch/blackfin/mach-bf537/boards/cm_bf537e.c
index 1e1014df5e9e..8c5250da0577 100644
--- a/arch/blackfin/mach-bf537/boards/cm_bf537e.c
+++ b/arch/blackfin/mach-bf537/boards/cm_bf537e.c
@@ -904,7 +904,7 @@ static int __init cm_bf537e_init(void)
#endif
if (net2272_init())
- pr_warning("unable to configure net2272; it probably won't work\n");
+ pr_warn("unable to configure net2272; it probably won't work\n");
return 0;
}
diff --git a/arch/blackfin/mach-bf537/boards/cm_bf537u.c b/arch/blackfin/mach-bf537/boards/cm_bf537u.c
index d056db9e5592..5cb4808a3304 100644
--- a/arch/blackfin/mach-bf537/boards/cm_bf537u.c
+++ b/arch/blackfin/mach-bf537/boards/cm_bf537u.c
@@ -761,7 +761,7 @@ static int __init cm_bf537u_init(void)
#endif
if (net2272_init())
- pr_warning("unable to configure net2272; it probably won't work\n");
+ pr_warn("unable to configure net2272; it probably won't work\n");
return 0;
}
diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
index eaec7b4832a2..f9168094427b 100644
--- a/arch/blackfin/mach-bf537/boards/stamp.c
+++ b/arch/blackfin/mach-bf537/boards/stamp.c
@@ -2964,7 +2964,7 @@ static int __init stamp_init(void)
spi_register_board_info(bfin_spi_board_info, ARRAY_SIZE(bfin_spi_board_info));
if (net2272_init())
- pr_warning("unable to configure net2272; it probably won't work\n");
+ pr_warn("unable to configure net2272; it probably won't work\n");
return 0;
}
diff --git a/arch/blackfin/mach-bf537/boards/tcm_bf537.c b/arch/blackfin/mach-bf537/boards/tcm_bf537.c
index ed309c9a62b6..de4a4d705527 100644
--- a/arch/blackfin/mach-bf537/boards/tcm_bf537.c
+++ b/arch/blackfin/mach-bf537/boards/tcm_bf537.c
@@ -751,7 +751,7 @@ static int __init tcm_bf537_init(void)
#endif
if (net2272_init())
- pr_warning("unable to configure net2272; it probably won't work\n");
+ pr_warn("unable to configure net2272; it probably won't work\n");
return 0;
}
diff --git a/arch/blackfin/mach-bf561/boards/cm_bf561.c b/arch/blackfin/mach-bf561/boards/cm_bf561.c
index 10c57771822d..f95ca2026cc4 100644
--- a/arch/blackfin/mach-bf561/boards/cm_bf561.c
+++ b/arch/blackfin/mach-bf561/boards/cm_bf561.c
@@ -533,7 +533,7 @@ static int __init cm_bf561_init(void)
#endif
if (net2272_init())
- pr_warning("unable to configure net2272; it probably won't work\n");
+ pr_warn("unable to configure net2272; it probably won't work\n");
return 0;
}
diff --git a/arch/blackfin/mach-bf561/boards/ezkit.c b/arch/blackfin/mach-bf561/boards/ezkit.c
index 57d1c43726d9..0c640286c8bd 100644
--- a/arch/blackfin/mach-bf561/boards/ezkit.c
+++ b/arch/blackfin/mach-bf561/boards/ezkit.c
@@ -654,7 +654,7 @@ static int __init ezkit_init(void)
#endif
if (net2272_init())
- pr_warning("unable to configure net2272; it probably won't work\n");
+ pr_warn("unable to configure net2272; it probably won't work\n");
spi_register_board_info(bfin_spi_board_info, ARRAY_SIZE(bfin_spi_board_info));
return 0;
diff --git a/arch/blackfin/mm/isram-driver.c b/arch/blackfin/mm/isram-driver.c
index 7e2e674ed444..020c706fee28 100644
--- a/arch/blackfin/mm/isram-driver.c
+++ b/arch/blackfin/mm/isram-driver.c
@@ -363,7 +363,7 @@ static __init int isram_test_init(void)
break;
}
if (!l1inst) {
- pr_warning("SKIP: could not allocate L1 inst\n");
+ pr_warn("SKIP: could not allocate L1 inst\n");
return 0;
}
pr_info("INFO: testing %#x bytes (%p - %p)\n",
@@ -372,7 +372,7 @@ static __init int isram_test_init(void)
sdram = kmalloc(test_len * 2, GFP_KERNEL);
if (!sdram) {
sram_free(l1inst);
- pr_warning("SKIP: could not allocate sdram\n");
+ pr_warn("SKIP: could not allocate sdram\n");
return 0;
}
--
2.10.0.rc2.1.g053435c
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rafael@kernel.org> |
|---|---|
| Date | 2017-02-17 13:40 +0100 |
| Message-ID | <tbPZn-4hF-5@gated-at.bofh.it> |
| In reply to | #1583158 |
On Fri, Feb 17, 2017 at 8:11 AM, Joe Perches <joe@perches.com> wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate > define pr_warning for that directory tree and pr_warn is > not used in tools/. > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. Sorry about asking if that has been asked already. Wouldn't it be slightly less intrusive to simply redefined pr_warning() as a synonym for pr_warn()? Thanks, Rafael
[toc] | [prev] | [next] | [standalone]
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2017-02-23 16:30 +0100 |
| Message-ID | <te3vb-35q-5@gated-at.bofh.it> |
| In reply to | #1583158 |
On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote: > There are ~4300 uses of pr_warn and ~250 uses of the older > pr_warning in the kernel source tree. > > Make the use of pr_warn consistent across all kernel files. > > This excludes all files in tools/ as there is a separate > define pr_warning for that directory tree and pr_warn is > not used in tools/. > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. > > Miscellanea: > > o Coalesce formats and realign arguments > > Some files not compiled - no cross-compilers > > Joe Perches (35): > alpha: Convert remaining uses of pr_warning to pr_warn > ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn > arm64: Convert remaining uses of pr_warning to pr_warn > arch/blackfin: Convert remaining uses of pr_warning to pr_warn > ia64: Convert remaining use of pr_warning to pr_warn > powerpc: Convert remaining uses of pr_warning to pr_warn > sh: Convert remaining uses of pr_warning to pr_warn > sparc: Convert remaining use of pr_warning to pr_warn > x86: Convert remaining uses of pr_warning to pr_warn > drivers/acpi: Convert remaining uses of pr_warning to pr_warn > block/drbd: Convert remaining uses of pr_warning to pr_warn > gdrom: Convert remaining uses of pr_warning to pr_warn > drivers/char: Convert remaining use of pr_warning to pr_warn > clocksource: Convert remaining use of pr_warning to pr_warn > drivers/crypto: Convert remaining uses of pr_warning to pr_warn > fmc: Convert remaining use of pr_warning to pr_warn > drivers/gpu: Convert remaining uses of pr_warning to pr_warn > drivers/ide: Convert remaining uses of pr_warning to pr_warn > drivers/input: Convert remaining uses of pr_warning to pr_warn > drivers/isdn: Convert remaining uses of pr_warning to pr_warn > drivers/macintosh: Convert remaining uses of pr_warning to pr_warn > drivers/media: Convert remaining use of pr_warning to pr_warn > drivers/mfd: Convert remaining uses of pr_warning to pr_warn > drivers/mtd: Convert remaining uses of pr_warning to pr_warn > drivers/of: Convert remaining uses of pr_warning to pr_warn > drivers/oprofile: Convert remaining uses of pr_warning to pr_warn > drivers/platform: Convert remaining uses of pr_warning to pr_warn > drivers/rapidio: Convert remaining use of pr_warning to pr_warn > drivers/scsi: Convert remaining use of pr_warning to pr_warn > drivers/sh: Convert remaining use of pr_warning to pr_warn > drivers/tty: Convert remaining uses of pr_warning to pr_warn > drivers/video: Convert remaining uses of pr_warning to pr_warn > kernel/trace: Convert remaining uses of pr_warning to pr_warn > lib: Convert remaining uses of pr_warning to pr_warn > sound/soc: Convert remaining uses of pr_warning to pr_warn Where's the removal of pr_warning so we don't have more sneak in? Rob
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-23 18:30 +0100 |
| Subject | Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn |
| Message-ID | <te5nk-4nQ-31@gated-at.bofh.it> |
| In reply to | #1586955 |
On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote: > > There are ~4300 uses of pr_warn and ~250 uses of the older > > pr_warning in the kernel source tree. > > > > Make the use of pr_warn consistent across all kernel files. > > > > This excludes all files in tools/ as there is a separate > > define pr_warning for that directory tree and pr_warn is > > not used in tools/. > > > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. [] > Where's the removal of pr_warning so we don't have more sneak in? After all of these actually get applied, and maybe a cycle or two later, one would get sent.
[toc] | [prev] | [next] | [standalone]
| From | Emil Velikov <emil.l.velikov@gmail.com> |
|---|---|
| Date | 2017-02-23 18:50 +0100 |
| Message-ID | <te5GF-4ww-5@gated-at.bofh.it> |
| In reply to | #1587040 |
On 23 February 2017 at 17:18, Joe Perches <joe@perches.com> wrote: > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: >> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote: >> > There are ~4300 uses of pr_warn and ~250 uses of the older >> > pr_warning in the kernel source tree. >> > >> > Make the use of pr_warn consistent across all kernel files. >> > >> > This excludes all files in tools/ as there is a separate >> > define pr_warning for that directory tree and pr_warn is >> > not used in tools/. >> > >> > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. > [] >> Where's the removal of pr_warning so we don't have more sneak in? > > After all of these actually get applied, > and maybe a cycle or two later, one would > get sent. > By which point you'll get a few reincarnation of it. So you'll have to do the same exercise again :-( I guess the question is - are you expecting to get the series merged all together/via one tree ? If not, your plan is perfectly reasonable. Fwiw in the DRM subsystem, similar cleanups does purge the respective macros/other with the final commit. But there one can pull the lot in one go. Regards, Emil
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-23 19:00 +0100 |
| Subject | Re: [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn |
| Message-ID | <te5Qm-4zQ-29@gated-at.bofh.it> |
| In reply to | #1587047 |
On Thu, 2017-02-23 at 17:41 +0000, Emil Velikov wrote: > On 23 February 2017 at 17:18, Joe Perches <joe@perches.com> wrote: > > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote: > > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <joe@perches.com> wrote: > > > > There are ~4300 uses of pr_warn and ~250 uses of the older > > > > pr_warning in the kernel source tree. > > > > > > > > Make the use of pr_warn consistent across all kernel files. > > > > > > > > This excludes all files in tools/ as there is a separate > > > > define pr_warning for that directory tree and pr_warn is > > > > not used in tools/. > > > > > > > > Done with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing. > > > > [] > > > Where's the removal of pr_warning so we don't have more sneak in? > > > > After all of these actually get applied, > > and maybe a cycle or two later, one would > > get sent. > > > > By which point you'll get a few reincarnation of it. So you'll have to > do the same exercise again :-( Maybe to one or two files. Not a big deal. > I guess the question is - are you expecting to get the series merged > all together/via one tree ? No. The only person that could do that effectively is Linus. > If not, your plan is perfectly reasonable.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web