Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586589 > unrolled thread

[PATCH] uapi: fix linux/rds.h userspace compilation errors

Started by"Dmitry V. Levin" <ldv@altlinux.org>
First post2017-02-23 02:20 +0100
Last post2017-02-23 17:00 +0100
Articles 5 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] uapi: fix linux/rds.h userspace compilation errors "Dmitry V. Levin" <ldv@altlinux.org> - 2017-02-23 02:20 +0100
    Re: [PATCH] uapi: fix linux/rds.h userspace compilation errors Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-02-23 02:50 +0100
    Re: [PATCH] uapi: fix linux/rds.h userspace compilation errors Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-02-23 12:30 +0100
      [PATCH v2] uapi: fix linux/rds.h userspace compilation errors "Dmitry V. Levin" <ldv@altlinux.org> - 2017-02-23 12:40 +0100
        Re: [PATCH v2] uapi: fix linux/rds.h userspace compilation errors David Miller <davem@davemloft.net> - 2017-02-23 17:00 +0100

#1586589 — [PATCH] uapi: fix linux/rds.h userspace compilation errors

From"Dmitry V. Levin" <ldv@altlinux.org>
Date2017-02-23 02:20 +0100
Subject[PATCH] uapi: fix linux/rds.h userspace compilation errors
Message-ID<tdQeB-27X-3@gated-at.bofh.it>
Consistently use types from linux/types.h to fix the following
linux/rds.h userspace compilation errors:

/usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
  u8 rx_traces;
/usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
  u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
/usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
  u8 rx_traces;
/usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
  u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
/usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
  u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];

Fixes: 3289025a("RDS: add receive message trace used by application")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
 include/uapi/linux/rds.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
index 47c03ca..198892b 100644
--- a/include/uapi/linux/rds.h
+++ b/include/uapi/linux/rds.h
@@ -195,14 +195,14 @@ enum rds_message_rxpath_latency {
 };
 
 struct rds_rx_trace_so {
-	u8 rx_traces;
-	u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
+	__u8 rx_traces;
+	__u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
 };
 
 struct rds_cmsg_rx_trace {
-	u8 rx_traces;
-	u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
-	u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
+	__u8 rx_traces;
+	__u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
+	__u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
 };
 
 /*
-- 
ldv

[toc] | [next] | [standalone]

#1586600

FromSantosh Shilimkar <santosh.shilimkar@oracle.com>
Date2017-02-23 02:50 +0100
Message-ID<tdQHD-2lQ-3@gated-at.bofh.it>
In reply to#1586589
On 2/22/2017 5:13 PM, Dmitry V. Levin wrote:
> Consistently use types from linux/types.h to fix the following
> linux/rds.h userspace compilation errors:
>
> /usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
>   u8 rx_traces;
> /usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
>   u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
>   u8 rx_traces;
> /usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
>   u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
>   u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
>
> Fixes: 3289025a("RDS: add receive message trace used by application")
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
This was part of the patch I submitted other-day with
rest of the clean-up. Thanks Dmitry.

Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

[toc] | [prev] | [next] | [standalone]

#1586828

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2017-02-23 12:30 +0100
Message-ID<tdZKW-Bp-17@gated-at.bofh.it>
In reply to#1586589
Hello!

On 2/23/2017 4:13 AM, Dmitry V. Levin wrote:

> Consistently use types from linux/types.h to fix the following
> linux/rds.h userspace compilation errors:
>
> /usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
>   u8 rx_traces;
> /usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
>   u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
>   u8 rx_traces;
> /usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
>   u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
>   u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
>
> Fixes: 3289025a("RDS: add receive message trace used by application")

    Need at least 12 hex digits and a space before (.

> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
[...]

MBR, Sergei

[toc] | [prev] | [next] | [standalone]

#1586835 — [PATCH v2] uapi: fix linux/rds.h userspace compilation errors

From"Dmitry V. Levin" <ldv@altlinux.org>
Date2017-02-23 12:40 +0100
Subject[PATCH v2] uapi: fix linux/rds.h userspace compilation errors
Message-ID<tdZUC-Ex-23@gated-at.bofh.it>
In reply to#1586828
Consistently use types from linux/types.h to fix the following
linux/rds.h userspace compilation errors:

/usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
  u8 rx_traces;
/usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
  u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
/usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
  u8 rx_traces;
/usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
  u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
/usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
  u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];

Fixes: 3289025aedc0 ("RDS: add receive message trace used by application")
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
---
v2: fixed "Fixes:" line

 include/uapi/linux/rds.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
index 47c03ca..198892b 100644
--- a/include/uapi/linux/rds.h
+++ b/include/uapi/linux/rds.h
@@ -195,14 +195,14 @@ enum rds_message_rxpath_latency {
 };
 
 struct rds_rx_trace_so {
-	u8 rx_traces;
-	u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
+	__u8 rx_traces;
+	__u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
 };
 
 struct rds_cmsg_rx_trace {
-	u8 rx_traces;
-	u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
-	u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
+	__u8 rx_traces;
+	__u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
+	__u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
 };
 
 /*
-- 
ldv

[toc] | [prev] | [next] | [standalone]

#1586974 — Re: [PATCH v2] uapi: fix linux/rds.h userspace compilation errors

FromDavid Miller <davem@davemloft.net>
Date2017-02-23 17:00 +0100
SubjectRe: [PATCH v2] uapi: fix linux/rds.h userspace compilation errors
Message-ID<te3Yd-3fj-3@gated-at.bofh.it>
In reply to#1586835
From: "Dmitry V. Levin" <ldv@altlinux.org>
Date: Thu, 23 Feb 2017 14:35:23 +0300

> Consistently use types from linux/types.h to fix the following
> linux/rds.h userspace compilation errors:
> 
> /usr/include/linux/rds.h:198:2: error: unknown type name 'u8'
>   u8 rx_traces;
> /usr/include/linux/rds.h:199:2: error: unknown type name 'u8'
>   u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:203:2: error: unknown type name 'u8'
>   u8 rx_traces;
> /usr/include/linux/rds.h:204:2: error: unknown type name 'u8'
>   u8 rx_trace_pos[RDS_MSG_RX_DGRAM_TRACE_MAX];
> /usr/include/linux/rds.h:205:2: error: unknown type name 'u64'
>   u64 rx_trace[RDS_MSG_RX_DGRAM_TRACE_MAX];
> 
> Fixes: 3289025aedc0 ("RDS: add receive message trace used by application")
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
> ---
> v2: fixed "Fixes:" line

Applied.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web