Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1585882 > unrolled thread
| Started by | Andreas Färber <afaerber@suse.de> |
|---|---|
| First post | 2017-02-22 03:40 +0100 |
| Last post | 2017-02-23 15:50 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 Andreas Färber <afaerber@suse.de> - 2017-02-22 03:40 +0100
Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 Mark Brown <broonie@kernel.org> - 2017-02-22 19:50 +0100
Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 Andreas Färber <afaerber@suse.de> - 2017-02-23 15:20 +0100
Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 Takashi Iwai <tiwai@suse.de> - 2017-02-23 15:30 +0100
Re: [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 Andreas Färber <afaerber@suse.de> - 2017-02-23 15:50 +0100
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2017-02-22 03:40 +0100 |
| Subject | [PATCH v2 4/8] sound: soc: pxa: Suppress SND_MMP_SOC for arm64 |
| Message-ID | <tdv0u-2Z7-13@gated-at.bofh.it> |
SND_MMP_SOC selects SND_ARM, which is limited to ARM, as well as MMP_SRAM, which is a non-DT driver in arch/arm/mach-arm/. Avoid Kconfig warnings by not making this driver available on ARM64. While at it, tidy the title (Soc -> SoC). Signed-off-by: Andreas Färber <afaerber@suse.de> --- v2: new sound/soc/pxa/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig index 823b5a2..f8e1c06 100644 --- a/sound/soc/pxa/Kconfig +++ b/sound/soc/pxa/Kconfig @@ -8,8 +8,8 @@ config SND_PXA2XX_SOC to select the audio interfaces to support below. config SND_MMP_SOC - bool "Soc Audio for Marvell MMP chips" - depends on ARCH_MMP + bool "SoC Audio for Marvell MMP chips" + depends on ARCH_MMP && ARM select MMP_SRAM select SND_SOC_GENERIC_DMAENGINE_PCM select SND_ARM -- 2.10.2
[toc] | [next] | [standalone]
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2017-02-22 19:50 +0100 |
| Message-ID | <tdK9c-5W6-27@gated-at.bofh.it> |
| In reply to | #1585882 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, Feb 22, 2017 at 03:29:24AM +0100, Andreas Färber wrote: This is patch 4 of 8, what's going on with dependencies here? Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches. > config SND_MMP_SOC > - bool "Soc Audio for Marvell MMP chips" > - depends on ARCH_MMP > + bool "SoC Audio for Marvell MMP chips" > + depends on ARCH_MMP && ARM There are no obvious build time architecture dependencies for this driver, shouldn't we have an || COMPILE_TEST in here?
[toc] | [prev] | [next] | [standalone]
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2017-02-23 15:20 +0100 |
| Message-ID | <te2pr-2oI-3@gated-at.bofh.it> |
| In reply to | #1586405 |
Am 22.02.2017 um 19:47 schrieb Mark Brown: > On Wed, Feb 22, 2017 at 03:29:24AM +0100, Andreas Färber wrote: > > This is patch 4 of 8, what's going on with dependencies here? No dependencies on previous patches. 5/8 adds ARCH_MMP to arm64. It compiled without this (just Kconfig warnings), so this could go through the appropriate sound tree as a cleanup. > Please use subject lines matching the style for the subsystem. This > makes it easier for people to identify relevant patches. Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM, which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC can be found in "ALSA for SoC audio support" section.', which confused me about whether or not this is an ASoC compliant driver if it selects a non-ASoC symbol. >> config SND_MMP_SOC >> - bool "Soc Audio for Marvell MMP chips" >> - depends on ARCH_MMP >> + bool "SoC Audio for Marvell MMP chips" >> + depends on ARCH_MMP && ARM > > There are no obvious build time architecture dependencies for this > driver, shouldn't we have an || COMPILE_TEST in here? I'm the wrong person to answer that - the symbol relies on architecture-specific SND_ARM, and my understanding was that the code still relies on platform data, therefore it did not seem worthwhile to just disable inapplicable dependencies such as MMP_SRAM (arch/arm/mach-mmp/; superseded by DT mmio-sram) or SND_ARM. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
[toc] | [prev] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2017-02-23 15:30 +0100 |
| Message-ID | <te2z7-2s9-3@gated-at.bofh.it> |
| In reply to | #1586909 |
On Thu, 23 Feb 2017 15:11:46 +0100, Andreas Färber wrote: > > Am 22.02.2017 um 19:47 schrieb Mark Brown: > > On Wed, Feb 22, 2017 at 03:29:24AM +0100, Andreas Färber wrote: > > > > This is patch 4 of 8, what's going on with dependencies here? > > No dependencies on previous patches. 5/8 adds ARCH_MMP to arm64. > > It compiled without this (just Kconfig warnings), so this could go > through the appropriate sound tree as a cleanup. > > > Please use subject lines matching the style for the subsystem. This > > makes it easier for people to identify relevant patches. > > Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM, > which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC > can be found in "ALSA for SoC audio support" section.', which confused > me about whether or not this is an ASoC compliant driver if it selects a > non-ASoC symbol. It's a bug that selects SND_ARM there. I guess this was wrongly taken from the old example of AC97 ARM SoC code, which was fixed later. ASoC stuff is basically irrelevant from the legacy sound/arm/*. thanks, Takashi
[toc] | [prev] | [next] | [standalone]
| From | Andreas Färber <afaerber@suse.de> |
|---|---|
| Date | 2017-02-23 15:50 +0100 |
| Message-ID | <te2St-2AJ-1@gated-at.bofh.it> |
| In reply to | #1586914 |
Am 23.02.2017 um 15:24 schrieb Takashi Iwai:
> On Thu, 23 Feb 2017 15:11:46 +0100,
> Andreas Färber wrote:
>> Am 22.02.2017 um 19:47 schrieb Mark Brown:
>>> Please use subject lines matching the style for the subsystem. This
>>> makes it easier for people to identify relevant patches.
>>
>> Should I make it "ASoC: pxa: ..." then? SND_MMP_SOC selects SND_ARM,
>> which in sound/arm/Kconfig says 'Drivers that are implemented on ASoC
>> can be found in "ALSA for SoC audio support" section.', which confused
>> me about whether or not this is an ASoC compliant driver if it selects a
>> non-ASoC symbol.
>
> It's a bug that selects SND_ARM there. I guess this was wrongly taken
> from the old example of AC97 ARM SoC code, which was fixed later.
> ASoC stuff is basically irrelevant from the legacy sound/arm/*.
Thanks, Takashi-san. I'll update as follows then.
diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig
index f8e1c06..aba7213 100644
--- a/sound/soc/pxa/Kconfig
+++ b/sound/soc/pxa/Kconfig
@@ -9,10 +9,9 @@ config SND_PXA2XX_SOC
config SND_MMP_SOC
bool "SoC Audio for Marvell MMP chips"
- depends on ARCH_MMP && ARM
- select MMP_SRAM
+ depends on ARCH_MMP || COMPILE_TEST
+ select MMP_SRAM if ARM
select SND_SOC_GENERIC_DMAENGINE_PCM
- select SND_ARM
help
Say Y if you want to add support for codecs attached to
the MMP SSPA interface.
Okay to do that in one patch or break up into three?
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web