Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586505 > unrolled thread
| Started by | Lyude <lyude@redhat.com> |
|---|---|
| First post | 2017-02-22 22:40 +0100 |
| Last post | 2017-02-23 15:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drm/radeon/dp_auxch: Ratelimit aux transfer debug messages Lyude <lyude@redhat.com> - 2017-02-22 22:40 +0100
Re: [PATCH] drm/radeon/dp_auxch: Ratelimit aux transfer debug messages Alex Deucher <alexdeucher@gmail.com> - 2017-02-23 15:40 +0100
| From | Lyude <lyude@redhat.com> |
|---|---|
| Date | 2017-02-22 22:40 +0100 |
| Subject | [PATCH] drm/radeon/dp_auxch: Ratelimit aux transfer debug messages |
| Message-ID | <tdMNH-7UO-13@gated-at.bofh.it> |
Aux transfers always fail with non-zero status flags when there's
nothing connected on the port, so we don't usually need to see all of
the debugging information from it. Also, we try reprobing a -lot-, so
without ratelimiting most of the kernel log is filled up with messages
from radeon_dp_aux_transfer_native.
Signed-off-by: Lyude <lyude@redhat.com>
---
drivers/gpu/drm/radeon/radeon_dp_auxch.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_dp_auxch.c b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
index 474a8a18..12eac4e 100644
--- a/drivers/gpu/drm/radeon/radeon_dp_auxch.c
+++ b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
@@ -168,7 +168,8 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
goto done;
}
if (tmp & AUX_RX_ERROR_FLAGS) {
- DRM_DEBUG_KMS("dp_aux_ch flags not zero: %08x\n", tmp);
+ DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch flags not zero: %08x\n",
+ tmp);
ret = -EIO;
goto done;
}
--
2.9.3
[toc] | [next] | [standalone]
| From | Alex Deucher <alexdeucher@gmail.com> |
|---|---|
| Date | 2017-02-23 15:40 +0100 |
| Message-ID | <te2IO-2vk-7@gated-at.bofh.it> |
| In reply to | #1586505 |
On Wed, Feb 22, 2017 at 4:34 PM, Lyude <lyude@redhat.com> wrote:
> Aux transfers always fail with non-zero status flags when there's
> nothing connected on the port, so we don't usually need to see all of
> the debugging information from it. Also, we try reprobing a -lot-, so
> without ratelimiting most of the kernel log is filled up with messages
> from radeon_dp_aux_transfer_native.
>
> Signed-off-by: Lyude <lyude@redhat.com>
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/radeon/radeon_dp_auxch.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_dp_auxch.c b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
> index 474a8a18..12eac4e 100644
> --- a/drivers/gpu/drm/radeon/radeon_dp_auxch.c
> +++ b/drivers/gpu/drm/radeon/radeon_dp_auxch.c
> @@ -168,7 +168,8 @@ radeon_dp_aux_transfer_native(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg
> goto done;
> }
> if (tmp & AUX_RX_ERROR_FLAGS) {
> - DRM_DEBUG_KMS("dp_aux_ch flags not zero: %08x\n", tmp);
> + DRM_DEBUG_KMS_RATELIMITED("dp_aux_ch flags not zero: %08x\n",
> + tmp);
> ret = -EIO;
> goto done;
> }
> --
> 2.9.3
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web