Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1585948 > unrolled thread
| Started by | "Tobin C. Harding" <me@tobin.cc> |
|---|---|
| First post | 2017-02-22 07:40 +0100 |
| Last post | 2017-02-22 10:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] fs/9p: Remove cast from memory allocation "Tobin C. Harding" <me@tobin.cc> - 2017-02-22 07:40 +0100
Re: [V9fs-developer] [PATCH] fs/9p: Remove cast from memory allocation Greg Kurz <groug@kaod.org> - 2017-02-22 10:30 +0100
| From | "Tobin C. Harding" <me@tobin.cc> |
|---|---|
| Date | 2017-02-22 07:40 +0100 |
| Subject | [PATCH] fs/9p: Remove cast from memory allocation |
| Message-ID | <tdyKK-5Ut-13@gated-at.bofh.it> |
Coccinelle emits WARNING: casting value returned by memory allocation
function to (struct v9fs_inode *) is useless.
Remove unnecessary cast.
Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
fs/9p/vfs_inode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index f4f4450..462e9e4 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -238,8 +238,7 @@ v9fs_blank_wstat(struct p9_wstat *wstat)
struct inode *v9fs_alloc_inode(struct super_block *sb)
{
struct v9fs_inode *v9inode;
- v9inode = (struct v9fs_inode *)kmem_cache_alloc(v9fs_inode_cache,
- GFP_KERNEL);
+ v9inode = kmem_cache_alloc(v9fs_inode_cache, GFP_KERNEL);
if (!v9inode)
return NULL;
#ifdef CONFIG_9P_FSCACHE
--
2.7.4
[toc] | [next] | [standalone]
| From | Greg Kurz <groug@kaod.org> |
|---|---|
| Date | 2017-02-22 10:30 +0100 |
| Subject | Re: [V9fs-developer] [PATCH] fs/9p: Remove cast from memory allocation |
| Message-ID | <tdBpf-7UW-7@gated-at.bofh.it> |
| In reply to | #1585948 |
[Multipart message — attachments visible in raw view] — view raw
On Wed, 22 Feb 2017 17:34:13 +1100
"Tobin C. Harding" <me@tobin.cc> wrote:
> Coccinelle emits WARNING: casting value returned by memory allocation
> function to (struct v9fs_inode *) is useless.
>
> Remove unnecessary cast.
>
> Signed-off-by: Tobin C. Harding <me@tobin.cc>
> ---
Reviewed-by: Greg Kurz <groug@kaod.org>
> fs/9p/vfs_inode.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index f4f4450..462e9e4 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -238,8 +238,7 @@ v9fs_blank_wstat(struct p9_wstat *wstat)
> struct inode *v9fs_alloc_inode(struct super_block *sb)
> {
> struct v9fs_inode *v9inode;
> - v9inode = (struct v9fs_inode *)kmem_cache_alloc(v9fs_inode_cache,
> - GFP_KERNEL);
> + v9inode = kmem_cache_alloc(v9fs_inode_cache, GFP_KERNEL);
> if (!v9inode)
> return NULL;
> #ifdef CONFIG_9P_FSCACHE
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web