Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1581796 > unrolled thread

Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

Started byRob Herring <robh@kernel.org>
First post2017-02-16 00:10 +0100
Last post2017-02-21 15:50 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller Rob Herring <robh@kernel.org> - 2017-02-16 00:10 +0100
    Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host  controller Hans Ulli Kroll <ulli.kroll@googlemail.com> - 2017-02-17 11:20 +0100
      Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller Rob Herring <robh@kernel.org> - 2017-02-21 15:50 +0100

#1581796 — Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

FromRob Herring <robh@kernel.org>
Date2017-02-16 00:10 +0100
SubjectRe: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller
Message-ID<tbgRZ-6hT-73@gated-at.bofh.it>
On Wed, Feb 08, 2017 at 09:00:09PM +0100, Hans Ulli Kroll wrote:
> This adds DT bindings for the Faraday FOTG2 host controller.
> 
> Signed-off-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
> ---
>  Documentation/devicetree/bindings/usb/fotg2-host.txt | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/fotg2-host.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/fotg2-host.txt b/Documentation/devicetree/bindings/usb/fotg2-host.txt
> new file mode 100644
> index 000000000000..4c07566a4bf5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/fotg2-host.txt
> @@ -0,0 +1,15 @@
> +Faraday FOTG Host controller
> +
> +Required properties:
> +
> +- compatible: should be "faraday,fotg210-hcd"

hcd as in "host controller driver"? Bindings describe h/w not drivers.

It's an OTG controller or host controller?

> +- reg: should contain one register range i.e. start and length
> +- interrupts: description of the interrupt line
> +
> +Example for Gemini:
> +
> +usb@68000000 {
> +	compatible = "faraday,fotg210-hcd";
> +	reg = <0x68000000 0x1000>;
> +	interrupts = <10 IRQ_TYPE_LEVEL_HIGH>;
> +};
> -- 
> 2.11.0
> 

[toc] | [next] | [standalone]


#1583292 — Re: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller

FromHans Ulli Kroll <ulli.kroll@googlemail.com>
Date2017-02-17 11:20 +0100
SubjectRe: [PATCH 2/3] usb: add DT bindings for farady fotg2 host controller
Message-ID<tbNNT-30z-9@gated-at.bofh.it>
In reply to#1581796
Hi Rob,

On Wed, 15 Feb 2017, Rob Herring wrote:

> On Wed, Feb 08, 2017 at 09:00:09PM +0100, Hans Ulli Kroll wrote:
> > This adds DT bindings for the Faraday FOTG2 host controller.
> > 
> > Signed-off-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
> > ---
> >  Documentation/devicetree/bindings/usb/fotg2-host.txt | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/usb/fotg2-host.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/fotg2-host.txt b/Documentation/devicetree/bindings/usb/fotg2-host.txt
> > new file mode 100644
> > index 000000000000..4c07566a4bf5
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/fotg2-host.txt
> > @@ -0,0 +1,15 @@
> > +Faraday FOTG Host controller
> > +
> > +Required properties:
> > +
> > +- compatible: should be "faraday,fotg210-hcd"
> 
> hcd as in "host controller driver"? Bindings describe h/w not drivers.
> 
> It's an OTG controller or host controller?
> 

here only the host controller part used.

faraday fotg2 is a dual role hcd/otg device and here is only the 
host part used.

Greetings
ans Ulli Kroll

[toc] | [prev] | [next] | [standalone]


#1585393

FromRob Herring <robh@kernel.org>
Date2017-02-21 15:50 +0100
Message-ID<tdjVo-3Sp-19@gated-at.bofh.it>
In reply to#1583292
On Fri, Feb 17, 2017 at 4:07 AM, Hans Ulli Kroll
<ulli.kroll@googlemail.com> wrote:
> Hi Rob,
>
> On Wed, 15 Feb 2017, Rob Herring wrote:
>
>> On Wed, Feb 08, 2017 at 09:00:09PM +0100, Hans Ulli Kroll wrote:
>> > This adds DT bindings for the Faraday FOTG2 host controller.
>> >
>> > Signed-off-by: Hans Ulli Kroll <ulli.kroll@googlemail.com>
>> > ---
>> >  Documentation/devicetree/bindings/usb/fotg2-host.txt | 15 +++++++++++++++
>> >  1 file changed, 15 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/usb/fotg2-host.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/usb/fotg2-host.txt b/Documentation/devicetree/bindings/usb/fotg2-host.txt
>> > new file mode 100644
>> > index 000000000000..4c07566a4bf5
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/usb/fotg2-host.txt
>> > @@ -0,0 +1,15 @@
>> > +Faraday FOTG Host controller
>> > +
>> > +Required properties:
>> > +
>> > +- compatible: should be "faraday,fotg210-hcd"
>>
>> hcd as in "host controller driver"? Bindings describe h/w not drivers.
>>
>> It's an OTG controller or host controller?
>>
>
> here only the host controller part used.
>
> faraday fotg2 is a dual role hcd/otg device and here is only the
> host part used.

Because you don't care about device mode or restricted by the IP
configuration or SoC integration? The former is a user choice and
shouldn't be part of DT. The latter should be implied by an SoC
specific compatible string. Using only a compatible string for a
licensed IP is not specific enough as vendors use differing versions
and integrate them in different ways.

Rob

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web