Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1585054 > unrolled thread

[PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

Back to article view | Back to linux.kernel

Contents

  [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in  img_ascii_lcd_matches Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-21 06:40 +0100
    Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches Paul Burton <paul.burton@imgtec.com> - 2017-02-24 23:00 +0100

#1585054 — [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

The OF device table must be terminated, otherwise we'll be walking past
it and into areas unknown.

This causes KASAN errors reported by 0day kernel testing robot.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Tested-by: Fengguang Wu <fengguang.wu@intel.com>
Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII...")
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/auxdisplay/img-ascii-lcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/img-ascii-lcd.c b/drivers/auxdisplay/img-ascii-lcd.c
index bf43b5d2aafc..83f1439e57fd 100644
--- a/drivers/auxdisplay/img-ascii-lcd.c
+++ b/drivers/auxdisplay/img-ascii-lcd.c
@@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[] = {
 	{ .compatible = "img,boston-lcd", .data = &boston_config },
 	{ .compatible = "mti,malta-lcd", .data = &malta_config },
 	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
+	{ /* sentinel */ }
 };
 
 /**
-- 
2.11.0.483.g087da7b7c-goog


-- 
Dmitry

[toc] | [next] | [standalone]

#1587969 — Re: [PATCH] auxdisplay: img-ascii-lcd: add missing sentinel entry in img_ascii_lcd_matches

[Multipart message — attachments visible in raw view] — view raw

Hi Dmitry,

On Monday, 20 February 2017 21:39:11 PST Dmitry Torokhov wrote:
> The OF device table must be terminated, otherwise we'll be walking past
> it and into areas unknown.
> 
> This causes KASAN errors reported by 0day kernel testing robot.
> 
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Tested-by: Fengguang Wu <fengguang.wu@intel.com>
> Fixes: 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple
> ASCII...") Cc: stable@vger.kernel.org
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

An essentially identical patch was already submitted over here:

https://patchwork.kernel.org/patch/9493973/

I'm not sure how it ought to get into mainline - since the driver went through 
the MIPS tree perhaps this fix can too?

Thanks,
    Paul

> ---
>  drivers/auxdisplay/img-ascii-lcd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/auxdisplay/img-ascii-lcd.c
> b/drivers/auxdisplay/img-ascii-lcd.c index bf43b5d2aafc..83f1439e57fd
> 100644
> --- a/drivers/auxdisplay/img-ascii-lcd.c
> +++ b/drivers/auxdisplay/img-ascii-lcd.c
> @@ -218,6 +218,7 @@ static const struct of_device_id img_ascii_lcd_matches[]
> = { { .compatible = "img,boston-lcd", .data = &boston_config },
>  	{ .compatible = "mti,malta-lcd", .data = &malta_config },
>  	{ .compatible = "mti,sead3-lcd", .data = &sead3_config },
> +	{ /* sentinel */ }
>  };
> 
>  /**

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web