Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1586732 > unrolled thread

[PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller

Started byClaudiu Beznea <claudiu.beznea@microchip.com>
First post2017-02-23 09:40 +0100
Last post2017-02-23 09:50 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller Claudiu Beznea <claudiu.beznea@microchip.com> - 2017-02-23 09:40 +0100
    Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-23 09:50 +0100
      Re: [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller m18063 <Claudiu.Beznea@microchip.com> - 2017-02-23 09:50 +0100

#1586732 — [PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller

FromClaudiu Beznea <claudiu.beznea@microchip.com>
Date2017-02-23 09:40 +0100
Subject[PATCH] ATM: dts: at91: sama5d2_xplained: add pwm controller
Message-ID<tdX6p-7c9-1@gated-at.bofh.it>
Add pwm controller bindings for sam5d2_xplained
and enable it.

Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++
 arch/arm/boot/dts/sama5d2.dtsi                      | 8 ++++++++
 2 files changed, 12 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
index 9fc270f..493ea29 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
@@ -318,6 +318,10 @@
 				};
 			};
 
+			pwm0: pwm@f802c000 {
+				status = "okay";
+			};
+
 			flx0: flexcom@f8034000 {
 				atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
 				status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */
diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index cd459e8..e88785e 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -1098,6 +1098,14 @@
 				status = "disabled";
 			};
 
+			pwm0: pwm@f802c000 {
+				compatible = "atmel,sama5d2-pwm";
+				reg = <0xf802c000 0x4000>;
+				interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>;
+				#pwm-cells = <3>;
+				clocks = <&pwm_clk>;
+			};
+
 			sfr: sfr@f8030000 {
 				compatible = "atmel,sama5d2-sfr", "syscon";
 				reg = <0xf8030000 0x98>;
-- 
2.7.4

[toc] | [next] | [standalone]


#1586739

FromAlexandre Belloni <alexandre.belloni@free-electrons.com>
Date2017-02-23 09:50 +0100
Message-ID<tdXg6-7i8-13@gated-at.bofh.it>
In reply to#1586732
Hi,

There is a typo in your subject, please fix.

On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote:
> Add pwm controller bindings for sam5d2_xplained
> and enable it.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
>  arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++
>  arch/arm/boot/dts/sama5d2.dtsi                      | 8 ++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
> index 9fc270f..493ea29 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
> @@ -318,6 +318,10 @@
>  				};
>  			};
>  
> +			pwm0: pwm@f802c000 {
> +				status = "okay";
> +			};
> +
>  			flx0: flexcom@f8034000 {
>  				atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
>  				status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index cd459e8..e88785e 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -1098,6 +1098,14 @@
>  				status = "disabled";
>  			};
>  
> +			pwm0: pwm@f802c000 {
> +				compatible = "atmel,sama5d2-pwm";

This compatible is not documented and is not used in any driver. Is that
really working?

> +				reg = <0xf802c000 0x4000>;
> +				interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>;
> +				#pwm-cells = <3>;
> +				clocks = <&pwm_clk>;
> +			};
> +
>  			sfr: sfr@f8030000 {
>  				compatible = "atmel,sama5d2-sfr", "syscon";
>  				reg = <0xf8030000 0x98>;
> -- 
> 2.7.4
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[toc] | [prev] | [next] | [standalone]


#1586748

Fromm18063 <Claudiu.Beznea@microchip.com>
Date2017-02-23 09:50 +0100
Message-ID<tdXg6-7i8-23@gated-at.bofh.it>
In reply to#1586739
Hi,

I will correct it asap.

Thank you,
Claudiu Beznea

On 23.02.2017 10:42, Alexandre Belloni wrote:
> Hi,
>
> There is a typo in your subject, please fix.
>
> On 23/02/2017 at 10:32:58 +0200, Claudiu Beznea wrote:
>> Add pwm controller bindings for sam5d2_xplained
>> and enable it.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> ---
>>  arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi | 4 ++++
>>  arch/arm/boot/dts/sama5d2.dtsi                      | 8 ++++++++
>>  2 files changed, 12 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
>> index 9fc270f..493ea29 100644
>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained_common.dtsi
>> @@ -318,6 +318,10 @@
>>  				};
>>  			};
>>  
>> +			pwm0: pwm@f802c000 {
>> +				status = "okay";
>> +			};
>> +
>>  			flx0: flexcom@f8034000 {
>>  				atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
>>  				status = "disabled"; /* conflict with ISC_D2 & ISC_D3 data pins */
>> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
>> index cd459e8..e88785e 100644
>> --- a/arch/arm/boot/dts/sama5d2.dtsi
>> +++ b/arch/arm/boot/dts/sama5d2.dtsi
>> @@ -1098,6 +1098,14 @@
>>  				status = "disabled";
>>  			};
>>  
>> +			pwm0: pwm@f802c000 {
>> +				compatible = "atmel,sama5d2-pwm";
> This compatible is not documented and is not used in any driver. Is that
> really working?
>
>> +				reg = <0xf802c000 0x4000>;
>> +				interrupts = <38 IRQ_TYPE_LEVEL_HIGH 7>;
>> +				#pwm-cells = <3>;
>> +				clocks = <&pwm_clk>;
>> +			};
>> +
>>  			sfr: sfr@f8030000 {
>>  				compatible = "atmel,sama5d2-sfr", "syscon";
>>  				reg = <0xf8030000 0x98>;
>> -- 
>> 2.7.4
>>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web