Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586377 > unrolled thread
| Started by | Georgios Emmanouil <geo.emmnl@gmail.com> |
|---|---|
| First post | 2017-02-22 19:30 +0100 |
| Last post | 2017-02-24 17:40 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement Georgios Emmanouil <geo.emmnl@gmail.com> - 2017-02-22 19:30 +0100
[PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement Georgios Emmanouil <geo.emmnl@gmail.com> - 2017-02-22 19:40 +0100
Re: [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 17:40 +0100
Re: [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 17:40 +0100
| From | Georgios Emmanouil <geo.emmnl@gmail.com> |
|---|---|
| Date | 2017-02-22 19:30 +0100 |
| Subject | [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement |
| Message-ID | <tdJPP-5LC-1@gated-at.bofh.it> |
Coding style issue. Added brances to the 'if' statement.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index 6930f7e..c4fdc1c 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -1480,9 +1480,9 @@ static void XGIfb_detect_VB(struct xgifb_video_info *xgifb_info)
cr32 = xgifb_reg_get(XGICR, IND_XGI_SCRATCH_REG_CR32);
- if ((cr32 & SIS_CRT1) && !XGIfb_crt1off)
+ if ((cr32 & SIS_CRT1) && !XGIfb_crt1off) {
XGIfb_crt1off = 0;
- else {
+ } else {
if (cr32 & 0x5F)
XGIfb_crt1off = 1;
else
--
2.1.4
[toc] | [next] | [standalone]
| From | Georgios Emmanouil <geo.emmnl@gmail.com> |
|---|---|
| Date | 2017-02-22 19:40 +0100 |
| Subject | [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement |
| Message-ID | <tdJZw-5Qa-11@gated-at.bofh.it> |
| In reply to | #1586377 |
Coding style issue. Added brances to the conditional statement.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index c4fdc1c..1be0343 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -1500,18 +1500,19 @@ static void XGIfb_detect_VB(struct xgifb_video_info *xgifb_info)
xgifb_info->display2 = XGIFB_DISP_NONE;
}
- if (XGIfb_tvplug != -1)
+ if (XGIfb_tvplug != -1) {
/* Override with option */
xgifb_info->TV_plug = XGIfb_tvplug;
- else if (cr32 & SIS_VB_HIVISION) {
+ } else if (cr32 & SIS_VB_HIVISION) {
xgifb_info->TV_type = TVMODE_HIVISION;
xgifb_info->TV_plug = TVPLUG_SVIDEO;
- } else if (cr32 & SIS_VB_SVIDEO)
+ } else if (cr32 & SIS_VB_SVIDEO) {
xgifb_info->TV_plug = TVPLUG_SVIDEO;
- else if (cr32 & SIS_VB_COMPOSITE)
+ } else if (cr32 & SIS_VB_COMPOSITE) {
xgifb_info->TV_plug = TVPLUG_COMPOSITE;
- else if (cr32 & SIS_VB_SCART)
+ } else if (cr32 & SIS_VB_SCART) {
xgifb_info->TV_plug = TVPLUG_SCART;
+ }
if (xgifb_info->TV_type == 0) {
temp = xgifb_reg_get(XGICR, 0x38);
--
2.1.4
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-24 17:40 +0100 |
| Subject | Re: [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement |
| Message-ID | <ter4u-2Kh-15@gated-at.bofh.it> |
| In reply to | #1586391 |
On Wed, Feb 22, 2017 at 08:26:01PM +0200, Georgios Emmanouil wrote: > Coding style issue. Added brances to the conditional statement. > > Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com> > --- > drivers/staging/xgifb/XGI_main_26.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) Same here, someone else already did this :(
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-24 17:40 +0100 |
| Subject | Re: [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement |
| Message-ID | <ter4u-2Kh-11@gated-at.bofh.it> |
| In reply to | #1586377 |
On Wed, Feb 22, 2017 at 08:23:17PM +0200, Georgios Emmanouil wrote: > Coding style issue. Added brances to the 'if' statement. > > Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com> > --- > drivers/staging/xgifb/XGI_main_26.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Someone sent this same change in just before you did, sorry :( greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web