Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586374 > unrolled thread
| Started by | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| First post | 2017-02-22 19:20 +0100 |
| Last post | 2017-02-24 18:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH v3] staging: xgifb: function prototype argument should also have an identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-22 19:20 +0100
Re: [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name "Tobin C. Harding" <me@tobin.cc> - 2017-02-23 03:10 +0100
Re: [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-24 18:00 +0100
| From | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| Date | 2017-02-22 19:20 +0100 |
| Subject | [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name |
| Message-ID | <tdJGa-5HP-29@gated-at.bofh.it> |
function prototype argument 'struct vb_device_info *' and 'unsigned long' should also have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- changes in v3 -make the subject title more relevant. -change the identifier of struct vb_device_info to XGI_Pr. --- drivers/staging/xgifb/vb_init.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h index 500cabe41a3c..e835054b87bf 100644 --- a/drivers/staging/xgifb/vb_init.h +++ b/drivers/staging/xgifb/vb_init.h @@ -1,6 +1,5 @@ #ifndef _VBINIT_ #define _VBINIT_ unsigned char XGIInitNew(struct pci_dev *pdev); -void XGIRegInit(struct vb_device_info *, unsigned long); +void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr); #endif - -- 2.11.0
[toc] | [next] | [standalone]
| From | "Tobin C. Harding" <me@tobin.cc> |
|---|---|
| Date | 2017-02-23 03:10 +0100 |
| Subject | Re: [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name |
| Message-ID | <tdR0Z-2I2-1@gated-at.bofh.it> |
| In reply to | #1586374 |
Please use the imperative mood in the subject line i.e the short form
of git commit log.
A couple of example Subjects::
Subject: [PATCH 2/5] ext2: improve scalability of bitmap searching
Subject: [PATCH v2 01/27] x86: fix eflags tracking
Awesome work on you patches!
thanks,
Tobin.
[toc] | [prev] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-24 18:00 +0100 |
| Subject | Re: [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name |
| Message-ID | <ternP-2WZ-5@gated-at.bofh.it> |
| In reply to | #1586374 |
On Wed, Feb 22, 2017 at 11:46:39PM +0530, Arushi Singhal wrote: > function prototype argument 'struct vb_device_info *' and 'unsigned > long' should also have an identifier name. > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > changes in v3 > -make the subject title more relevant. > -change the identifier of struct vb_device_info to XGI_Pr. > --- > drivers/staging/xgifb/vb_init.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Does not apply to my tree :(
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web