Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583869 > unrolled thread

[PATCH] Staging: xgifb:XGI_main_26: Fixed coding style issues

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging: xgifb:XGI_main_26: Fixed coding style issues Georgios Emmanouil <geo.emmnl@gmail.com> - 2017-02-18 10:40 +0100
    Re: [PATCH] Staging: xgifb:XGI_main_26: Fixed coding style issues Greg KH <gregkh@linuxfoundation.org> - 2017-02-22 18:40 +0100

#1583869 — [PATCH] Staging: xgifb:XGI_main_26: Fixed coding style issues

Fixed coding style issues. Patch applies to linux-next-20170217 tree.

Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
 drivers/staging/xgifb/XGI_main_26.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index 6930f7e..1be0343 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -1480,9 +1480,9 @@ static void XGIfb_detect_VB(struct xgifb_video_info *xgifb_info)

 	cr32 = xgifb_reg_get(XGICR, IND_XGI_SCRATCH_REG_CR32);

-	if ((cr32 & SIS_CRT1) && !XGIfb_crt1off)
+	if ((cr32 & SIS_CRT1) && !XGIfb_crt1off) {
 		XGIfb_crt1off = 0;
-	else {
+	} else {
 		if (cr32 & 0x5F)
 			XGIfb_crt1off = 1;
 		else
@@ -1500,18 +1500,19 @@ static void XGIfb_detect_VB(struct xgifb_video_info *xgifb_info)
 			xgifb_info->display2 = XGIFB_DISP_NONE;
 	}

-	if (XGIfb_tvplug != -1)
+	if (XGIfb_tvplug != -1) {
 		/* Override with option */
 		xgifb_info->TV_plug = XGIfb_tvplug;
-	else if (cr32 & SIS_VB_HIVISION) {
+	} else if (cr32 & SIS_VB_HIVISION) {
 		xgifb_info->TV_type = TVMODE_HIVISION;
 		xgifb_info->TV_plug = TVPLUG_SVIDEO;
-	} else if (cr32 & SIS_VB_SVIDEO)
+	} else if (cr32 & SIS_VB_SVIDEO) {
 		xgifb_info->TV_plug = TVPLUG_SVIDEO;
-	else if (cr32 & SIS_VB_COMPOSITE)
+	} else if (cr32 & SIS_VB_COMPOSITE) {
 		xgifb_info->TV_plug = TVPLUG_COMPOSITE;
-	else if (cr32 & SIS_VB_SCART)
+	} else if (cr32 & SIS_VB_SCART) {
 		xgifb_info->TV_plug = TVPLUG_SCART;
+	}

 	if (xgifb_info->TV_type == 0) {
 		temp = xgifb_reg_get(XGICR, 0x38);
--
2.1.4

[toc] | [next] | [standalone]

#1586341

On Sat, Feb 18, 2017 at 11:29:46AM +0200, Georgios Emmanouil wrote:
> Fixed coding style issues. Patch applies to linux-next-20170217 tree.
> 
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>

_what_ coding style issues did you fix?  Please be specific and do not
try to fix more than one "type" of issue in a single patch, make it a
patch series.

Please fix up and resend.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web