Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586249 > unrolled thread

Re: [PATCH v2 3/3] mfd: wm831x: Add device tree binding document

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 3/3] mfd: wm831x: Add device tree binding document Rob Herring <robh@kernel.org> - 2017-02-22 16:20 +0100
    Re: [PATCH v2 3/3] mfd: wm831x: Add device tree binding document Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2017-02-22 17:10 +0100

#1586249 — Re: [PATCH v2 3/3] mfd: wm831x: Add device tree binding document

On Mon, Feb 13, 2017 at 11:15:14AM +0000, Charles Keepax wrote:
> This is just a very simple initial binding, supporting only registering
> the chip and the GPIOs. More features will be added as support for
> device tree in the driver is expanded.

Please make the binding as complete as you can. You don't have to have 
driver side support in place. Doesn't have to be everything, but at 
least everything you know you will need.

> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> 
> Changes since v1:
>  - Added MAINTAINERS update
> 
>  Documentation/devicetree/bindings/mfd/wm831x.txt | 31 ++++++++++++++++++++++++
>  MAINTAINERS                                      |  1 +
>  2 files changed, 32 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/wm831x.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/wm831x.txt b/Documentation/devicetree/bindings/mfd/wm831x.txt
> new file mode 100644
> index 0000000..9771022
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/wm831x.txt
> @@ -0,0 +1,31 @@
> +Cirrus Logic/Wolfson Microelectronics wm831x PMICs
> +
> +System PMICs with a wide range of additional features.
> +
> +Required properties:
> +
> +  - compatible : One of the following chip-specific strings:
> +        "wlf,wm8310"
> +        "wlf,wm8311"
> +        "wlf,wm8312"
> +        "wlf,wm8320"
> +        "wlf,wm8321"
> +        "wlf,wm8325"
> +        "wlf,wm8326"
> +
> +  - reg : I2C slave address when connected using I2C, chip select number when
> +    using SPI.
> +
> +  - gpio-controller : Indicates this device is a GPIO controller.
> +  - #gpio-cells : Must be 2. The first cell is the pin number and the
> +    second cell is used to specify optional parameters (currently unused).
> +
> +Example:
> +
> +wm8310: wm8310@36 {

pmic@

> +	compatible = "wlf,wm8310";
> +	reg = <0x36>;
> +
> +	gpio-controller;
> +	#gpio-cells = <2>;
> +};
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2d8ca28..48fdc82 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13363,6 +13363,7 @@ F:	Documentation/hwmon/wm83??
>  F:	Documentation/devicetree/bindings/extcon/extcon-arizona.txt
>  F:	Documentation/devicetree/bindings/regulator/arizona-regulator.txt
>  F:	Documentation/devicetree/bindings/mfd/arizona.txt
> +F:	Documentation/devicetree/bindings/mfd/wm831x.txt
>  F:	arch/arm/mach-s3c64xx/mach-crag6410*
>  F:	drivers/clk/clk-wm83*.c
>  F:	drivers/extcon/extcon-arizona.c
> -- 
> 2.1.4
> 

[toc] | [next] | [standalone]

#1586288

On Wed, Feb 22, 2017 at 09:15:02AM -0600, Rob Herring wrote:
> On Mon, Feb 13, 2017 at 11:15:14AM +0000, Charles Keepax wrote:
> > This is just a very simple initial binding, supporting only registering
> > the chip and the GPIOs. More features will be added as support for
> > device tree in the driver is expanded.
> 
> Please make the binding as complete as you can. You don't have to have 
> driver side support in place. Doesn't have to be everything, but at 
> least everything you know you will need.
> 

I am happy to flush the binding out with a bit more detail,
although the GPIOs are actually all I need to use at the moment.
I will send a new revision with some more detail. Do we normally
do anything to mark the bits of the binding that are currently
un-implemented?

Thanks,
Charles

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web