Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584070 > unrolled thread

[PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c

Back to article view | Back to linux.kernel

Contents

  [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c Saurabh Badhwar <sbsaurabhbadhwar9@gmail.com> - 2017-02-19 07:00 +0100
    Re: [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c walter harms <wharms@bfs.de> - 2017-02-19 14:40 +0100

#1584070 — [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c

Fix possible resource leak in tools/vm/page_owner_sort.c
Signed-off-by: Saurabh Badhwar <sbsaurabhbadhwar9@gmail.com>
---
 tools/vm/page_owner_sort.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c
index f1c055f..8346261 100644
--- a/tools/vm/page_owner_sort.c
+++ b/tools/vm/page_owner_sort.c
@@ -110,6 +110,8 @@ int main(int argc, char **argv)
 	buf = malloc(BUF_SIZE);
 	if (!list || !buf) {
 		printf("Out of memory\n");
+		fclose(fin);
+		fclose(fout);
 		exit(1);
 	}
 
@@ -144,6 +146,7 @@ int main(int argc, char **argv)
 
 	for (i = 0; i < count; i++)
 		fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt);
-
+		
+	fclose(fout);
 	return 0;
 }
-- 
2.9.3

[toc] | [next] | [standalone]

#1584141

Am 19.02.2017 06:49, schrieb Saurabh Badhwar:
> Fix possible resource leak in tools/vm/page_owner_sort.c
> Signed-off-by: Saurabh Badhwar <sbsaurabhbadhwar9@gmail.com>
> ---
>  tools/vm/page_owner_sort.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c
> index f1c055f..8346261 100644
> --- a/tools/vm/page_owner_sort.c
> +++ b/tools/vm/page_owner_sort.c
> @@ -110,6 +110,8 @@ int main(int argc, char **argv)
>  	buf = malloc(BUF_SIZE);
>  	if (!list || !buf) {
>  		printf("Out of memory\n");
> +		fclose(fin);
> +		fclose(fout);
>  		exit(1);
>  	}

the is no resource leak as file pointer get closed on exit
ntl it is ok the close them
but error messages should go to stderr an be more verbose.

just my 2 cents,
 wh
>  
> @@ -144,6 +146,7 @@ int main(int argc, char **argv)
>  
>  	for (i = 0; i < count; i++)
>  		fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt);
> -
> +		
> +	fclose(fout);
>  	return 0;
>  }

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web