Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583984 > unrolled thread

[PATCH v2 1/6] staging: vt6655: Compress return logic

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/6] staging: vt6655: Compress return logic simran singhal <singhalsimran0@gmail.com> - 2017-02-18 22:10 +0100
    Re: [Outreachy kernel] [PATCH v2 1/6] staging: vt6655: Compress  return logic Julia Lawall <julia.lawall@lip6.fr> - 2017-02-18 22:20 +0100

#1583984 — [PATCH v2 1/6] staging: vt6655: Compress return logic

gregkh@linuxfoundation.org,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org,outreachy-kernel@googlegroups.com
Bcc: 
Subject: [PATCH v2 1/6] staging: vt6655: Compress return logic
Reply-To: 

Simplify function returns by merging assignment and return into
one command line.
Found with Coccinelle
@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 
 v2:
   -Removed assignment

 drivers/staging/vt6655/card.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index e0c9281..9a8999f 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -918,9 +918,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, u64 qwTSF2)
 
 	qwTSF2 += (u64)wRxBcnTSFOffst;
 
-	qwTSFOffset = qwTSF1 - qwTSF2;
-
-	return qwTSFOffset;
+	return qwTSF1 - qwTSF2;
 }
 
 /*
-- 
2.7.4

[toc] | [next] | [standalone]

#1583993 — Re: [Outreachy kernel] [PATCH v2 1/6] staging: vt6655: Compress return logic

On Sun, 19 Feb 2017, simran singhal wrote:

> gregkh@linuxfoundation.org,devel@driverdev.osuosl.org,linux-kernel@vger.kernel.org,outreachy-kernel@googlegroups.com
> Bcc:
> Subject: [PATCH v2 1/6] staging: vt6655: Compress return logic
> Reply-To:

This didn't come out well.

>
> Simplify function returns by merging assignment and return into
> one command line.
> Found with Coccinelle
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
>      e;
> -return ret;
>
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>
>  v2:
>    -Removed assignment
>
>  drivers/staging/vt6655/card.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index e0c9281..9a8999f 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -918,9 +918,7 @@ u64 CARDqGetTSFOffset(unsigned char byRxRate, u64 qwTSF1, u64 qwTSF2)
>
>  	qwTSF2 += (u64)wRxBcnTSFOffst;
>
> -	qwTSFOffset = qwTSF1 - qwTSF2;
> -
> -	return qwTSFOffset;
> +	return qwTSF1 - qwTSF2;

It's not just the assignment that can go.  All mentions of the variable
are useless, ie the declaration too.

julia

>  }
>
>  /*
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218210740.GA14258%40singhal-Inspiron-5558.
> For more options, visit https://groups.google.com/d/optout.
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web