Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583928 > unrolled thread
| Started by | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| First post | 2017-02-18 17:50 +0100 |
| Last post | 2017-02-19 19:30 +0100 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: ks7010: There should be no spaces at the start of a line Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-18 17:50 +0100
Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line Greg KH <gregkh@linuxfoundation.org> - 2017-02-18 18:00 +0100
Re: [Outreachy kernel] Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line Julia Lawall <julia.lawall@lip6.fr> - 2017-02-19 16:40 +0100
Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line Julia Lawall <julia.lawall@lip6.fr> - 2017-02-18 18:10 +0100
Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line Joe Perches <joe@perches.com> - 2017-02-19 19:30 +0100
| From | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| Date | 2017-02-18 17:50 +0100 |
| Subject | [PATCH] Staging: ks7010: There should be no spaces at the start of a line |
| Message-ID | <tcgmR-4ey-1@gated-at.bofh.it> |
The following patch the checkpatch.pl warning: drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c index 819e08b5fa91..3b2e28749b63 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/ks_hostif.c @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) } DPRINTK(4, "\n Link AP\n"); DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); DPRINTK(4, "\n Link AP\n rsn.mode=%d\n rsn.size=%d\n", ap_info->rsn_mode, ap_info->rsn.size); DPRINTK(4, "\n ext_rate_set_size=%d\n rate_set_size=%d\n", -- 2.11.0
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-18 18:00 +0100 |
| Subject | Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line |
| Message-ID | <tcgwy-4hW-11@gated-at.bofh.it> |
| In reply to | #1583928 |
On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index 819e08b5fa91..3b2e28749b63 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > } > DPRINTK(4, "\n Link AP\n"); > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); > +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); So don't just remove the spaces, fix it correctly with the proper indentation please. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-02-19 16:40 +0100 |
| Subject | Re: [Outreachy kernel] Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line |
| Message-ID | <tcBKF-Dv-1@gated-at.bofh.it> |
| In reply to | #1583929 |
[Multipart message — attachments visible in raw view] — view raw
On Sun, 19 Feb 2017, Arushi Singhal wrote: > > Hi Greg > I think we cannot indent the text otherwise, the print statement will be > different as it should be There are newlines in the printed string. I suspect that there is no need to print them all at once. Actually, your change removed spaces inside a string, so it did change the form of the poutput. Also, remember not to top post :) julia > Thanks > > On Saturday, February 18, 2017 at 10:27:19 PM UTC+5:30, gregkh wrote: > On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote: > > The following patch the checkpatch.pl warning: > > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces > at the > > start of a line > > > > Signed-off-by: Arushi Singhal <arushising...@gmail.com> > > --- > > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c > > index 819e08b5fa91..3b2e28749b63 100644 > > --- a/drivers/staging/ks7010/ks_hostif.c > > +++ b/drivers/staging/ks7010/ks_hostif.c > > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private > *priv, struct link_ap_info_t *ap_info) > > } > > DPRINTK(4, "\n Link AP\n"); > > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n > \ > > - essid=%s\n > rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n > channel=%d\n \ > > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], > ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], > ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], > ap->rate_set.body[1], ap->rate_set.body[2], > ap->rate_set.body[3], ap->rate_set.body[4], > ap->rate_set.body[5], ap->rate_set.body[6], > ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, > ap->capability); > > +essid=%s\n > rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n > channel=%d\n \ > > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], > ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], > ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], > ap->rate_set.body[1], ap->rate_set.body[2], > ap->rate_set.body[3], ap->rate_set.body[4], > ap->rate_set.body[5], ap->rate_set.body[6], > ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, > ap->capability); > > So don't just remove the spaces, fix it correctly with the > proper > indentation please. > > thanks, > > greg k-h > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/df1dbfa6-0823-4899-b1b7- > 4358b18575be%40googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > >
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-02-18 18:10 +0100 |
| Subject | Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line |
| Message-ID | <tcgGd-4An-9@gated-at.bofh.it> |
| In reply to | #1583928 |
On Sat, 18 Feb 2017, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index 819e08b5fa91..3b2e28749b63 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > } > DPRINTK(4, "\n Link AP\n"); > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); > +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); The code looks like a mess. How about breaking up the call at the newlines, and then propagating the arguments to the appropriate calls. There is also a checkpatch error about strings on more than one line, that this also violates. julia > DPRINTK(4, "\n Link AP\n rsn.mode=%d\n rsn.size=%d\n", > ap_info->rsn_mode, ap_info->rsn.size); > DPRINTK(4, "\n ext_rate_set_size=%d\n rate_set_size=%d\n", > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170218164002.GA7269%40arushi-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. >
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-19 19:30 +0100 |
| Subject | Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line |
| Message-ID | <tcEpc-2iE-3@gated-at.bofh.it> |
| In reply to | #1583933 |
On Sat, 2017-02-18 at 18:00 +0100, Julia Lawall wrote: > On Sat, 18 Feb 2017, Arushi Singhal wrote: > > The following patch the checkpatch.pl warning: > > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > > start of a line [] > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c [] > > @@ -191,8 +191,8 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > > } > > DPRINTK(4, "\n Link AP\n"); > > DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid > > +essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > > +rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); > > The code looks like a mess. How about breaking up the call at the > newlines, and then propagating the arguments to the appropriate calls. > > There is also a checkpatch error about strings on more than one line, that > this also violates. There are also vsprintf %p<foo> extensions that would simplify the code for this output and for many others. see Documentation/printk-formats.txt something like: DPRINTK(4, " bssid=%pM\n", ap->bssid); DPRINTK(4, " essid=%s\n", ap->ssid.body); DPRINTK(4, " rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n", ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7]); DPRINTK(4, " channel=%d\n", ap->channel); DPRINTK(4, " rssi=%d\n", ap->rssi); DPRINTK(4, " sq=%d\n", ap->sq); DPRINTK(4, " capability=%04X\n", ap->capability);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web