Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583931 > unrolled thread
| Started by | Michał Zegan <webczat@webczatnet.pl> |
|---|---|
| First post | 2017-02-18 18:10 +0100 |
| Last post | 2017-02-28 10:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2] mmc: meson-gx: remove mmc host on device removal Michał Zegan <webczat@webczatnet.pl> - 2017-02-18 18:10 +0100
Re: [PATCH v2] mmc: meson-gx: remove mmc host on device removal Kevin Hilman <khilman@baylibre.com> - 2017-02-28 10:50 +0100
| From | Michał Zegan <webczat@webczatnet.pl> |
|---|---|
| Date | 2017-02-18 18:10 +0100 |
| Subject | [PATCH v2] mmc: meson-gx: remove mmc host on device removal |
| Message-ID | <tcgGd-4An-7@gated-at.bofh.it> |
The mmc host was added in meson_mmc_probe, but never removed in
meson_mmc_remove.
Fix that by removing the host before deallocating other resources.
Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
Tested-by: Michał Zegan <webczat@webczatnet.pl>
---
changes since v1:
rebased on top of patchset at
https://patchwork.kernel.org/patch/9581057/
This is in turn based on patchset at
https://patchwork.kernel.org/patch/9561215/
drivers/mmc/host/meson-gx-mmc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index e759e4c2e4a0..336b6a2e94c6 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
{
struct meson_host *host = dev_get_drvdata(&pdev->dev);
+ mmc_remove_host(host->mmc);
+
/* disable interrupts */
writel(0, host->regs + SD_EMMC_IRQ_EN);
--
2.11.0
[toc] | [next] | [standalone]
| From | Kevin Hilman <khilman@baylibre.com> |
|---|---|
| Date | 2017-02-28 10:50 +0100 |
| Message-ID | <tfMzU-2zF-19@gated-at.bofh.it> |
| In reply to | #1583931 |
Michał Zegan <webczat@webczatnet.pl> writes:
> The mmc host was added in meson_mmc_probe, but never removed in
> meson_mmc_remove.
> Fix that by removing the host before deallocating other resources.
>
> Signed-off-by: Michał Zegan <webczat@webczatnet.pl>
> Tested-by: Michał Zegan <webczat@webczatnet.pl>
Acked-by: Kevin Hilman <khilman@baylibre.com>
> ---
> changes since v1:
> rebased on top of patchset at
> https://patchwork.kernel.org/patch/9581057/
> This is in turn based on patchset at
> https://patchwork.kernel.org/patch/9561215/
>
> drivers/mmc/host/meson-gx-mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index e759e4c2e4a0..336b6a2e94c6 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -791,6 +791,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
> {
> struct meson_host *host = dev_get_drvdata(&pdev->dev);
>
> + mmc_remove_host(host->mmc);
> +
> /* disable interrupts */
> writel(0, host->regs + SD_EMMC_IRQ_EN);
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web