Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583926 > unrolled thread

Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-18 17:20 +0100
    Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Pau Espin Pedrol <pespin.shar@gmail.com> - 2017-02-21 14:40 +0100
      Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 16:40 +0100
        Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-02-23 09:40 +0100
          Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51 Pau Espin Pedrol <pespin.shar@gmail.com> - 2017-02-24 14:10 +0100

#1583926 — Re: [PATCH] eeepc-laptop: Skip unknown key messages 0x50 0x51

On Fri, Feb 10, 2017 at 7:48 PM, Pau Espin Pedrol <pespin.shar@gmail.com> wrote:
> Otherwise those are printed several times when (un)plugging the AC
> connector.

If we have a user space tool that supports them better not to ignore.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [next] | [standalone]

#1585339

Hi, resending as I initially replied from my mobile phone and it seem
plain text support is not enabled:

Hi,

If we have user space tools supporting and using this type of event,
then what about adding them properly with a define + entry in the
structure array so that it can be standardized and on top get rid of
those kernel message every time I (un)plug the charger? Would that be
welcomed? I could send a new patch as specified above, adding the
KEY_CHARING_ON/OFF defines + add entries to eeepc_keymap.


> On Feb 18, 2017 17:16, "Andy Shevchenko" <andy.shevchenko@gmail.com> wrote:
>
> On Fri, Feb 10, 2017 at 7:48 PM, Pau Espin Pedrol <pespin.shar@gmail.com>
> wrote:
>> Otherwise those are printed several times when (un)plugging the AC
>> connector.
>
> If we have a user space tool that supports them better not to ignore.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

[toc] | [prev] | [next] | [standalone]

#1585430

On Tue, Feb 21, 2017 at 3:39 PM, Pau Espin Pedrol <pespin.shar@gmail.com> wrote:

> If we have user space tools supporting and using this type of event,
> then what about adding them properly with a define + entry in the
> structure array so that it can be standardized and on top get rid of
> those kernel message every time I (un)plug the charger? Would that be
> welcomed? I could send a new patch as specified above, adding the
> KEY_CHARING_ON/OFF defines + add entries to eeepc_keymap.

Please, do not top posting.

Dmitry, do we have special events for AC (un)plug? What is the best
approach in your opinion?

>> On Feb 18, 2017 17:16, "Andy Shevchenko" <andy.shevchenko@gmail.com> wrote:
>>
>> On Fri, Feb 10, 2017 at 7:48 PM, Pau Espin Pedrol <pespin.shar@gmail.com>
>> wrote:
>>> Otherwise those are printed several times when (un)plugging the AC
>>> connector.
>>
>> If we have a user space tool that supports them better not to ignore.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1586733

On Tue, Feb 21, 2017 at 05:38:59PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 21, 2017 at 3:39 PM, Pau Espin Pedrol <pespin.shar@gmail.com> wrote:
> 
> > If we have user space tools supporting and using this type of event,
> > then what about adding them properly with a define + entry in the
> > structure array so that it can be standardized and on top get rid of
> > those kernel message every time I (un)plug the charger? Would that be
> > welcomed? I could send a new patch as specified above, adding the
> > KEY_CHARING_ON/OFF defines + add entries to eeepc_keymap.
> 
> Please, do not top posting.
> 
> Dmitry, do we have special events for AC (un)plug? What is the best
> approach in your opinion?

Not route them through input as they not input events would be the best.

I'd look into hooking up power_supply class.

Thanks.

-- 
Dmitry

[toc] | [prev] | [next] | [standalone]

#1587602

>> Dmitry, do we have special events for AC (un)plug? What is the best
>> approach in your opinion?
>
> Not route them through input as they not input events would be the best.
>
Is my patch good enough for this or would you recommend doing it another way?

> I'd look into hooking up power_supply class.
>
Whys is this necessay? All the related information required is already
present in my system.
I already have two power_supply instances:
* /sys/class/power_supply/AC0/ (provided by module "ac"), contains
property "online" which is correctly updated to 1 when AC is plugged
and 0 when AC is unplugged.
* /sys/class/power_supply/BAT0/ (provided by module "battery"),
contains property "status" which is correctly updated to "Charging"
when AC is plugged and "Discharging" when AC is unplugged.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web