Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583903 > unrolled thread

[PATCH v2] staging: xgifb: function definition argument should also have an identifier name'

Back to article view | Back to linux.kernel

Contents

  [PATCH v2] staging: xgifb: function definition argument should also  have an identifier name' Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-18 14:50 +0100
    Re: [PATCH v2] staging: xgifb: function definition argument should  also have an identifier name' Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-22 18:40 +0100

#1583903 — [PATCH v2] staging: xgifb: function definition argument should also have an identifier name'

function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/xgifb/vb_init.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
index 500cabe41a3c..e835054b87bf 100644
--- a/drivers/staging/xgifb/vb_init.h
+++ b/drivers/staging/xgifb/vb_init.h
@@ -1,6 +1,5 @@
 #ifndef _VBINIT_
 #define _VBINIT_
 unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr);
 #endif
-
-- 
2.11.0

[toc] | [next] | [standalone]

#1586348 — Re: [PATCH v2] staging: xgifb: function definition argument should also have an identifier name'

On Sat, Feb 18, 2017 at 07:16:11PM +0530, Arushi Singhal wrote:
> function definition argument 'struct vb_device_info *' and 'unsigned
> long' should also have an identifier name.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  drivers/staging/xgifb/vb_init.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

What changed from v1?  Please always list it.  Please fix up and resend.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web