Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1584348 > unrolled thread

Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access Andrew Jeffery <andrew@aj.id.au> - 2017-02-20 05:50 +0100
    Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access Corey Minyard <minyard@acm.org> - 2017-02-20 14:40 +0100
      Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access Andrew Jeffery <andrew@aj.id.au> - 2017-02-20 16:00 +0100
        Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access Corey Minyard <minyard@acm.org> - 2017-02-20 18:10 +0100

#1584348 — Re: [PATCH] ipmi: bt-bmc: Use a regmap for register access

[Multipart message — attachments visible in raw view] — view raw

Hi Cory,

On Tue, 2016-12-06 at 16:02 +0100, Cédric Le Goater wrote:
> [ this is a resend bc of some mailing list issues] 
> 
> On 12/06/2016 03:57 AM, Andrew Jeffery wrote:
> > The registers for the bt-bmc device live under the Aspeed LPC
> > controller. Devicetree bindings have recently been introduced for the
> > LPC controller where the "host" portion of the LPC register space is
> > described as a syscon device. Future devicetrees describing the bt-bmc
> > device should nest its node under the appropriate "simple-mfd", "syscon"
> > compatible node.
> > 
> > This change allows the bt-bmc driver to function with both syscon and
> > non-syscon- based devicetree descriptions by always using a regmap for
> > register access, either retrieved from the parent syscon device or
> > instantiated if none exists.
> > 
> > The patch has been tested on an OpenPOWER Palmetto machine, successfully
> > booting, rebooting and powering down the host.
> > 
> > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> 
> It would be nice to have an example of the associated binding. 
> I did not see it. A part from that :
> 
> Reviewed-by: Cédric Le Goater <clg@kaod.org>


Will this make it into 4.11?

Cheers,

Andrew

[toc] | [next] | [standalone]

#1584616

On 02/19/2017 10:45 PM, Andrew Jeffery wrote:
> Hi Cory,
>
> On Tue, 2016-12-06 at 16:02 +0100, Cédric Le Goater wrote:
>> [ this is a resend bc of some mailing list issues]
>>
>> On 12/06/2016 03:57 AM, Andrew Jeffery wrote:
>>> The registers for the bt-bmc device live under the Aspeed LPC
>>> controller. Devicetree bindings have recently been introduced for the
>>> LPC controller where the "host" portion of the LPC register space is
>>> described as a syscon device. Future devicetrees describing the bt-bmc
>>> device should nest its node under the appropriate "simple-mfd", "syscon"
>>> compatible node.
>>>
>>> This change allows the bt-bmc driver to function with both syscon and
>>> non-syscon- based devicetree descriptions by always using a regmap for
>>> register access, either retrieved from the parent syscon device or
>>> instantiated if none exists.
>>>
>>> The patch has been tested on an OpenPOWER Palmetto machine, successfully
>>> booting, rebooting and powering down the host.
>>>
>>> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>> It would be nice to have an example of the associated binding.
>> I did not see it. A part from that :
>>
>> Reviewed-by: Cédric Le Goater <clg@kaod.org>
>
> Will this make it into 4.11?

I thought you were doing a v2 with a few little fixes.  Get it to me 
quickly, if you can.

-corey

> Cheers,
>
> Andrew

[toc] | [prev] | [next] | [standalone]

#1584650

[Multipart message — attachments visible in raw view] — view raw

On Mon, 2017-02-20 at 07:35 -0600, Corey Minyard wrote:
> On 02/19/2017 10:45 PM, Andrew Jeffery wrote:
> > Hi Cory,
> > 
> > On Tue, 2016-12-06 at 16:02 +0100, Cédric Le Goater wrote:
> > > [ this is a resend bc of some mailing list issues]
> > > 
> > > On 12/06/2016 03:57 AM, Andrew Jeffery wrote:
> > > > The registers for the bt-bmc device live under the Aspeed LPC
> > > > controller. Devicetree bindings have recently been introduced for the
> > > > LPC controller where the "host" portion of the LPC register space is
> > > > described as a syscon device. Future devicetrees describing the bt-bmc
> > > > device should nest its node under the appropriate "simple-mfd", "syscon"
> > > > compatible node.
> > > > 
> > > > This change allows the bt-bmc driver to function with both syscon and
> > > > non-syscon- based devicetree descriptions by always using a regmap for
> > > > register access, either retrieved from the parent syscon device or
> > > > instantiated if none exists.
> > > > 
> > > > The patch has been tested on an OpenPOWER Palmetto machine, successfully
> > > > booting, rebooting and powering down the host.
> > > > 
> > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > > 
> > > It would be nice to have an example of the associated binding.
> > > I did not see it. A part from that :
> > > 
> > > Reviewed-by: Cédric Le Goater <clg@kaod.org>
> > 
> > Will this make it into 4.11?
> 
> I thought you were doing a v2 with a few little fixes.  Get it to me 
> quickly, if you can.

Reading back it was a bit ambiguous. No worries, I'll roll in the small
fixes and send a v2.

Cheers,

Andrew

[toc] | [prev] | [next] | [standalone]

#1584765

On 02/20/2017 08:52 AM, Andrew Jeffery wrote:
> On Mon, 2017-02-20 at 07:35 -0600, Corey Minyard wrote:
>> On 02/19/2017 10:45 PM, Andrew Jeffery wrote:
>>> Hi Cory,
>>>
>>> On Tue, 2016-12-06 at 16:02 +0100, Cédric Le Goater wrote:
>>>> [ this is a resend bc of some mailing list issues]
>>>>
>>>> On 12/06/2016 03:57 AM, Andrew Jeffery wrote:
>>>>> The registers for the bt-bmc device live under the Aspeed LPC
>>>>> controller. Devicetree bindings have recently been introduced for the
>>>>> LPC controller where the "host" portion of the LPC register space is
>>>>> described as a syscon device. Future devicetrees describing the bt-bmc
>>>>> device should nest its node under the appropriate "simple-mfd", "syscon"
>>>>> compatible node.
>>>>>
>>>>> This change allows the bt-bmc driver to function with both syscon and
>>>>> non-syscon- based devicetree descriptions by always using a regmap for
>>>>> register access, either retrieved from the parent syscon device or
>>>>> instantiated if none exists.
>>>>>
>>>>> The patch has been tested on an OpenPOWER Palmetto machine, successfully
>>>>> booting, rebooting and powering down the host.
>>>>>
>>>>> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
>>>> It would be nice to have an example of the associated binding.
>>>> I did not see it. A part from that :
>>>>
>>>> Reviewed-by: Cédric Le Goater <clg@kaod.org>
>>> Will this make it into 4.11?
>> I thought you were doing a v2 with a few little fixes.  Get it to me
>> quickly, if you can.
> Reading back it was a bit ambiguous. No worries, I'll roll in the small
> fixes and send a v2.

Yeah, it was, sorry, I should have been clear there.

I'll leave it in the linux-next tree for a bit, then ask Linus for a pull.

Thanks,

-corey

> Cheers,
>
> Andrew

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web