Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1584234 > unrolled thread
| Started by | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| First post | 2017-02-19 20:10 +0100 |
| Last post | 2017-02-21 22:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] nvmet-rdma: Fix error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-02-19 20:10 +0100
Re: [PATCH] nvmet-rdma: Fix error handling Christoph Hellwig <hch@lst.de> - 2017-02-19 20:50 +0100
Re: [PATCH] nvmet-rdma: Fix error handling Sagi Grimberg <sagi@grimberg.me> - 2017-02-21 22:30 +0100
| From | Christophe JAILLET <christophe.jaillet@wanadoo.fr> |
|---|---|
| Date | 2017-02-19 20:10 +0100 |
| Subject | [PATCH] nvmet-rdma: Fix error handling |
| Message-ID | <tcF1U-2M9-23@gated-at.bofh.it> |
According to the surrounding goto, it is likely that 'out_destroy_sq' was
expected here.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/nvme/target/rdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 60990220bd83..2ae63f7e17ed 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1091,7 +1091,7 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev,
queue->idx = ida_simple_get(&nvmet_rdma_queue_ida, 0, 0, GFP_KERNEL);
if (queue->idx < 0) {
ret = NVME_RDMA_CM_NO_RSC;
- goto out_free_queue;
+ goto out_destroy_sq;
}
ret = nvmet_rdma_alloc_rsps(queue);
--
2.9.3
[toc] | [next] | [standalone]
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Date | 2017-02-19 20:50 +0100 |
| Message-ID | <tcFEC-31O-11@gated-at.bofh.it> |
| In reply to | #1584234 |
On Sun, Feb 19, 2017 at 08:04:38PM +0100, Christophe JAILLET wrote: > According to the surrounding goto, it is likely that 'out_destroy_sq' was > expected here. s/surrounding/preceeding/ ? But the patch itself looks good, thanks. Reviewed-by: Christoph Hellwig <hch@lst.de>
[toc] | [prev] | [next] | [standalone]
| From | Sagi Grimberg <sagi@grimberg.me> |
|---|---|
| Date | 2017-02-21 22:30 +0100 |
| Message-ID | <tdqav-8gh-31@gated-at.bofh.it> |
| In reply to | #1584243 |
> On Sun, Feb 19, 2017 at 08:04:38PM +0100, Christophe JAILLET wrote: >> According to the surrounding goto, it is likely that 'out_destroy_sq' was >> expected here. > > s/surrounding/preceeding/ ? > > But the patch itself looks good, thanks. > > Reviewed-by: Christoph Hellwig <hch@lst.de> Picked it up and reworded, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web