Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583495 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-02-17 15:50 +0100 |
| Last post | 2017-02-19 15:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] RDMA/bnxt_re: add DCB dependency Arnd Bergmann <arnd@arndb.de> - 2017-02-17 15:50 +0100
Re: [PATCH] RDMA/bnxt_re: add DCB dependency Doug Ledford <dledford@redhat.com> - 2017-02-19 15:00 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-02-17 15:50 +0100 |
| Subject | [PATCH] RDMA/bnxt_re: add DCB dependency |
| Message-ID | <tbS1b-5xl-21@gated-at.bofh.it> |
When CONFIG_DCB is disabled, we get a link error:
drivers/infiniband/built-in.o: In function `bnxt_re_setup_qos':
trace.c:(.text+0x155774): undefined reference to `dcb_ieee_getapp_mask'
trace.c:(.text+0x155774): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask'
trace.c:(.text+0x155794): undefined reference to `dcb_ieee_getapp_mask'
trace.c:(.text+0x155794): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask'
Like the other drivers that use this function, a Kconfig dependency is
the correct fix.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/infiniband/hw/bnxt_re/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/bnxt_re/Kconfig b/drivers/infiniband/hw/bnxt_re/Kconfig
index cd0175e32584..19982a4a9bba 100644
--- a/drivers/infiniband/hw/bnxt_re/Kconfig
+++ b/drivers/infiniband/hw/bnxt_re/Kconfig
@@ -1,6 +1,6 @@
config INFINIBAND_BNXT_RE
tristate "Broadcom Netxtreme HCA support"
- depends on ETHERNET && NETDEVICES && PCI && INET
+ depends on ETHERNET && NETDEVICES && PCI && INET && DCB
select NET_VENDOR_BROADCOM
select BNXT
---help---
--
2.9.0
[toc] | [next] | [standalone]
| From | Doug Ledford <dledford@redhat.com> |
|---|---|
| Date | 2017-02-19 15:00 +0100 |
| Message-ID | <tcAbT-83c-1@gated-at.bofh.it> |
| In reply to | #1583495 |
[Multipart message — attachments visible in raw view] — view raw
On Fri, 2017-02-17 at 15:40 +0100, Arnd Bergmann wrote: > When CONFIG_DCB is disabled, we get a link error: > > drivers/infiniband/built-in.o: In function `bnxt_re_setup_qos': > trace.c:(.text+0x155774): undefined reference to > `dcb_ieee_getapp_mask' > trace.c:(.text+0x155774): relocation truncated to fit: > R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask' > trace.c:(.text+0x155794): undefined reference to > `dcb_ieee_getapp_mask' > trace.c:(.text+0x155794): relocation truncated to fit: > R_AARCH64_CALL26 against undefined symbol `dcb_ieee_getapp_mask' > > Like the other drivers that use this function, a Kconfig dependency > is > the correct fix. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks, applied. -- Doug Ledford <dledford@redhat.com> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web