Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1582091 > unrolled thread

[PATCH 3.16 060/306] [media] dvb-usb: avoid link error with dib3000m{b,c|

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 3.16 060/306] [media] dvb-usb: avoid link error with  dib3000m{b,c| Ben Hutchings <ben@decadent.org.uk> - 2017-02-16 01:10 +0100
    Re: [PATCH 3.16 060/306] [media] dvb-usb: avoid link error with dib3000m{b,c| Arnd Bergmann <arnd@arndb.de> - 2017-02-16 09:40 +0100
      Re: [PATCH 3.16 060/306] [media] dvb-usb: avoid link error with  dib3000m{b,c| Ben Hutchings <ben@decadent.org.uk> - 2017-02-16 17:10 +0100

#1582091 — [PATCH 3.16 060/306] [media] dvb-usb: avoid link error with dib3000m{b,c|

3.16.40-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Arnd Bergmann <arnd@arndb.de>

commit d0fe85e95f56a01a49e4893aa26263e8aee67eef upstream.

Tha ARM randconfig builds came up with another rare build failure
for the dib3000mc driver, when dvb-usb-dibusb-mb is built-in and
dib3000mc is a loadable module:

ERROR: "dibusb_dib3000mc_frontend_attach" [drivers/media/usb/dvb-usb/dvb-usb-nova-t-usb2.ko] undefined!
ERROR: "dibusb_dib3000mc_tuner_attach" [drivers/media/usb/dvb-usb/dvb-usb-nova-t-usb2.ko] undefined!

Apparently this used to be a valid configuration (build-time, not
run-time), but broke as part of a cleanup.

I tried reverting the cleanup, but saw that the code was still wrong
then. This version adds a dependency for dib3000mb, to ensure that
dib3000mb does not force the dibusb_dib3000mc_frontend_attach function
to be built-in when dib3000mc is a loadable module.

I have also checked the two other files that were changed in the original
cleanup, and found them to be correct in either version, so I do not
touch that part.

As this is a rather obscure bug, there is no need for backports.

Fixes: 028c70ff42783 ("[media] dvb-usb/dvb-usb-v2: use IS_ENABLED")

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 drivers/media/usb/dvb-usb/Kconfig | 1 +
 1 file changed, 1 insertion(+)

--- a/drivers/media/usb/dvb-usb/Kconfig
+++ b/drivers/media/usb/dvb-usb/Kconfig
@@ -34,6 +34,7 @@ config DVB_USB_DIBUSB_MB
 	depends on DVB_USB
 	select DVB_PLL if MEDIA_SUBDRV_AUTOSELECT
 	select DVB_DIB3000MB
+	depends on DVB_DIB3000MC || !DVB_DIB3000MC
 	select MEDIA_TUNER_MT2060 if MEDIA_SUBDRV_AUTOSELECT
 	help
 	  Support for USB 1.1 and 2.0 DVB-T receivers based on reference designs made by

[toc] | [next] | [standalone]

#1582382 — Re: [PATCH 3.16 060/306] [media] dvb-usb: avoid link error with dib3000m{b,c|

On Wed, Feb 15, 2017 at 11:41 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> 3.16.40-rc1 review patch.  If anyone has any objections, please let me know.
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> commit d0fe85e95f56a01a49e4893aa26263e8aee67eef upstream.
...
> As this is a rather obscure bug, there is no need for backports.
>
> Fixes: 028c70ff42783 ("[media] dvb-usb/dvb-usb-v2: use IS_ENABLED")
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

I'd probably drop this one. Nobody is going to care (it took me thousands of
randconfig builds to even run into it), and the surrounding code has changed
a few times, so I'm not completely sure it is still the right fix for
3.16 (it probably
is, but it's not worth the time to investigate more closely I think).

I also looked at the other backports from fixes I did in this series, they all
look fine.

    Arnd

[toc] | [prev] | [next] | [standalone]

#1582669

[Multipart message — attachments visible in raw view] — view raw

On Thu, 2017-02-16 at 09:31 +0100, Arnd Bergmann wrote:
> > On Wed, Feb 15, 2017 at 11:41 PM, Ben Hutchings <ben@decadent.org.uk> wrote:
> > 3.16.40-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > commit d0fe85e95f56a01a49e4893aa26263e8aee67eef upstream.
> 
> ...
> > As this is a rather obscure bug, there is no need for backports.
> > 
> > Fixes: 028c70ff42783 ("[media] dvb-usb/dvb-usb-v2: use IS_ENABLED")
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> 
> I'd probably drop this one. Nobody is going to care (it took me thousands of
> randconfig builds to even run into it), and the surrounding code has changed
> a few times, so I'm not completely sure it is still the right fix for
> 3.16 (it probably
> is, but it's not worth the time to investigate more closely I think).

OK, I've dropped it.

> I also looked at the other backports from fixes I did in this series, they all
> look fine.

Thanks.

Ben.

-- 
Ben Hutchings
The most exhausting thing in life is being insincere. - Anne Morrow
Lindberg

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web