Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1582178 > unrolled thread

[PATCH] ARM: uaccess: fix zeroing of 64-bit get_user()

Started byKees Cook <keescook@chromium.org>
First post2017-02-16 01:40 +0100
Last post2017-02-16 01:40 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH] ARM: uaccess: fix zeroing of 64-bit get_user() Kees Cook <keescook@chromium.org> - 2017-02-16 01:40 +0100

#1582178 — [PATCH] ARM: uaccess: fix zeroing of 64-bit get_user()

FromKees Cook <keescook@chromium.org>
Date2017-02-16 01:40 +0100
Subject[PATCH] ARM: uaccess: fix zeroing of 64-bit get_user()
Message-ID<tbih5-768-55@gated-at.bofh.it>
The 64-bit get_user() wasn't clearing the high word due to a typo in the
error handler. The exception handler entry was already correct, though.
Noticed during recent usercopy test additions in lib/test_user_copy.c.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 arch/arm/lib/getuser.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/lib/getuser.S b/arch/arm/lib/getuser.S
index 8ecfd15c3a02..df73914e81c8 100644
--- a/arch/arm/lib/getuser.S
+++ b/arch/arm/lib/getuser.S
@@ -67,7 +67,7 @@ ENTRY(__get_user_4)
 ENDPROC(__get_user_4)
 
 ENTRY(__get_user_8)
-	check_uaccess r0, 8, r1, r2, __get_user_bad
+	check_uaccess r0, 8, r1, r2, __get_user_bad8
 #ifdef CONFIG_THUMB2_KERNEL
 5: TUSER(ldr)	r2, [r0]
 6: TUSER(ldr)	r3, [r0, #4]
-- 
2.7.4


-- 
Kees Cook
Pixel Security

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web