Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1581599 > unrolled thread
| Started by | Jon Derrick <jonathan.derrick@intel.com> |
|---|---|
| First post | 2017-02-15 20:50 +0100 |
| Last post | 2017-02-17 17:50 +0100 |
| Articles | 7 — 6 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match Jon Derrick <jonathan.derrick@intel.com> - 2017-02-15 20:50 +0100
Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match Stewart Smith <stewart@linux.vnet.ibm.com> - 2017-02-16 01:40 +0100
Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2017-02-16 02:10 +0100
Re: [PATCHv3,4/4] MAINTAINERS: Remove powerpc's opal match Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-02-19 12:40 +0100
Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match Michael Ellerman <mpe@ellerman.id.au> - 2017-02-16 06:30 +0100
Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match Jon Derrick <jonathan.derrick@intel.com> - 2017-02-16 17:20 +0100
RE: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> - 2017-02-17 17:50 +0100
| From | Jon Derrick <jonathan.derrick@intel.com> |
|---|---|
| Date | 2017-02-15 20:50 +0100 |
| Subject | [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match |
| Message-ID | <tbdKp-49q-7@gated-at.bofh.it> |
PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks like the 'arch/powerpc' file pattern should be enough to match powerpc opal code by itself. Remove the opal regex pattern from powerpc. Signed-off-by: Jon Derrick <jonathan.derrick@intel.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b983b25..430dd02 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7404,7 +7404,6 @@ F: drivers/pci/hotplug/pnv_php.c F: drivers/pci/hotplug/rpa* F: drivers/scsi/ibmvscsi/ F: tools/testing/selftests/powerpc -N: opal N: /pmac N: powermac N: powernv -- 1.8.3.1
[toc] | [next] | [standalone]
| From | Stewart Smith <stewart@linux.vnet.ibm.com> |
|---|---|
| Date | 2017-02-16 01:40 +0100 |
| Message-ID | <tbih3-768-21@gated-at.bofh.it> |
| In reply to | #1581599 |
Jon Derrick <jonathan.derrick@intel.com> writes: > PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks > like the 'arch/powerpc' file pattern should be enough to match powerpc > opal code by itself. Remove the opal regex pattern from powerpc. This patch will end up missing some code, what about this instead: Remove OPAL regex in powerpc to avoid false match Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> --- MAINTAINERS | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3960e7f..25ed25a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7393,18 +7393,24 @@ L: linuxppc-dev@lists.ozlabs.org Q: http://patchwork.ozlabs.org/project/linuxppc-dev/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git S: Supported +F: Documentation/ABI/stable/sysfs-firmware-opal-* +F: Documentation/devicetree/bindings/powerpc/opal/ +F: Documentation/devicetree/bindings/rtc/rtc-opal.txt +F: Documentation/devicetree/bindings/i2c/i2c-opal.txt F: Documentation/powerpc/ F: arch/powerpc/ F: drivers/char/tpm/tpm_ibmvtpm* F: drivers/crypto/nx/ F: drivers/crypto/vmx/ +F: drivers/i2c/busses/ic2-opal.c F: drivers/net/ethernet/ibm/ibmveth.* F: drivers/net/ethernet/ibm/ibmvnic.* F: drivers/pci/hotplug/pnv_php.c F: drivers/pci/hotplug/rpa* +F: drivers/rtc/rtc-opal.c F: drivers/scsi/ibmvscsi/ +F: drivers/tty/hvc/hvc_opal.c F: tools/testing/selftests/powerpc -N: opal N: /pmac N: powermac N: powernv -- Stewart Smith OPAL Architect, IBM.
[toc] | [prev] | [next] | [standalone]
| From | Andrew Donnellan <andrew.donnellan@au1.ibm.com> |
|---|---|
| Date | 2017-02-16 02:10 +0100 |
| Message-ID | <tbiK5-7wt-3@gated-at.bofh.it> |
| In reply to | #1582166 |
On 16/02/17 11:37, Stewart Smith wrote: > Jon Derrick <jonathan.derrick@intel.com> writes: >> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks >> like the 'arch/powerpc' file pattern should be enough to match powerpc >> opal code by itself. Remove the opal regex pattern from powerpc. > > This patch will end up missing some code, what about this instead: > > > Remove OPAL regex in powerpc to avoid false match > > Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> Per my reply to v4 of this series, your list matches mine. With the one typo correction below: Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > > --- > MAINTAINERS | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 3960e7f..25ed25a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7393,18 +7393,24 @@ L: linuxppc-dev@lists.ozlabs.org > Q: http://patchwork.ozlabs.org/project/linuxppc-dev/list/ > T: git git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > S: Supported > +F: Documentation/ABI/stable/sysfs-firmware-opal-* > +F: Documentation/devicetree/bindings/powerpc/opal/ > +F: Documentation/devicetree/bindings/rtc/rtc-opal.txt > +F: Documentation/devicetree/bindings/i2c/i2c-opal.txt > F: Documentation/powerpc/ > F: arch/powerpc/ > F: drivers/char/tpm/tpm_ibmvtpm* > F: drivers/crypto/nx/ > F: drivers/crypto/vmx/ > +F: drivers/i2c/busses/ic2-opal.c i2c-opal > F: drivers/net/ethernet/ibm/ibmveth.* > F: drivers/net/ethernet/ibm/ibmvnic.* > F: drivers/pci/hotplug/pnv_php.c > F: drivers/pci/hotplug/rpa* > +F: drivers/rtc/rtc-opal.c > F: drivers/scsi/ibmvscsi/ > +F: drivers/tty/hvc/hvc_opal.c > F: tools/testing/selftests/powerpc > -N: opal > N: /pmac > N: powermac > N: powernv > > -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <patch-notifications@ellerman.id.au> |
|---|---|
| Date | 2017-02-19 12:40 +0100 |
| Subject | Re: [PATCHv3,4/4] MAINTAINERS: Remove powerpc's opal match |
| Message-ID | <tcy0p-6OQ-5@gated-at.bofh.it> |
| In reply to | #1582166 |
On Thu, 2017-02-16 at 00:37:15 UTC, Stewart Smith wrote: > Remove OPAL regex in powerpc to avoid false match > > Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> > Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/a42715830d552d7c0e3be709383ece cheers
[toc] | [prev] | [next] | [standalone]
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Date | 2017-02-16 06:30 +0100 |
| Message-ID | <tbmNI-1El-5@gated-at.bofh.it> |
| In reply to | #1581599 |
Jon Derrick <jonathan.derrick@intel.com> writes: > PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks > like the 'arch/powerpc' file pattern should be enough to match powerpc > opal code by itself. Remove the opal regex pattern from powerpc. We thought of it first. Can't you just rename your driver, Opal Storage Specification, so "oss", that should be pretty unique? ... :) I don't like this version, but I'll merge the one from Stewart which drops the pattern and adds the paths for the existing drivers. cheers > diff --git a/MAINTAINERS b/MAINTAINERS > index b983b25..430dd02 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7404,7 +7404,6 @@ F: drivers/pci/hotplug/pnv_php.c > F: drivers/pci/hotplug/rpa* > F: drivers/scsi/ibmvscsi/ > F: tools/testing/selftests/powerpc > -N: opal > N: /pmac > N: powermac > N: powernv > -- > 1.8.3.1
[toc] | [prev] | [next] | [standalone]
| From | Jon Derrick <jonathan.derrick@intel.com> |
|---|---|
| Date | 2017-02-16 17:20 +0100 |
| Message-ID | <tbwWJ-kC-15@gated-at.bofh.it> |
| In reply to | #1582317 |
Thanks everyone. Sorry about the mess :) On 02/15/2017 10:23 PM, Michael Ellerman wrote: > Jon Derrick <jonathan.derrick@intel.com> writes: > >> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks >> like the 'arch/powerpc' file pattern should be enough to match powerpc >> opal code by itself. Remove the opal regex pattern from powerpc. > > We thought of it first. > > Can't you just rename your driver, Opal Storage Specification, so "oss", > that should be pretty unique? > > ... :) > > I don't like this version, but I'll merge the one from Stewart which > drops the pattern and adds the paths for the existing drivers. > > cheers > >> diff --git a/MAINTAINERS b/MAINTAINERS >> index b983b25..430dd02 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -7404,7 +7404,6 @@ F: drivers/pci/hotplug/pnv_php.c >> F: drivers/pci/hotplug/rpa* >> F: drivers/scsi/ibmvscsi/ >> F: tools/testing/selftests/powerpc >> -N: opal >> N: /pmac >> N: powermac >> N: powernv >> -- >> 1.8.3.1
[toc] | [prev] | [next] | [standalone]
| From | "Elliott, Robert (Persistent Memory)" <elliott@hpe.com> |
|---|---|
| Date | 2017-02-17 17:50 +0100 |
| Message-ID | <tbTTk-6K3-13@gated-at.bofh.it> |
| In reply to | #1582681 |
> -----Original Message----- > From: linux-block-owner@vger.kernel.org [mailto:linux-block- > owner@vger.kernel.org] On Behalf Of Jon Derrick > Sent: Thursday, February 16, 2017 10:15 AM > To: Michael Ellerman <mpe@ellerman.id.au> > Cc: Jens Axboe <axboe@kernel.dk>; Rafael Antognolli > <rafael.antognolli@intel.com>; Greg Kroah-Hartman > <gregkh@linuxfoundation.org>; linux-kernel@vger.kernel.org; linux- > block@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Christoph Hellwig > <hch@lst.de>; Scott Bauer <scott.bauer@intel.com> > Subject: Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match > > Thanks everyone. Sorry about the mess :) > > On 02/15/2017 10:23 PM, Michael Ellerman wrote: > > Jon Derrick <jonathan.derrick@intel.com> writes: > > > >> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks > >> like the 'arch/powerpc' file pattern should be enough to match powerpc > >> opal code by itself. Remove the opal regex pattern from powerpc. > > > > We thought of it first. > > > > Can't you just rename your driver, Opal Storage Specification, so "oss", > > that should be pretty unique? > > > > ... :) The library could easily be used for devices supporting the Opalite and Pyrite SSCs, not just the Opal SSC. With some effort, I suspect that Enterprise SSC could also be supported. So, a broader name might indeed be useful. The full names of the specifications are: TCG Storage Security Subsystem Class: Opal TCG Storage Security Subsystem Class: Opalite TCG Storage Security Subsystem Class: Pyrite TCG Storage Security Subsystem Class: Enterprise --- Robert Elliott, HPE Persistent Memory
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web