Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1582405 > unrolled thread
| Started by | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| First post | 2017-02-16 10:20 +0100 |
| Last post | 2017-02-17 18:20 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] net: mvneta: make mvneta_eth_tool_ops static Jisheng Zhang <jszhang@marvell.com> - 2017-02-16 10:20 +0100
Re: [PATCH] net: mvneta: make mvneta_eth_tool_ops static Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2017-02-16 10:40 +0100
Re: [PATCH] net: mvneta: make mvneta_eth_tool_ops static David Miller <davem@davemloft.net> - 2017-02-17 18:20 +0100
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2017-02-16 10:20 +0100 |
| Subject | [PATCH] net: mvneta: make mvneta_eth_tool_ops static |
| Message-ID | <tbqoh-49F-3@gated-at.bofh.it> |
The mvneta_eth_tool_ops is only used internally in mvneta driver, so
make it static.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index fdf71720e707..61dd4462411c 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -3959,7 +3959,7 @@ static const struct net_device_ops mvneta_netdev_ops = {
.ndo_do_ioctl = mvneta_ioctl,
};
-const struct ethtool_ops mvneta_eth_tool_ops = {
+static const struct ethtool_ops mvneta_eth_tool_ops = {
.nway_reset = phy_ethtool_nway_reset,
.get_link = ethtool_op_get_link,
.set_coalesce = mvneta_ethtool_set_coalesce,
--
2.11.0
[toc] | [next] | [standalone]
| From | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
|---|---|
| Date | 2017-02-16 10:40 +0100 |
| Message-ID | <tbqHE-4hc-19@gated-at.bofh.it> |
| In reply to | #1582405 |
Hello, On Thu, 16 Feb 2017 17:07:39 +0800, Jisheng Zhang wrote: > The mvneta_eth_tool_ops is only used internally in mvneta driver, so > make it static. > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-02-17 18:20 +0100 |
| Message-ID | <tbUml-79M-5@gated-at.bofh.it> |
| In reply to | #1582405 |
From: Jisheng Zhang <jszhang@marvell.com> Date: Thu, 16 Feb 2017 17:07:39 +0800 > The mvneta_eth_tool_ops is only used internally in mvneta driver, so > make it static. > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> Applied to net-next, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web