Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583246 > unrolled thread
| Started by | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| First post | 2017-02-17 10:50 +0100 |
| Last post | 2017-02-17 11:00 +0100 |
| Articles | 8 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi <cpsethi369@gmail.com> - 2017-02-17 10:50 +0100
[PATCH v3 4/6] drivers: staging: fix coding style issue of using pr_notice instead of printk Chetan Sethi <cpsethi369@gmail.com> - 2017-02-17 10:50 +0100
Re: [PATCH v3 4/6] drivers: staging: fix coding style issue of using pr_notice instead of printk Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 19:00 +0100
[PATCH v3 5/6] drivers: staging: fix coding style issue of using __func__ instead of __FUNCTION__ Chetan Sethi <cpsethi369@gmail.com> - 2017-02-17 10:50 +0100
[PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi <cpsethi369@gmail.com> - 2017-02-17 10:50 +0100
Re: [PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 18:10 +0100
[PATCH v3 3/6] staging: ks7010: fix coding style issue of using tabs instead of spaces Chetan Sethi <cpsethi369@gmail.com> - 2017-02-17 10:50 +0100
[PATCH v3 6/6] drivers: staging: fix coding style issue of aligning comments properly Chetan Sethi <cpsethi369@gmail.com> - 2017-02-17 11:00 +0100
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-17 10:50 +0100 |
| Subject | [PATCH v3 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters |
| Message-ID | <tbNkS-2AC-11@gated-at.bofh.it> |
This is patch 01 to ks_wlan.h file in order to fix warning of line over 80 characters, as issued by checkpatch.pl Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject drivers/staging/ks7010/ks_wlan.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 9ab80e1..668202d 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -18,10 +18,10 @@ #include <linux/kernel.h> #include <linux/module.h> -#include <linux/spinlock.h> /* spinlock_t */ -#include <linux/sched.h> /* wait_queue_head_t */ -#include <linux/types.h> /* pid_t */ -#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ +#include <linux/spinlock.h> /* spinlock_t */ +#include <linux/sched.h> /* wait_queue_head_t */ +#include <linux/types.h> /* pid_t */ +#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ #include <linux/etherdevice.h> #include <linux/wireless.h> #include <linux/atomic.h> /* struct atomic_t */ @@ -36,7 +36,8 @@ #ifdef KS_WLAN_DEBUG #define DPRINTK(n, fmt, args...) \ - if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) + if (KS_WLAN_DEBUG > (n)) \ + printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) #else #define DPRINTK(n, fmt, args...) #endif -- 2.7.4
[toc] | [next] | [standalone]
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-17 10:50 +0100 |
| Subject | [PATCH v3 4/6] drivers: staging: fix coding style issue of using pr_notice instead of printk |
| Message-ID | <tbNkS-2AC-9@gated-at.bofh.it> |
| In reply to | #1583246 |
This is 04th patch to ks_wlan.h fixing coding style issue of using
pr_notice instead of printk, warning as issued by checkpatch.pl
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
drivers/staging/ks7010/ks_wlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 94b648b..78beca7 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -38,7 +38,7 @@
#define DPRINTK(n, fmt, args...) \
do { \
if (KS_WLAN_DEBUG > (n)) \
- printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+ pr_notice("%s: "fmt, __FUNCTION__, ## args); \
} while (0)
#else
#define DPRINTK(n, fmt, args...)
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-24 19:00 +0100 |
| Subject | Re: [PATCH v3 4/6] drivers: staging: fix coding style issue of using pr_notice instead of printk |
| Message-ID | <tesjU-3yY-15@gated-at.bofh.it> |
| In reply to | #1583247 |
On Fri, Feb 17, 2017 at 06:48:46PM +0900, Chetan Sethi wrote: > This is 04th patch to ks_wlan.h fixing coding style issue of using > pr_notice instead of printk, warning as issued by checkpatch.pl > > Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> > --- > v2: > - split multiple changes across different patches > v3: > - mentioned patch revision in subject Does not apply to my tree, did I miss some previous patches? Please resend the whole series. thanks, greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-17 10:50 +0100 |
| Subject | [PATCH v3 5/6] drivers: staging: fix coding style issue of using __func__ instead of __FUNCTION__ |
| Message-ID | <tbNkS-2AC-13@gated-at.bofh.it> |
| In reply to | #1583246 |
This is 05th patch to file ks_wlan.h which fixes coding style issue of
using __func__ instead of gcc specific __FUNCTION__, warning as issued by
checkpatch.pl
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
drivers/staging/ks7010/ks_wlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 78beca7..79737bf 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -38,7 +38,7 @@
#define DPRINTK(n, fmt, args...) \
do { \
if (KS_WLAN_DEBUG > (n)) \
- pr_notice("%s: "fmt, __FUNCTION__, ## args); \
+ pr_notice("%s: "fmt, __func__, ## args); \
} while (0)
#else
#define DPRINTK(n, fmt, args...)
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-17 10:50 +0100 |
| Subject | [PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses |
| Message-ID | <tbNkS-2AC-23@gated-at.bofh.it> |
| In reply to | #1583246 |
This is 02nd patch to file ks_wlan.h file fixing error of enclosing
complex macro value in parentheses
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
- incorporated review comment of correct indentation for do statement
drivers/staging/ks7010/ks_wlan.h | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 668202d..33d6b28 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -36,8 +36,10 @@
#ifdef KS_WLAN_DEBUG
#define DPRINTK(n, fmt, args...) \
- if (KS_WLAN_DEBUG > (n)) \
- printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+ do { \
+ if (KS_WLAN_DEBUG > (n)) \
+ printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
+ } while (0)
#else
#define DPRINTK(n, fmt, args...)
#endif
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-02-24 18:10 +0100 |
| Subject | Re: [PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses |
| Message-ID | <terxv-3hc-1@gated-at.bofh.it> |
| In reply to | #1583251 |
On Fri, Feb 17, 2017 at 06:47:39PM +0900, Chetan Sethi wrote:
> This is 02nd patch to file ks_wlan.h file fixing error of enclosing
> complex macro value in parentheses
No need to have the "This is the XXX patch..." in the changelog text,
you don't see that in any other commit logs, right?
>
> Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
> ---
> v2:
> - split multiple changes across different patches
> v3:
> - mentioned patch revision in subject
> - incorporated review comment of correct indentation for do statement
>
> drivers/staging/ks7010/ks_wlan.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
> index 668202d..33d6b28 100644
> --- a/drivers/staging/ks7010/ks_wlan.h
> +++ b/drivers/staging/ks7010/ks_wlan.h
> @@ -36,8 +36,10 @@
>
> #ifdef KS_WLAN_DEBUG
> #define DPRINTK(n, fmt, args...) \
> - if (KS_WLAN_DEBUG > (n)) \
> - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
> + do { \
Always run checkpatch on your patches so you don't get a grumpy
maintainer telling you to run your patches through checkpatch!
Please fix up all 3 of these and resend.
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-17 10:50 +0100 |
| Subject | [PATCH v3 3/6] staging: ks7010: fix coding style issue of using tabs instead of spaces |
| Message-ID | <tbNkS-2AC-21@gated-at.bofh.it> |
| In reply to | #1583246 |
This is 03rd patch to file ks_wlan.h fixing coding style issue of using
tabs instead of spaces at start of line, error as issued by checkpatch.pl
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
drivers/staging/ks7010/ks_wlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 33d6b28..94b648b 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -36,7 +36,7 @@
#ifdef KS_WLAN_DEBUG
#define DPRINTK(n, fmt, args...) \
- do { \
+ do { \
if (KS_WLAN_DEBUG > (n)) \
printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \
} while (0)
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Chetan Sethi <cpsethi369@gmail.com> |
|---|---|
| Date | 2017-02-17 11:00 +0100 |
| Subject | [PATCH v3 6/6] drivers: staging: fix coding style issue of aligning comments properly |
| Message-ID | <tbNux-2Ef-9@gated-at.bofh.it> |
| In reply to | #1583246 |
This is 06th patch to file ks_wlan.h in order to fix coding style issue
of having block comments using a trailing */ on a separate line, warning
as issued by checkpatch.pl
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
drivers/staging/ks7010/ks_wlan.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 79737bf..1a63704 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -359,7 +359,8 @@ struct wpa_key_t {
u8 rx_seq[IW_ENCODE_SEQ_MAX_SIZE]; /* LSB first */
struct sockaddr addr; /* ff:ff:ff:ff:ff:ff for broadcast/multicast
* (group) keys or unicast address for
- * individual keys */
+ * individual keys
+ */
u16 alg;
u16 key_len; /* WEP: 5 or 13, TKIP: 32, CCMP: 16 */
u8 key_val[IW_ENCODING_TOKEN_MAX];
--
2.7.4
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web