Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1580229 > unrolled thread
| Started by | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| First post | 2017-02-14 03:30 +0100 |
| Last post | 2017-02-17 09:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock Chen-Yu Tsai <wens@csie.org> - 2017-02-14 03:30 +0100
Re: [PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock Bob Ham <rah@settrans.net> - 2017-02-15 00:10 +0100
Re: [PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-17 09:50 +0100
Re: [PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-02-17 09:40 +0100
| From | Chen-Yu Tsai <wens@csie.org> |
|---|---|
| Date | 2017-02-14 03:30 +0100 |
| Subject | [PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock |
| Message-ID | <taB2q-3Rt-13@gated-at.bofh.it> |
The enable bit offset for the hdmi-ddc module clock is wrong. It is
pointing to the main hdmi module clock enable bit.
Reported-by: Bob Ham <rah@settrans.net>
Fixes: c6e6c96d8fa6 ("clk: sunxi-ng: Add A31/A31s clocks")
Cc: stable@vger.kernel.org # 4.9.x-
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
Hi Bob,
Can you try this patch and see if it fixes your HDMI issue?
With the kernel running without "clk_ignore_unused" that is.
---
drivers/clk/sunxi-ng/ccu-sun6i-a31.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-a31.c b/drivers/clk/sunxi-ng/ccu-sun6i-a31.c
index 4c9a920ff4ab..89e68d29bf45 100644
--- a/drivers/clk/sunxi-ng/ccu-sun6i-a31.c
+++ b/drivers/clk/sunxi-ng/ccu-sun6i-a31.c
@@ -608,7 +608,7 @@ static SUNXI_CCU_M_WITH_MUX_GATE(hdmi_clk, "hdmi", lcd_ch1_parents,
0x150, 0, 4, 24, 2, BIT(31),
CLK_SET_RATE_PARENT);
-static SUNXI_CCU_GATE(hdmi_ddc_clk, "hdmi-ddc", "osc24M", 0x150, BIT(31), 0);
+static SUNXI_CCU_GATE(hdmi_ddc_clk, "hdmi-ddc", "osc24M", 0x150, BIT(30), 0);
static SUNXI_CCU_GATE(ps_clk, "ps", "lcd1-ch1", 0x140, BIT(31), 0);
--
2.11.0
[toc] | [next] | [standalone]
| From | Bob Ham <rah@settrans.net> |
|---|---|
| Date | 2017-02-15 00:10 +0100 |
| Subject | Re: [PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock |
| Message-ID | <taUoq-8bx-9@gated-at.bofh.it> |
| In reply to | #1580229 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, 2017-02-14 at 10:23 +0800, Chen-Yu Tsai wrote:
> The enable bit offset for the hdmi-ddc module clock is wrong. It is
> pointing to the main hdmi module clock enable bit.
>
> Reported-by: Bob Ham <rah@settrans.net>
> Fixes: c6e6c96d8fa6 ("clk: sunxi-ng: Add A31/A31s clocks")
> Cc: stable@vger.kernel.org # 4.9.x-
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>
> Hi Bob,
>
> Can you try this patch and see if it fixes your HDMI issue?
> With the kernel running without "clk_ignore_unused" that is.
Hi Chen-Yu,
Unfortunately, that doesn't fix it; I get the same behaviour as without
clk_ignore_unused.
Thanks though,
Bob
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-02-17 09:50 +0100 |
| Subject | Re: [PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock |
| Message-ID | <tbMoN-1Y8-11@gated-at.bofh.it> |
| In reply to | #1580937 |
[Multipart message — attachments visible in raw view] — view raw
Hi Bob,
On Tue, Feb 14, 2017 at 10:20:55PM +0000, Bob Ham wrote:
> On Tue, 2017-02-14 at 10:23 +0800, Chen-Yu Tsai wrote:
> > The enable bit offset for the hdmi-ddc module clock is wrong. It is
> > pointing to the main hdmi module clock enable bit.
> >
> > Reported-by: Bob Ham <rah@settrans.net>
> > Fixes: c6e6c96d8fa6 ("clk: sunxi-ng: Add A31/A31s clocks")
> > Cc: stable@vger.kernel.org # 4.9.x-
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> > ---
> >
> > Hi Bob,
> >
> > Can you try this patch and see if it fixes your HDMI issue?
> > With the kernel running without "clk_ignore_unused" that is.
>
> Hi Chen-Yu,
>
> Unfortunately, that doesn't fix it; I get the same behaviour as without
> clk_ignore_unused.
can you apply that patch and give us your kernel boot logs?
Thanks!
------8<---------
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 820a939fb6bb..0a23b03ea393 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -773,7 +773,9 @@ static void clk_disable_unused_subtree(struct clk_core *core)
if (core->enable_count)
goto unlock_out;
- if (core->flags & CLK_IGNORE_UNUSED)
+ printk("Ignoring %s\n", core->name);
+
+ if (true)
goto unlock_out;
/*
-------8<-------
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-02-17 09:40 +0100 |
| Subject | Re: [PATCH] clk: sunxi-ng: sun6i: Fix enable bit offset for hdmi-ddc module clock |
| Message-ID | <tbMf7-1Su-13@gated-at.bofh.it> |
| In reply to | #1580229 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Feb 14, 2017 at 10:23:32AM +0800, Chen-Yu Tsai wrote:
> The enable bit offset for the hdmi-ddc module clock is wrong. It is
> pointing to the main hdmi module clock enable bit.
>
> Reported-by: Bob Ham <rah@settrans.net>
> Fixes: c6e6c96d8fa6 ("clk: sunxi-ng: Add A31/A31s clocks")
> Cc: stable@vger.kernel.org # 4.9.x-
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Queued as a fix for 4.11, thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web