Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1581345 > unrolled thread

[PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match

Started byCorentin Labbe <clabbe.montjoie@gmail.com>
First post2017-02-15 15:30 +0100
Last post2017-02-17 09:30 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-15 15:30 +0100
    Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match Frank Rowand <frowand.list@gmail.com> - 2017-02-15 16:40 +0100
      Re: [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-02-17 09:30 +0100

#1581345 — [PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match

FromCorentin Labbe <clabbe.montjoie@gmail.com>
Date2017-02-15 15:30 +0100
Subject[PATCH] of: add EXPORT_SYMBOL for of_device_compatible_match
Message-ID<tb8KK-170-5@gated-at.bofh.it>
This symbol will be needed for the dwmac-sun8i ethernet driver.
For letting it to be build as module, of_device_compatible_match need to
be exported.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 drivers/of/base.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index df6f6e3..fba351b 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
 
 	return score;
 }
+EXPORT_SYMBOL(of_device_compatible_match);
 
 /**
  * of_machine_is_compatible - Test root of device tree for a given compatible value
-- 
2.10.2

[toc] | [next] | [standalone]


#1581408

FromFrank Rowand <frowand.list@gmail.com>
Date2017-02-15 16:40 +0100
Message-ID<tb9Qt-1LT-7@gated-at.bofh.it>
In reply to#1581345
On 02/15/17 06:22, Corentin Labbe wrote:
> This symbol will be needed for the dwmac-sun8i ethernet driver.
> For letting it to be build as module, of_device_compatible_match need to
> be exported.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  drivers/of/base.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index df6f6e3..fba351b 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
>  
>  	return score;
>  }
> +EXPORT_SYMBOL(of_device_compatible_match);
>  
>  /**
>   * of_machine_is_compatible - Test root of device tree for a given compatible value
> 



Rob's reply to the last person who requested that:

   It's not missing because no modules use it. It's generally preferred
   to use a match table and of_match_node.

-Frank

[toc] | [prev] | [next] | [standalone]


#1583196

FromCorentin Labbe <clabbe.montjoie@gmail.com>
Date2017-02-17 09:30 +0100
Message-ID<tbM5s-1KD-7@gated-at.bofh.it>
In reply to#1581408
On Wed, Feb 15, 2017 at 07:34:57AM -0800, Frank Rowand wrote:
> On 02/15/17 06:22, Corentin Labbe wrote:
> > This symbol will be needed for the dwmac-sun8i ethernet driver.
> > For letting it to be build as module, of_device_compatible_match need to
> > be exported.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> >  drivers/of/base.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/of/base.c b/drivers/of/base.c
> > index df6f6e3..fba351b 100644
> > --- a/drivers/of/base.c
> > +++ b/drivers/of/base.c
> > @@ -524,6 +524,7 @@ int of_device_compatible_match(struct device_node *device,
> >  
> >  	return score;
> >  }
> > +EXPORT_SYMBOL(of_device_compatible_match);
> >  
> >  /**
> >   * of_machine_is_compatible - Test root of device tree for a given compatible value
> > 
> 
> 
> 
> Rob's reply to the last person who requested that:
> 
>    It's not missing because no modules use it. It's generally preferred
>    to use a match table and of_match_node.
> 
> -Frank

I replace of_device_compatible_match like you said and it works.
Thanks
Corentin Labbe

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web