Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1583129 > unrolled thread
| Started by | Joe Perches <joe@perches.com> |
|---|---|
| First post | 2017-02-17 08:20 +0100 |
| Last post | 2017-02-17 08:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 27/35] drivers/platform: Convert remaining uses of pr_warning to pr_warn Joe Perches <joe@perches.com> - 2017-02-17 08:20 +0100
Re: [PATCH 27/35] drivers/platform: Convert remaining uses of pr_warning to pr_warn Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-17 08:50 +0100
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-17 08:20 +0100 |
| Subject | [PATCH 27/35] drivers/platform: Convert remaining uses of pr_warning to pr_warn |
| Message-ID | <tbKZI-176-19@gated-at.bofh.it> |
To enable eventual removal of pr_warning
This makes pr_warn use consistent for drivers/platform
Prior to this patch, there were 7 uses of pr_warning and
108 uses of pr_warn in drivers/platform
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/platform/x86/asus-laptop.c | 2 +-
drivers/platform/x86/eeepc-laptop.c | 2 +-
drivers/platform/x86/intel_oaktrail.c | 10 +++++-----
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
index 28551f5a2e07..7f248f84f49a 100644
--- a/drivers/platform/x86/asus-laptop.c
+++ b/drivers/platform/x86/asus-laptop.c
@@ -1163,7 +1163,7 @@ static void asus_als_switch(struct asus_laptop *asus, int value)
ret = write_acpi_int(asus->handle, METHOD_ALS_CONTROL, value);
}
if (ret)
- pr_warning("Error setting light sensor switch\n");
+ pr_warn("Error setting light sensor switch\n");
asus->light_switch = value;
}
diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
index 8cdf315f9730..09f93eb49230 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers/platform/x86/eeepc-laptop.c
@@ -585,7 +585,7 @@ static void eeepc_rfkill_hotplug(struct eeepc_laptop *eeepc, acpi_handle handle)
port = acpi_get_pci_dev(handle);
if (!port) {
- pr_warning("Unable to find port\n");
+ pr_warn("Unable to find port\n");
goto out_unlock;
}
diff --git a/drivers/platform/x86/intel_oaktrail.c b/drivers/platform/x86/intel_oaktrail.c
index 6aa33c4a809f..133b2f04643d 100644
--- a/drivers/platform/x86/intel_oaktrail.c
+++ b/drivers/platform/x86/intel_oaktrail.c
@@ -257,7 +257,7 @@ static int oaktrail_backlight_init(void)
if (IS_ERR(bd)) {
oaktrail_bl_device = NULL;
- pr_warning("Unable to register backlight device\n");
+ pr_warn("Unable to register backlight device\n");
return PTR_ERR(bd);
}
@@ -327,20 +327,20 @@ static int __init oaktrail_init(void)
ret = platform_driver_register(&oaktrail_driver);
if (ret) {
- pr_warning("Unable to register platform driver\n");
+ pr_warn("Unable to register platform driver\n");
goto err_driver_reg;
}
oaktrail_device = platform_device_alloc(DRIVER_NAME, -1);
if (!oaktrail_device) {
- pr_warning("Unable to allocate platform device\n");
+ pr_warn("Unable to allocate platform device\n");
ret = -ENOMEM;
goto err_device_alloc;
}
ret = platform_device_add(oaktrail_device);
if (ret) {
- pr_warning("Unable to add platform device\n");
+ pr_warn("Unable to add platform device\n");
goto err_device_add;
}
@@ -352,7 +352,7 @@ static int __init oaktrail_init(void)
ret = oaktrail_rfkill_init();
if (ret) {
- pr_warning("Setup rfkill failed\n");
+ pr_warn("Setup rfkill failed\n");
goto err_rfkill;
}
--
2.10.0.rc2.1.g053435c
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-02-17 08:50 +0100 |
| Subject | Re: [PATCH 27/35] drivers/platform: Convert remaining uses of pr_warning to pr_warn |
| Message-ID | <tbLsK-1hg-7@gated-at.bofh.it> |
| In reply to | #1583129 |
On Fri, Feb 17, 2017 at 9:11 AM, Joe Perches <joe@perches.com> wrote:
> To enable eventual removal of pr_warning
>
> This makes pr_warn use consistent for drivers/platform
>
> Prior to this patch, there were 7 uses of pr_warning and
> 108 uses of pr_warn in drivers/platform
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/platform/x86/asus-laptop.c | 2 +-
> drivers/platform/x86/eeepc-laptop.c | 2 +-
> drivers/platform/x86/intel_oaktrail.c | 10 +++++-----
> 3 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 28551f5a2e07..7f248f84f49a 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -1163,7 +1163,7 @@ static void asus_als_switch(struct asus_laptop *asus, int value)
> ret = write_acpi_int(asus->handle, METHOD_ALS_CONTROL, value);
> }
> if (ret)
> - pr_warning("Error setting light sensor switch\n");
> + pr_warn("Error setting light sensor switch\n");
>
> asus->light_switch = value;
> }
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index 8cdf315f9730..09f93eb49230 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -585,7 +585,7 @@ static void eeepc_rfkill_hotplug(struct eeepc_laptop *eeepc, acpi_handle handle)
>
> port = acpi_get_pci_dev(handle);
> if (!port) {
> - pr_warning("Unable to find port\n");
> + pr_warn("Unable to find port\n");
> goto out_unlock;
> }
>
> diff --git a/drivers/platform/x86/intel_oaktrail.c b/drivers/platform/x86/intel_oaktrail.c
> index 6aa33c4a809f..133b2f04643d 100644
> --- a/drivers/platform/x86/intel_oaktrail.c
> +++ b/drivers/platform/x86/intel_oaktrail.c
> @@ -257,7 +257,7 @@ static int oaktrail_backlight_init(void)
>
> if (IS_ERR(bd)) {
> oaktrail_bl_device = NULL;
> - pr_warning("Unable to register backlight device\n");
> + pr_warn("Unable to register backlight device\n");
> return PTR_ERR(bd);
> }
>
> @@ -327,20 +327,20 @@ static int __init oaktrail_init(void)
>
> ret = platform_driver_register(&oaktrail_driver);
> if (ret) {
> - pr_warning("Unable to register platform driver\n");
> + pr_warn("Unable to register platform driver\n");
> goto err_driver_reg;
> }
>
> oaktrail_device = platform_device_alloc(DRIVER_NAME, -1);
> if (!oaktrail_device) {
> - pr_warning("Unable to allocate platform device\n");
> + pr_warn("Unable to allocate platform device\n");
> ret = -ENOMEM;
> goto err_device_alloc;
> }
>
> ret = platform_device_add(oaktrail_device);
> if (ret) {
> - pr_warning("Unable to add platform device\n");
> + pr_warn("Unable to add platform device\n");
> goto err_device_add;
> }
>
> @@ -352,7 +352,7 @@ static int __init oaktrail_init(void)
>
> ret = oaktrail_rfkill_init();
> if (ret) {
> - pr_warning("Setup rfkill failed\n");
> + pr_warn("Setup rfkill failed\n");
> goto err_rfkill;
> }
>
> --
> 2.10.0.rc2.1.g053435c
>
--
With Best Regards,
Andy Shevchenko
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web