Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1581125 > unrolled thread

[PATCH] staging: xgifb: function definition argument should also have an identifier name

Started byArushi Singhal <arushisinghal19971997@gmail.com>
First post2017-02-15 09:40 +0100
Last post2017-02-16 19:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] staging: xgifb: function definition argument should also  have an identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-15 09:40 +0100
    Re: [PATCH] staging: xgifb: function definition argument should also  have an identifier name Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-16 19:40 +0100

#1581125 — [PATCH] staging: xgifb: function definition argument should also have an identifier name

FromArushi Singhal <arushisinghal19971997@gmail.com>
Date2017-02-15 09:40 +0100
Subject[PATCH] staging: xgifb: function definition argument should also have an identifier name
Message-ID<tb3i2-5YV-13@gated-at.bofh.it>
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/xgifb/vb_init.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
index 500cabe41a3c..e4929314d33e 100644
--- a/drivers/staging/xgifb/vb_init.h
+++ b/drivers/staging/xgifb/vb_init.h
@@ -1,6 +1,6 @@
 #ifndef _VBINIT_
 #define _VBINIT_
 unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long BaseAddr);
 #endif
 
-- 
2.11.0

[toc] | [next] | [standalone]


#1582841

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2017-02-16 19:40 +0100
Message-ID<tbz8d-1OZ-7@gated-at.bofh.it>
In reply to#1581125
On Wed, Feb 15, 2017 at 02:01:47PM +0530, Arushi Singhal wrote:
> function definition argument 'struct vb_device_info *' and 'unsigned
> long' should also have an identifier name.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  drivers/staging/xgifb/vb_init.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You sent two patches, both different, for the same file with the same
subject line, so I don't know what to do, so I will just delete both
from my inbox.

Please fix up, and resend.

thanks,

greg k-h

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web