Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579153 > unrolled thread

[PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions

Started byWang YanQing <udknight@gmail.com>
First post2017-02-12 03:50 +0100
Last post2017-02-14 07:50 +0100
Articles 4 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] tools:perf:scripting-engines: Fix compile error with some  perl5 versions Wang YanQing <udknight@gmail.com> - 2017-02-12 03:50 +0100
    Re: [PATCH] tools:perf:scripting-engines: Fix compile error with  some perl5 versions Jiri Olsa <jolsa@redhat.com> - 2017-02-13 09:20 +0100
      Re: [PATCH] tools:perf:scripting-engines: Fix compile error with  some perl5 versions Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-02-13 17:20 +0100
    [tip:perf/core] perf scripting perl: Fix compile error with some  perl5 versions tip-bot for Wang YanQing <tipbot@zytor.com> - 2017-02-14 07:50 +0100

#1579153 — [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions

FromWang YanQing <udknight@gmail.com>
Date2017-02-12 03:50 +0100
Subject[PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions
Message-ID<t9SoG-py-3@gated-at.bofh.it>
Fix below compile error:
CC       util/scripting-engines/trace-event-perl.o
In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
                 from util/scripting-engines/trace-event-perl.c:31:
/usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
/usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
        dTHX;   /* The function called below requires thread context */
			     ^
cc1: all warnings being treated as errors

After digging perl5 repository, I find out that we will meet this compile error
with perl from v5.21.1 to v5.25.4

Signed-off-by: Wang YanQing <udknight@gmail.com>
---
 tools/perf/util/scripting-engines/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/scripting-engines/Build b/tools/perf/util/scripting-engines/Build
index 6516e22..82d28c6 100644
--- a/tools/perf/util/scripting-engines/Build
+++ b/tools/perf/util/scripting-engines/Build
@@ -1,6 +1,6 @@
 libperf-$(CONFIG_LIBPERL)   += trace-event-perl.o
 libperf-$(CONFIG_LIBPYTHON) += trace-event-python.o
 
-CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-undef -Wno-switch-default
+CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-nested-externs -Wno-undef -Wno-switch-default
 
 CFLAGS_trace-event-python.o += $(PYTHON_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow
-- 
1.8.5.6.2.g3d8a54e.dirty

[toc] | [next] | [standalone]

#1579509 — Re: [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions

FromJiri Olsa <jolsa@redhat.com>
Date2017-02-13 09:20 +0100
SubjectRe: [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions
Message-ID<tak1A-18Q-17@gated-at.bofh.it>
In reply to#1579153
On Sun, Feb 12, 2017 at 10:46:55AM +0800, Wang YanQing wrote:
> Fix below compile error:
> CC       util/scripting-engines/trace-event-perl.o
> In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
>                  from util/scripting-engines/trace-event-perl.c:31:
> /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
> /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
>         dTHX;   /* The function called below requires thread context */
> 			     ^
> cc1: all warnings being treated as errors
> 
> After digging perl5 repository, I find out that we will meet this compile error
> with perl from v5.21.1 to v5.25.4
> 
> Signed-off-by: Wang YanQing <udknight@gmail.com>

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> ---
>  tools/perf/util/scripting-engines/Build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/scripting-engines/Build b/tools/perf/util/scripting-engines/Build
> index 6516e22..82d28c6 100644
> --- a/tools/perf/util/scripting-engines/Build
> +++ b/tools/perf/util/scripting-engines/Build
> @@ -1,6 +1,6 @@
>  libperf-$(CONFIG_LIBPERL)   += trace-event-perl.o
>  libperf-$(CONFIG_LIBPYTHON) += trace-event-python.o
>  
> -CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-undef -Wno-switch-default
> +CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-nested-externs -Wno-undef -Wno-switch-default
>  
>  CFLAGS_trace-event-python.o += $(PYTHON_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow
> -- 
> 1.8.5.6.2.g3d8a54e.dirty
>

[toc] | [prev] | [next] | [standalone]

#1579917 — Re: [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2017-02-13 17:20 +0100
SubjectRe: [PATCH] tools:perf:scripting-engines: Fix compile error with some perl5 versions
Message-ID<tarw7-63D-21@gated-at.bofh.it>
In reply to#1579509
Em Mon, Feb 13, 2017 at 09:19:18AM +0100, Jiri Olsa escreveu:
> On Sun, Feb 12, 2017 at 10:46:55AM +0800, Wang YanQing wrote:
> > Fix below compile error:
> > CC       util/scripting-engines/trace-event-perl.o
> > In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
> >                  from util/scripting-engines/trace-event-perl.c:31:
> > /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
> > /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
> >         dTHX;   /* The function called below requires thread context */
> > 			     ^
> > cc1: all warnings being treated as errors
> > 
> > After digging perl5 repository, I find out that we will meet this compile error
> > with perl from v5.21.1 to v5.25.4
> > 
> > Signed-off-by: Wang YanQing <udknight@gmail.com>
> 
> Acked-by: Jiri Olsa <jolsa@redhat.com>

Thanks, applied.

- Arnaldo

[toc] | [prev] | [next] | [standalone]

#1580336 — [tip:perf/core] perf scripting perl: Fix compile error with some perl5 versions

Fromtip-bot for Wang YanQing <tipbot@zytor.com>
Date2017-02-14 07:50 +0100
Subject[tip:perf/core] perf scripting perl: Fix compile error with some perl5 versions
Message-ID<taF61-6BY-7@gated-at.bofh.it>
In reply to#1579153
Commit-ID:  d7dd112ea5cacf91ae72c0714c3b911eb6016fea
Gitweb:     http://git.kernel.org/tip/d7dd112ea5cacf91ae72c0714c3b911eb6016fea
Author:     Wang YanQing <udknight@gmail.com>
AuthorDate: Sun, 12 Feb 2017 10:46:55 +0800
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 13 Feb 2017 17:22:32 -0300

perf scripting perl: Fix compile error with some perl5 versions

Fix below compile error:

  CC       util/scripting-engines/trace-event-perl.o
  In file included from /usr/lib/perl5/5.22.2/i686-linux/CORE/perl.h:5673:0,
                   from util/scripting-engines/trace-event-perl.c:31:
  /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h: In function 'S__is_utf8_char_slow':
  /usr/lib/perl5/5.22.2/i686-linux/CORE/inline.h:270:5: error: nested extern declaration of 'Perl___notused' [-Werror=nested-externs]
          dTHX;   /* The function called below requires thread context */
			     ^
  cc1: all warnings being treated as errors

After digging perl5 repository, I find out that we will meet this
compile error with perl from v5.21.1 to v5.25.4

Signed-off-by: Wang YanQing <udknight@gmail.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20170212024655.GA15997@udknight
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/scripting-engines/Build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/scripting-engines/Build b/tools/perf/util/scripting-engines/Build
index 6516e22..82d28c6 100644
--- a/tools/perf/util/scripting-engines/Build
+++ b/tools/perf/util/scripting-engines/Build
@@ -1,6 +1,6 @@
 libperf-$(CONFIG_LIBPERL)   += trace-event-perl.o
 libperf-$(CONFIG_LIBPYTHON) += trace-event-python.o
 
-CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-undef -Wno-switch-default
+CFLAGS_trace-event-perl.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow -Wno-nested-externs -Wno-undef -Wno-switch-default
 
 CFLAGS_trace-event-python.o += $(PYTHON_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-shadow

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web