Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1579182 > unrolled thread

[PATCH] bcm2835-audio: Fix checkpatch errors

Back to article view | Back to linux.kernel

Contents

  [PATCH] bcm2835-audio: Fix checkpatch errors Man Choy <manchoyy@gmail.com> - 2017-02-12 09:50 +0100
    Re: [PATCH] bcm2835-audio: Fix checkpatch errors Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-12 13:20 +0100
      Re: [PATCH] bcm2835-audio: Fix checkpatch errors Man Choy <manchoyy@gmail.com> - 2017-02-13 01:50 +0100
        Re: [PATCH] bcm2835-audio: Fix checkpatch errors Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-13 13:10 +0100
          Re: [PATCH] bcm2835-audio: Fix checkpatch errors Man Choy <manchoyy@gmail.com> - 2017-02-14 02:20 +0100

#1579182 — [PATCH] bcm2835-audio: Fix checkpatch errors

Fix following errors:

ERROR: do not initialise statics to NULL
+static struct snd_card *g_card = NULL;

ERROR: do not initialise statics to NULL
+static struct bcm2835_chip *g_chip = NULL;

Signed-off-by: Man Choy <manchoyy@gmail.com>
---
 drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
index a84d74d..265fe55 100644
--- a/drivers/staging/bcm2835-audio/bcm2835.c
+++ b/drivers/staging/bcm2835-audio/bcm2835.c
@@ -28,8 +28,8 @@
  * to debug if we run into issues
  */
 
-static struct snd_card *g_card = NULL;
-static struct bcm2835_chip *g_chip = NULL;
+static struct snd_card *g_card;
+static struct bcm2835_chip *g_chip;
 
 static int snd_bcm2835_free(struct bcm2835_chip *chip)
 {
-- 
2.7.4

[toc] | [next] | [standalone]

#1579204

On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote:
> Fix following errors:
> 
> ERROR: do not initialise statics to NULL
> +static struct snd_card *g_card = NULL;
> 
> ERROR: do not initialise statics to NULL
> +static struct bcm2835_chip *g_chip = NULL;
> 
> Signed-off-by: Man Choy <manchoyy@gmail.com>
> ---
>  drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
> index a84d74d..265fe55 100644
> --- a/drivers/staging/bcm2835-audio/bcm2835.c
> +++ b/drivers/staging/bcm2835-audio/bcm2835.c
> @@ -28,8 +28,8 @@
>   * to debug if we run into issues
>   */
>  
> -static struct snd_card *g_card = NULL;
> -static struct bcm2835_chip *g_chip = NULL;
> +static struct snd_card *g_card;
> +static struct bcm2835_chip *g_chip;
>  
>  static int snd_bcm2835_free(struct bcm2835_chip *chip)
>  {

Someone sent this same fix in before you did, a few days ago.  Be sure
to always use the most up-to-date tree.

sorry,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1579338

On Sun, Feb 12, 2017 at 8:16 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote:
>> Fix following errors:
>>
>> ERROR: do not initialise statics to NULL
>> +static struct snd_card *g_card = NULL;
>>
>> ERROR: do not initialise statics to NULL
>> +static struct bcm2835_chip *g_chip = NULL;
>>
>> Signed-off-by: Man Choy <manchoyy@gmail.com>
>> ---
>>  drivers/staging/bcm2835-audio/bcm2835.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c
>> index a84d74d..265fe55 100644
>> --- a/drivers/staging/bcm2835-audio/bcm2835.c
>> +++ b/drivers/staging/bcm2835-audio/bcm2835.c
>> @@ -28,8 +28,8 @@
>>   * to debug if we run into issues
>>   */
>>
>> -static struct snd_card *g_card = NULL;
>> -static struct bcm2835_chip *g_chip = NULL;
>> +static struct snd_card *g_card;
>> +static struct bcm2835_chip *g_chip;
>>
>>  static int snd_bcm2835_free(struct bcm2835_chip *chip)
>>  {
>
> Someone sent this same fix in before you did, a few days ago.  Be sure
> to always use the most up-to-date tree.
>
> sorry,
>
> greg k-h

Please ignore previous email. It contains HTML.

Noted and thanks Greg.

A quick question, I just updated my linux-next tree last night,
checkout tag "next-20170210" and working on the cleanup. How do I
double check my current working file already been updated by someone
else to avoid the duplicate work? As of now, the latest linux-next
tree tag is still "next-20170210"

I am on eudyptula challenge and this is my first attempt to send
kernel patch, sorry about the silly question ;)

MC

[toc] | [prev] | [next] | [standalone]

#1579665

On Mon, Feb 13, 2017 at 08:49:06AM +0800, Man Choy wrote:
> A quick question, I just updated my linux-next tree last night,
> checkout tag "next-20170210" and working on the cleanup. How do I
> double check my current working file already been updated by someone
> else to avoid the duplicate work? As of now, the latest linux-next
> tree tag is still "next-20170210"

linux-next is usually a day or so behind my tree, due to the time
differences when it is created and why I usually do work.

You can work off of my staging-next branch in my staging.git tree on
git.kernel.org, that is the most up-to-date branch that ends up in
linux-next.  I also use staging-testing, to test things, but I would not
recommend that for you as it can be rebased and would be a pain to work
against.

It's ok that conflicts happen, that's how kernel development works,
sometimes people send in the same change minutes from each other, so I
have to take the one that was sent first.  It's ok, just move on and
work on something else if you really want to.

> I am on eudyptula challenge and this is my first attempt to send
> kernel patch, sorry about the silly question ;)

It's not silly, it comes up all the time.

good luck!

greg k-h

[toc] | [prev] | [next] | [standalone]

#1580179

On Mon, Feb 13, 2017 at 8:03 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Mon, Feb 13, 2017 at 08:49:06AM +0800, Man Choy wrote:
>> A quick question, I just updated my linux-next tree last night,
>> checkout tag "next-20170210" and working on the cleanup. How do I
>> double check my current working file already been updated by someone
>> else to avoid the duplicate work? As of now, the latest linux-next
>> tree tag is still "next-20170210"
>
> linux-next is usually a day or so behind my tree, due to the time
> differences when it is created and why I usually do work.
>
> You can work off of my staging-next branch in my staging.git tree on
> git.kernel.org, that is the most up-to-date branch that ends up in
> linux-next.  I also use staging-testing, to test things, but I would not
> recommend that for you as it can be rebased and would be a pain to work
> against.
>
> It's ok that conflicts happen, that's how kernel development works,
> sometimes people send in the same change minutes from each other, so I
> have to take the one that was sent first.  It's ok, just move on and
> work on something else if you really want to.
>
>> I am on eudyptula challenge and this is my first attempt to send
>> kernel patch, sorry about the silly question ;)
>
> It's not silly, it comes up all the time.
>
> good luck!
>
> greg k-h

Thanks for the kind advice.

I will look up your staging-next branch and do something about it.

Talk to you soon.

- MC

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web