Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1577500 > unrolled thread

[PATCH v2] arm64: use is_vmalloc_addr

Started byMiles Chen <miles.chen@mediatek.com>
First post2017-02-09 13:00 +0100
Last post2017-02-13 14:00 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2] arm64: use is_vmalloc_addr Miles Chen <miles.chen@mediatek.com> - 2017-02-09 13:00 +0100
    Re: [PATCH v2] arm64: use is_vmalloc_addr Andreas Färber <afaerber@suse.de> - 2017-02-13 06:30 +0100
      Re: [PATCH v2] arm64: use is_vmalloc_addr Miles Chen <miles.chen@mediatek.com> - 2017-02-13 14:00 +0100

#1577500 — [PATCH v2] arm64: use is_vmalloc_addr

FromMiles Chen <miles.chen@mediatek.com>
Date2017-02-09 13:00 +0100
Subject[PATCH v2] arm64: use is_vmalloc_addr
Message-ID<t8Vyi-5Gs-9@gated-at.bofh.it>
To is_vmalloc_addr() to check if an address is a vmalloc address
instead of checking VMALLOC_START and VMALLOC_END manually.

Signed-off-by: Miles Chen <miles.chen@mediatek.com>
---
 arch/arm64/mm/ioremap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/mm/ioremap.c b/arch/arm64/mm/ioremap.c
index 01e88c8..c4c8cd4 100644
--- a/arch/arm64/mm/ioremap.c
+++ b/arch/arm64/mm/ioremap.c
@@ -88,7 +88,7 @@ void __iounmap(volatile void __iomem *io_addr)
 	 * We could get an address outside vmalloc range in case
 	 * of ioremap_cache() reusing a RAM mapping.
 	 */
-	if (VMALLOC_START <= addr && addr < VMALLOC_END)
+	if (is_vmalloc_addr((void *)addr))
 		vunmap((void *)addr);
 }
 EXPORT_SYMBOL(__iounmap);
-- 
1.9.1

[toc] | [next] | [standalone]


#1579414

FromAndreas Färber <afaerber@suse.de>
Date2017-02-13 06:30 +0100
Message-ID<tahn3-7GZ-7@gated-at.bofh.it>
In reply to#1577500
Hi,

Am 09.02.2017 um 12:45 schrieb Miles Chen:
> To is_vmalloc_addr() to check if an address is a vmalloc address

"Use ..."?

Regards,
Andreas

> instead of checking VMALLOC_START and VMALLOC_END manually.
> 
> Signed-off-by: Miles Chen <miles.chen@mediatek.com>

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

[toc] | [prev] | [next] | [standalone]


#1579688

FromMiles Chen <miles.chen@mediatek.com>
Date2017-02-13 14:00 +0100
Message-ID<taoox-3Oq-3@gated-at.bofh.it>
In reply to#1579414
On Mon, 2017-02-13 at 06:20 +0100, Andreas Färber wrote:
> Hi,
> 
> Am 09.02.2017 um 12:45 schrieb Miles Chen:
> > To is_vmalloc_addr() to check if an address is a vmalloc address
> 
> "Use ..."?

Yes, it should be "Use". I'll send another patch to fix this.

> 
> Regards,
> Andreas
> 
> > instead of checking VMALLOC_START and VMALLOC_END manually.
> > 
> > Signed-off-by: Miles Chen <miles.chen@mediatek.com>
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web